From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=nImdQGpY; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Thu, 11 Jul 2019 03:48:23 -0700 Received: by mail-wm1-f68.google.com with SMTP id p74so5179646wme.4 for ; Thu, 11 Jul 2019 03:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KmFedYpUZcH+hHIqtQ65stXcpa1OPNp/G0MtajwOm8A=; b=nImdQGpYiXjt2qA8QyDrTaONC9RNynUWSqb5hJeBXOX5pweh9JdaP5cK52N0GZUYWI XasYnb+pe5ExVIgR1fInC7yk/DpvjXM1yVzh1DaJgeq6yTpHoI52bLZrhGsK2NAjL6uO 13BO0Dbkj1f2PaN1a3MGGzNUN+lR/4AF1LfAc2eTii/8AnYvQzV4rPaJAZDgAMW8iWQc noEF2U2Fnc9GZfKCzCjco3HrKwBuHANskCbv/KZ2dnrwUQ3V71gutOOXKhjTAORgO0HO LBOF55ZNGPP++O+nXdJhQye340dxdLJEYXa1mjiAJMYvzN9h85GhI1fjDNhbj3HAFC6x 7pxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KmFedYpUZcH+hHIqtQ65stXcpa1OPNp/G0MtajwOm8A=; b=HbwxOpiOFS9Ocff8y5eX5E8pYxxztrEGv/mTHxHST1RA8KQdhj1EuZO6a4mKv07F3s EhTQnDwX33hwV9YmfrfDtVx/w6GZKrJafAU4tPAeZ/Hk0w3fsqHGbol77e8I55+Ev0k+ hmKeVGuvbJaDto2MHzY6YD9CsoJ1DY5T/P8DIkv61bcyJBw7oCSzSiknWvfgDY7rZmaA bpcYtqmFt6x7csJOrnODBL4I+EkMZXcsqt99HnW39m+YmOT9YYWpKWF65BsiEjoIauMi RS1xqzHnq5+NZDHjs+p3VuUChJQAFIzVimJ7F/1WqlsjobYt28LgpzyC/ueloaN7dkzT C+qQ== X-Gm-Message-State: APjAAAUc4Xv5JondfNkl7wEIPDCAjiWKcT/X+9HnsGXMNoF2SZEMGl3P 9r+YXkjt+aB/h2krAVHwLh/FEw== X-Google-Smtp-Source: APXvYqy6Fc+wJ6BEtZtgzgbdRFH69BDMbflixZf0Q7NvsvL4DUV81I2sz2EmgQ69uEZGzQf5JLIQlA== X-Received: by 2002:a7b:c144:: with SMTP id z4mr3844774wmi.50.1562842101288; Thu, 11 Jul 2019 03:48:21 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b8sm5636714wmh.46.2019.07.11.03.48.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jul 2019 03:48:20 -0700 (PDT) Date: Thu, 11 Jul 2019 11:48:18 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: "Gao, Zhichao" , "Dong, Eric" , "devel@edk2.groups.io" , Sean Brogan , "Ni, Ray" , "Gao, Liming" , Michael Turner , Bret Barkelew , Michael Kinney , Andrew Fish Subject: Re: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol Message-ID: <20190711104818.twe7fcof2kkzkmt2@bivouac.eciton.net> References: <20190709083956.13024-1-zhichao.gao@intel.com> <20190709083956.13024-3-zhichao.gao@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B807187@SHSMSX101.ccr.corp.intel.com> <95279da1-9212-4f34-6600-474fa1703517@redhat.com> MIME-Version: 1.0 In-Reply-To: <95279da1-9212-4f34-6600-474fa1703517@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 11, 2019 at 12:24:46PM +0200, Laszlo Ersek wrote: > Every single source file must have both copyright notice(s) and > licensing information. > > - Licensing information without copyright holder(s) makes zero sense -- > the licensing terms are offered / dictated *by* the copyright holders. > > - A copyright notice in itself, without a suitable license (including > the "no license" case) does not provide us with the necessary rights to > carry the source file in the edk2 project. Agree with all of the above. > Regarding "EnableInterrupts.nasm". This looks like a tricky situation. > Under the above link, the file is currently missing a Microsoft (C) > notice (the last commit to modify the file is apparently from Microsoft, > b621971). So that should be addressed in Project Mu first, in my opinion. > > Then, Microsoft should please relicense the file under BSD+Patent, from > pure 2-BSD. If they disagree, then the 2-BSD is still acceptable for edk2. > > Then, the file could be imported into edk2, carrying > - the MS (C) notice, > - the Intel (C) notice (extended to 2019), > - the license -- BSD+Patent, or else 2-BSD --, expressed with an SPDX ID > (not open-coded license text). While I agree it would be better if Microsoft relicensed it as BSD+Patent, BSD+Patent is a strict superset of 2-clause BSD - so there is no point in TianoCore to carry 2-Clause BSD code. We can just add the explicit patent grant on contribution (i.e. change the license header for a BSD+Patent SPDX tag). And we should, because otherwise without the tianocore contribution agreement, we open ourselves up to submarine contributions. The downside to doing that would be if we wanted the code to be able to flow in both directions, which is why it would be good if Microsoft relicensed (and also because then they would be making an explicit statement that they weren't trying to submarine TianoCore). Best Regards, Leif