Re: [PATCH 3/3] BaseTools: add GetMaintainer.py script

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Sat, Jul 13, 2019 at 12:58:18AM +0200, Laszlo Ersek wrote:
> On 07/12/19 19:01, Leif Lindholm wrote:
> > Add a new script GetMaintainer.py that uses the new Maintainer.txt format
> > to determine which addresses to cc on patch submission.
> > 
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > ---
> >  BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++
> >  1 file changed, 190 insertions(+)
> >  create mode 100644 BaseTools/Scripts/GetMaintainer.py
> 
> I should really re-review this from zero, but it's 0:55 AM again. :/
> 
> Anyway, I think this script is a good candidate for gradual improvements
> (should such ever become necessary, that is). The script doesn't have to
> be perfect to be incredibly useful.
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks!

> ... Did you have me in mind for the ArmVirtPkg and OvmfPkg pathname
> patterns, for replacing the natural language pointers? :)

That would be ideal, thanks. I might miss something if I did it.
I would be happy to push them together with 1-2/3 once ready.

Best Regards,

Leif