From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=cnK3iaan; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Sat, 13 Jul 2019 03:41:33 -0700 Received: by mail-wm1-f66.google.com with SMTP id v15so10990375wml.0 for ; Sat, 13 Jul 2019 03:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1eoRzkk42deHcI4z1x4c8h56u0D29V8DLVPva7v86Ig=; b=cnK3iaan/k2OBzkxFsllZGlrznnxB3cDJSgZGmLm1/mT3ns3SAAWqe9zP3Op5GuVEC RuWlsYSLMzjrTNtUxvDSZfC81QW3XJ/lTnYlgHk+jquG5WwMKFy4BYZIn0Hbwvw6FDNZ 8uJcXDaEb1iL0zjLONwdYBaDSg5AAJf46OvWULFnx/X7eTJNNxiEOb5U1u5j2qlqnMr5 vPsieVjqQgZNPY7H38fX9G8Hovdx3BNn3zGbN17Co2l4Qo3ed85c3M9gqSDZ7EGIlQIa /GDBq73PnfUIQialOtjM+VseVandXQy7wElTLc5AiMRUYOIB1QuNft3rpCQtJ8/7Qk+r tZdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1eoRzkk42deHcI4z1x4c8h56u0D29V8DLVPva7v86Ig=; b=Z8qyeyJln1aGLK0pJ6UgWn0piOD8BJl0Hro3og0Z/G7/rvSklXIHNH7vI0P8pUeKFo lHj+17rfQu+vZB9kU4OBJVVoS03+0iY6ZIGgvmNUmqtUffFEj3aIMy/zCHX9wRo+fEak NU/Jn3yUdJ0UCbpi7/VGSlO3//B3e96kFxbdI2UKdGQKcG3MM8TMsUrZqb2XuY/pEJtC 1KbyQMoB+iLfdFdvOc2AHy1IkuIzU2HkiacxqiEECzFXB11nrNZYRmfteERD6+FkaPPG kEYr2rAl8qTO1EDtrP2gsjsKnAPhETbsqRWPJaV9PUB/URlAO4c9OTUsn2kwcRSrNMR2 LYow== X-Gm-Message-State: APjAAAUJeFMTXYAm08beHLV/D+O/FMTTLXvEreUTgZuz6lN5D45Ngdkt D3O/81EeyNJRzlCNDoVH9W9mfw== X-Google-Smtp-Source: APXvYqxoDpPuQGmg8uoT2nSG3hboFuMZPRgq/wAS6HANK6VBOvIQUkHzHFJ7zskAlOKZ3+IBfk0W7g== X-Received: by 2002:a1c:dc07:: with SMTP id t7mr14975467wmg.164.1563014491788; Sat, 13 Jul 2019 03:41:31 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u2sm12312698wmc.3.2019.07.13.03.41.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Jul 2019 03:41:30 -0700 (PDT) Date: Sat, 13 Jul 2019 11:41:29 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, Andrew Fish , Michael D Kinney , Philippe Mathieu-Daude , Bob Feng , Liming Gao Subject: Re: [PATCH 3/3] BaseTools: add GetMaintainer.py script Message-ID: <20190713104128.pvydmrzbbg7kalkh@bivouac.eciton.net> References: <20190712170128.6495-1-leif.lindholm@linaro.org> <20190712170128.6495-4-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jul 13, 2019 at 12:58:18AM +0200, Laszlo Ersek wrote: > On 07/12/19 19:01, Leif Lindholm wrote: > > Add a new script GetMaintainer.py that uses the new Maintainer.txt format > > to determine which addresses to cc on patch submission. > > > > Signed-off-by: Leif Lindholm > > Reviewed-by: Philippe Mathieu-Daude > > Tested-by: Philippe Mathieu-Daude > > --- > > BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ > > 1 file changed, 190 insertions(+) > > create mode 100644 BaseTools/Scripts/GetMaintainer.py > > I should really re-review this from zero, but it's 0:55 AM again. :/ > > Anyway, I think this script is a good candidate for gradual improvements > (should such ever become necessary, that is). The script doesn't have to > be perfect to be incredibly useful. > > Acked-by: Laszlo Ersek Thanks! > ... Did you have me in mind for the ArmVirtPkg and OvmfPkg pathname > patterns, for replacing the natural language pointers? :) That would be ideal, thanks. I might miss something if I did it. I would be happy to push them together with 1-2/3 once ready. Best Regards, Leif