From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ecAiwGUk; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Mon, 15 Jul 2019 07:55:25 -0700 Received: by mail-wm1-f66.google.com with SMTP id s15so15545788wmj.3 for ; Mon, 15 Jul 2019 07:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xGZI5oLDmUW7ZHeJzgv5suEMY+mpbdKUg37y9oiw1nA=; b=ecAiwGUkx3XDsPyouVWg2JWFDriJE08p/AehHQsPGIGapoDXDgtLKX6EEZJl+A7ovg YoDDjlFjf9e8xsGPlW8FeiLb6kV6TcESNjxIFzQr9fpAk+9W7XcVkhcqU2r/delvgvXK a3ovfESlRugtA6j+S3PmZFQ3k2ChVtz8Erobzrl7Xd8Wy3AKma5F6Ys4753KF+J+G8so iYLLMvqEH+z4yr5unQBsweb/NGekwVAOLBCTS0wIShHZNlaK4KTLK1oBtxpET3RUa7Uq bk8TBuXo18nyaNwnkd+/B0ZCV5A5ZVISW4HoCYUjagN8LFOPQKiGO4DgoTWa0v6a4Atr B0eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xGZI5oLDmUW7ZHeJzgv5suEMY+mpbdKUg37y9oiw1nA=; b=Zz0FJGd7/n1Z2yjSzpNy/YI+lodhQecW7lsRXgN8dF9ZPd7J4QNfQLLGhuEihoWHOp Nx5SA8rXmqGje+4xHgWvwOaSRqu3r5irjQ6V+E5qo0yunUACRTvbPkYSYxLCNRMwXYUs GUfP5bfCnM/5XFRQWqXQgGyPSJlGRNeDMnkXsvVAziQhNMSPASBmZ8zhn8Lef4wrodrn yd2BrLrsWlIwNfV2OrteaPBPFYSQJO/ym2XKYZ72VeI05R2N/2PEXICeMlbz8XJm9z4J 0SAyMX2e1kcKXwBsglEAMCsmuvUdkayt1Uf6Fz9qo7ZDxA6KOXfdp+YMYdRQhHEP+Cxi IWJQ== X-Gm-Message-State: APjAAAVPuzrUmqBPRSToY2MwMKdbHItUeE3fNhQKysDM11OcvGkWKS0c VZWu5EDLtdprh97g+TevfJ4V+A== X-Google-Smtp-Source: APXvYqzhMEN83Az07lsoUyDekeI/xHsY1hRRmeqduzAhOBz+PwDSq0HAHU0xZTvKqKOF2LrKnddQDA== X-Received: by 2002:a7b:c0d0:: with SMTP id s16mr25613236wmh.141.1563202523235; Mon, 15 Jul 2019 07:55:23 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 91sm35349366wrp.3.2019.07.15.07.55.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jul 2019 07:55:22 -0700 (PDT) Date: Mon, 15 Jul 2019 15:55:21 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, lersek@redhat.com, Bob Feng , Liming Gao , Michael Kinney , Andrew Fish Subject: Re: [edk2-devel] [PATCH] Simplify edksetup.sh Message-ID: <20190715145521.4nkakcli5rjjjaun@bivouac.eciton.net> References: <20190710211726.10100-1-rebecca@bsdio.com> <8f3a022b-de01-27b7-d9d3-064eb1bf7232@redhat.com> <7c2a34b2-c582-496e-b5c8-12035432a9fe@bsdio.com> MIME-Version: 1.0 In-Reply-To: <7c2a34b2-c582-496e-b5c8-12035432a9fe@bsdio.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 15, 2019 at 08:40:21AM -0600, Rebecca Cran wrote: > On 2019-07-12 16:21, Laszlo Ersek wrote: > > > > As long as my opinion counts... (and I totally don't insist that it do): > > the above task list will make for a nice 6-part patch series. :) > > > > (When someone is tempted to capture a *list* of changes in a single > > commit message, that frequently indicates that the patch should be split > > up, so that each change get its own dedicated patch.) > > While I can see your point, in this case I think splitting the patch up > into 6 parts would be excessive. All the changes are to a single file, > and a couple of the changes in the list are to single lines. For me, the question is more with being able to trivially discern which patch does what. I agree they're all individually trivial, but as a single patch there is enough going on at once that it makes it easier for bugs to slip through review. (And we've had issues with this in the past in edksetup.sh.) / Leif