[PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

[PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

[Laszlo Ersek]

Repo:   https://github.com/lersek/edk2.git
Branch: ovmfpkg_maintainers

The patches in this series should be inserted between Leif's patches

* [edk2-devel] [PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
  http://mid.mail-archive.com/20190712170128.6495-3-leif.lindholm@linaro.org
  https://edk2.groups.io/g/devel/message/43665

and

* [edk2-devel] [PATCH 3/3] BaseTools: add GetMaintainer.py script
  http://mid.mail-archive.com/20190712170128.6495-4-leif.lindholm@linaro.org
  https://edk2.groups.io/g/devel/message/43666

That's also how you will find them in my topic branch, referenced above
(in particular, look for the "Message-Id" tags on Leif's patches,
appended by my invocation of "git-am -m").

My understanding is that Leif would only like to pick up these patches
once they are ready for pushing. That is, if corrections are necessary,
I should post v2 (and I should post v2 of these four patches only) --
Leif's series and mine will only be unified for the pushing.

(Technically, Leif could incorporate these patches at once in his topic
branch, and post a unified v2; assuming corrections were necessary for
the OvmfPkg-related patches. That's because I expect minimal changes if
any, which Leif could implement on top "mindlessly". Of course, that's
also the argument against Leif writing the updates -- we shouldn't shove
mindless work over to other people. :) Anyway, I'm fine either way.)

Cc: Andrew Fish <afish@apple.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>

Thanks
Laszlo

Laszlo Ersek (4):
  Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen"
  Maintainers.txt: split out section "OvmfPkg: Xen-related modules"
  Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related
    modules"
  Maintainers.txt: split out section "OvmfPkg: CSM modules"

 Maintainers.txt | 52 +++++++++++++++++---
 1 file changed, 44 insertions(+), 8 deletions(-)

-- 
2.19.1.3.g30247aa5d201

[PATCH 1/4] Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen"

[Laszlo Ersek]

We ask contributors to copy Julien on patches that affect "Xen modules"
under ArmVirtPkg. With the "GetMaintainer.py" script being introduced
later, express this expectation in "Maintainers.txt" in machine-readable
format.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    - Spelling out actual module names, in place of ArmVirtPkg/Library/Xen*
      and ArmVirtPkg/Xen* wildcards, makes for better readability in my
      opinion.
    
    - ArmVirtPkg/PrePi/ is shared with the ArmVirtQemuKernel platform, hence
      a section header that states "modules used on Xen", and not just "Xen
      modules" (as the latter might imply "Xen-only" modules).

 Maintainers.txt | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 52d8215691b1..e9ab3b3b372a 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -106,16 +106,25 @@ M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
 
 ArmVirtPkg
 F: ArmVirtPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
 M: Laszlo Ersek <lersek@redhat.com>
 M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
-R: Julien Grall <julien.grall@arm.com>
-   (Xen modules)
 R: Leif Lindholm <leif.lindholm@linaro.org>
 
+ArmVirtPkg: modules used on Xen
+F: ArmVirtPkg/ArmVirtXen.*
+F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
+F: ArmVirtPkg/Library/XenRealTimeClockLib/
+F: ArmVirtPkg/Library/XenVirtMemInfoLib/
+F: ArmVirtPkg/PrePi/
+F: ArmVirtPkg/XenAcpiPlatformDxe/
+F: ArmVirtPkg/XenPlatformHasAcpiDtDxe/
+F: ArmVirtPkg/XenioFdtDxe/
+R: Julien Grall <julien.grall@arm.com>
+
 BaseTools
 F: BaseTools/
 W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
 M: Bob Feng <bob.c.feng@intel.com>
 M: Liming Gao <liming.gao@intel.com>
 
-- 
2.19.1.3.g30247aa5d201

[PATCH 2/4] Maintainers.txt: split out section "OvmfPkg: Xen-related modules"

[Laszlo Ersek]

We ask contributors to copy Anthony and Julien on patches that affect "Xen
modules" under OvmfPkg. With the "GetMaintainer.py" script being
introduced later, express this expectation in "Maintainers.txt" in
machine-readable format.

Cc: Andrew Fish <afish@apple.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    - Spelling out actual module names, in place of OvmfPkg/Library/Xen* and
      OvmfPkg/Xen* wildcards, makes for better readability in my opinion.

 Maintainers.txt | 28 +++++++++++++++++---
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index e9ab3b3b372a..3a690b2ee200 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -206,24 +206,44 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
 OvmfPkg
 F: OvmfPkg/
 W: http://www.tianocore.org/ovmf/
 M: Jordan Justen <jordan.l.justen@intel.com>
 M: Laszlo Ersek <lersek@redhat.com>
 M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
-R: Anthony Perard <anthony.perard@citrix.com>
-   (Xen modules)
-R: Julien Grall <julien.grall@arm.com>
-   (Xen modules)
 R: Marc-André Lureau <marcandre.lureau@redhat.com>
    (TPM2 modules)
 R: Stefan Berger <stefanb@linux.ibm.com>
    (TPM2 modules)
 R: David Woodhouse <dwmw2@infradead.org>
    (CSM modules)
 S: Maintained
 
+OvmfPkg: Xen-related modules
+F: OvmfPkg/AcpiPlatformDxe/Xen.c
+F: OvmfPkg/Include/Guid/XenBusRootDevice.h
+F: OvmfPkg/Include/Guid/XenInfo.h
+F: OvmfPkg/Include/IndustryStandard/Xen/
+F: OvmfPkg/Include/Library/XenHypercallLib.h
+F: OvmfPkg/Include/Library/XenIoMmioLib.h
+F: OvmfPkg/Include/Protocol/XenBus.h
+F: OvmfPkg/Include/Protocol/XenIo.h
+F: OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
+F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+F: OvmfPkg/Library/XenConsoleSerialPortLib/
+F: OvmfPkg/Library/XenHypercallLib/
+F: OvmfPkg/Library/XenIoMmioLib/
+F: OvmfPkg/PlatformPei/MemDetect.c
+F: OvmfPkg/PlatformPei/Platform.*
+F: OvmfPkg/PlatformPei/Xen.*
+F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
+F: OvmfPkg/XenBusDxe/
+F: OvmfPkg/XenIoPciDxe/
+F: OvmfPkg/XenPvBlkDxe/
+R: Anthony Perard <anthony.perard@citrix.com>
+R: Julien Grall <julien.grall@arm.com>
+
 PcAtChipsetPkg
 F: PcAtChipsetPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
 M: Ray Ni <ray.ni@intel.com>
 
 SecurityPkg
-- 
2.19.1.3.g30247aa5d201

[PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

[Laszlo Ersek]

We ask contributors to copy Marc-André and Stefan on patches that affect
"TPM2 modules" under OvmfPkg. With the "GetMaintainer.py" script being
introduced later, express this expectation in "Maintainers.txt" in
machine-readable format.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Maintainers.txt | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 3a690b2ee200..31ec66b3cb0d 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -206,16 +206,12 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
 OvmfPkg
 F: OvmfPkg/
 W: http://www.tianocore.org/ovmf/
 M: Jordan Justen <jordan.l.justen@intel.com>
 M: Laszlo Ersek <lersek@redhat.com>
 M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
-R: Marc-André Lureau <marcandre.lureau@redhat.com>
-   (TPM2 modules)
-R: Stefan Berger <stefanb@linux.ibm.com>
-   (TPM2 modules)
 R: David Woodhouse <dwmw2@infradead.org>
    (CSM modules)
 S: Maintained
 
 OvmfPkg: Xen-related modules
 F: OvmfPkg/AcpiPlatformDxe/Xen.c
@@ -238,12 +234,21 @@ F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
 F: OvmfPkg/XenBusDxe/
 F: OvmfPkg/XenIoPciDxe/
 F: OvmfPkg/XenPvBlkDxe/
 R: Anthony Perard <anthony.perard@citrix.com>
 R: Julien Grall <julien.grall@arm.com>
 
+OvmfPkg: TCG- and TPM2-related modules
+F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
+F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
+F: OvmfPkg/PlatformPei/ClearCache.c
+F: OvmfPkg/Tcg/
+R: Marc-André Lureau <marcandre.lureau@redhat.com>
+R: Stefan Berger <stefanb@linux.ibm.com>
+
 PcAtChipsetPkg
 F: PcAtChipsetPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
 M: Ray Ni <ray.ni@intel.com>
 
 SecurityPkg
-- 
2.19.1.3.g30247aa5d201

[PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[Laszlo Ersek]

We ask contributors to copy David on patches that affect "CSM modules"
under OvmfPkg. With the "GetMaintainer.py" script being introduced later,
express this expectation in "Maintainers.txt" in machine-readable format.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Maintainers.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 31ec66b3cb0d..18fd2ef43cb7 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -206,14 +206,12 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
 OvmfPkg
 F: OvmfPkg/
 W: http://www.tianocore.org/ovmf/
 M: Jordan Justen <jordan.l.justen@intel.com>
 M: Laszlo Ersek <lersek@redhat.com>
 M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
-R: David Woodhouse <dwmw2@infradead.org>
-   (CSM modules)
 S: Maintained
 
 OvmfPkg: Xen-related modules
 F: OvmfPkg/AcpiPlatformDxe/Xen.c
 F: OvmfPkg/Include/Guid/XenBusRootDevice.h
 F: OvmfPkg/Include/Guid/XenInfo.h
@@ -243,12 +241,16 @@ F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
 F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
 F: OvmfPkg/PlatformPei/ClearCache.c
 F: OvmfPkg/Tcg/
 R: Marc-André Lureau <marcandre.lureau@redhat.com>
 R: Stefan Berger <stefanb@linux.ibm.com>
 
+OvmfPkg: CSM modules
+F: OvmfPkg/Csm/
+R: David Woodhouse <dwmw2@infradead.org>
+
 PcAtChipsetPkg
 F: PcAtChipsetPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
 M: Ray Ni <ray.ni@intel.com>
 
 SecurityPkg
-- 
2.19.1.3.g30247aa5d201

Re: [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

[Philippe Mathieu-Daudé]

On 7/15/19 7:04 PM, Laszlo Ersek wrote:
> We ask contributors to copy Marc-André and Stefan on patches that affect
> "TPM2 modules" under OvmfPkg. With the "GetMaintainer.py" script being
> introduced later, express this expectation in "Maintainers.txt" in
> machine-readable format.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  Maintainers.txt | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 3a690b2ee200..31ec66b3cb0d 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -206,16 +206,12 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
>  OvmfPkg
>  F: OvmfPkg/
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
>  M: Laszlo Ersek <lersek@redhat.com>
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> -R: Marc-André Lureau <marcandre.lureau@redhat.com>
> -   (TPM2 modules)
> -R: Stefan Berger <stefanb@linux.ibm.com>
> -   (TPM2 modules)
>  R: David Woodhouse <dwmw2@infradead.org>
>     (CSM modules)
>  S: Maintained
>  
>  OvmfPkg: Xen-related modules
>  F: OvmfPkg/AcpiPlatformDxe/Xen.c
> @@ -238,12 +234,21 @@ F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
>  F: OvmfPkg/XenBusDxe/
>  F: OvmfPkg/XenIoPciDxe/
>  F: OvmfPkg/XenPvBlkDxe/
>  R: Anthony Perard <anthony.perard@citrix.com>
>  R: Julien Grall <julien.grall@arm.com>
>  
> +OvmfPkg: TCG- and TPM2-related modules

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> +F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
> +F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
> +F: OvmfPkg/PlatformPei/ClearCache.c
> +F: OvmfPkg/Tcg/
> +R: Marc-André Lureau <marcandre.lureau@redhat.com>
> +R: Stefan Berger <stefanb@linux.ibm.com>
> +
>  PcAtChipsetPkg
>  F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>  
>  SecurityPkg
> 

Re: [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[Philippe Mathieu-Daudé]

On 7/15/19 7:04 PM, Laszlo Ersek wrote:
> We ask contributors to copy David on patches that affect "CSM modules"
> under OvmfPkg. With the "GetMaintainer.py" script being introduced later,
> express this expectation in "Maintainers.txt" in machine-readable format.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  Maintainers.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 31ec66b3cb0d..18fd2ef43cb7 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -206,14 +206,12 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
>  OvmfPkg
>  F: OvmfPkg/
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
>  M: Laszlo Ersek <lersek@redhat.com>
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> -R: David Woodhouse <dwmw2@infradead.org>
> -   (CSM modules)
>  S: Maintained
>  
>  OvmfPkg: Xen-related modules
>  F: OvmfPkg/AcpiPlatformDxe/Xen.c
>  F: OvmfPkg/Include/Guid/XenBusRootDevice.h
>  F: OvmfPkg/Include/Guid/XenInfo.h
> @@ -243,12 +241,16 @@ F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>  F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
>  F: OvmfPkg/PlatformPei/ClearCache.c
>  F: OvmfPkg/Tcg/
>  R: Marc-André Lureau <marcandre.lureau@redhat.com>
>  R: Stefan Berger <stefanb@linux.ibm.com>
>  
> +OvmfPkg: CSM modules
> +F: OvmfPkg/Csm/
> +R: David Woodhouse <dwmw2@infradead.org>
> +

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>  PcAtChipsetPkg
>  F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>  
>  SecurityPkg
> 

Re: [PATCH 1/4] Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen"

[Julien Grall]

Hi,

On 15/07/2019 18:04, Laszlo Ersek wrote:
> We ask contributors to copy Julien on patches that affect "Xen modules"
> under ArmVirtPkg. With the "GetMaintainer.py" script being introduced
> later, express this expectation in "Maintainers.txt" in machine-readable
> format.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

FWIW:

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

-- 
Julien Grall

Re: [PATCH 2/4] Maintainers.txt: split out section "OvmfPkg: Xen-related modules"

[Julien Grall]

Hi,

On 15/07/2019 18:04, Laszlo Ersek wrote:
> We ask contributors to copy Anthony and Julien on patches that affect "Xen
> modules" under OvmfPkg. With the "GetMaintainer.py" script being
> introduced later, express this expectation in "Maintainers.txt" in
> machine-readable format.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

-- 
Julien Grall

Re: [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[Laszlo Ersek]

Hi David,

On 07/15/19 19:08, David Woodhouse wrote:
> On Mon, 2019-07-15 at 19:07 +0200, Philippe Mathieu-Daudé wrote:
>> On 7/15/19 7:04 PM, Laszlo Ersek wrote:
>>> We ask contributors to copy David on patches that affect "CSM modules"
>>> under OvmfPkg. With the "GetMaintainer.py" script being introduced later,
>>> express this expectation in "Maintainers.txt" in machine-readable format.
>>>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>>> ---
>>>  Maintainers.txt | 6 ++++--
>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>> index 31ec66b3cb0d..18fd2ef43cb7 100644
>>> --- a/Maintainers.txt
>>> +++ b/Maintainers.txt
>>> @@ -206,14 +206,12 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
>>>  OvmfPkg
>>>  F: OvmfPkg/
>>>  W: http://www.tianocore.org/ovmf/
>>>  M: Jordan Justen <jordan.l.justen@intel.com>
>>>  M: Laszlo Ersek <lersek@redhat.com>
>>>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> -R: David Woodhouse <dwmw2@infradead.org>
>>> -   (CSM modules)
>>>  S: Maintained
>>>  
>>>  OvmfPkg: Xen-related modules
>>>  F: OvmfPkg/AcpiPlatformDxe/Xen.c
>>>  F: OvmfPkg/Include/Guid/XenBusRootDevice.h
>>>  F: OvmfPkg/Include/Guid/XenInfo.h
>>> @@ -243,12 +241,16 @@ F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>>>  F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
>>>  F: OvmfPkg/PlatformPei/ClearCache.c
>>>  F: OvmfPkg/Tcg/
>>>  R: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>  R: Stefan Berger <stefanb@linux.ibm.com>
>>>  
>>> +OvmfPkg: CSM modules
>>> +F: OvmfPkg/Csm/
>>> +R: David Woodhouse <dwmw2@infradead.org>
>>> +
>>
>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 
> Acked-by: David Woodhouse <dwmw2@infradead.org>
> 
> 

something must have gone wrong -- I don't see your message in my list
folder, and I haven't received a moderation request either. Do you have
an idea why your message may not have reached the list, or been
reflected by the list?

The <mail-archive.com> list archive is missing your message too:

http://mid.mail-archive.com/bd9d4d7cc0fcdcb7e909f9bdf76f9d8bb050327d.camel@infradead.org

Thanks
Laszlo

Re: [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote:
> something must have gone wrong -- I don't see your message in my list
> folder, and I haven't received a moderation request either. Do you have
> an idea why your message may not have reached the list, or been
> reflected by the list?
> 
> The <mail-archive.com> list archive is missing your message too:
> 
> http://mid.mail-archive.com/bd9d4d7cc0fcdcb7e909f9bdf76f9d8bb050327d.camel@infradead.org

It was rejected, with a message saying "Your account is bouncing.
Please visit the web site to unbounce your account."

I have just done so. I did wonder if it actually meant that its email
to me was bouncing — but apparently not, since if that was the case
then it'd have a bounce message or an SMTP rejection to show me. It
didn't; just a link to click to "unbounce" my account. So I've no idea
what that's all about... just groups.io weirdness?


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]

Re: [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[Laszlo Ersek]

Stephano,

On 07/17/19 00:05, David Woodhouse wrote:
> On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote:
>> something must have gone wrong -- I don't see your message in my list
>> folder, and I haven't received a moderation request either. Do you have
>> an idea why your message may not have reached the list, or been
>> reflected by the list?
>>
>> The <mail-archive.com> list archive is missing your message too:
>>
>> http://mid.mail-archive.com/bd9d4d7cc0fcdcb7e909f9bdf76f9d8bb050327d.camel@infradead.org
> 
> It was rejected, with a message saying "Your account is bouncing.
> Please visit the web site to unbounce your account."
> 
> I have just done so. I did wonder if it actually meant that its email
> to me was bouncing — but apparently not, since if that was the case
> then it'd have a bounce message or an SMTP rejection to show me. It
> didn't; just a link to click to "unbounce" my account. So I've no idea
> what that's all about... just groups.io weirdness?

if you have time for this, may we please ask the groups.io admins as to
what happened to David's message (please see the msgid included in the
above link: <bd9d4d7cc0fcdcb7e909f9bdf76f9d8bb050327d.camel@infradead.org>).

Normally I wouldn't obsess about this too much, but David is a
designated reviewer; it's not going to be a productive use of his time
if his messages are repeatedly rejected.

Thanks!
Laszlo

Re: [PATCH 2/4] Maintainers.txt: split out section "OvmfPkg: Xen-related modules"

[Anthony PERARD]

On Mon, Jul 15, 2019 at 07:04:29PM +0200, Laszlo Ersek wrote:
> We ask contributors to copy Anthony and Julien on patches that affect "Xen
> modules" under OvmfPkg. With the "GetMaintainer.py" script being
> introduced later, express this expectation in "Maintainers.txt" in
> machine-readable format.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

Re: [PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

[Philippe Mathieu-Daudé]

On 7/15/19 7:04 PM, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: ovmfpkg_maintainers
> 
> The patches in this series should be inserted between Leif's patches
> 
> * [edk2-devel] [PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
>   http://mid.mail-archive.com/20190712170128.6495-3-leif.lindholm@linaro.org
>   https://edk2.groups.io/g/devel/message/43665
> 
> and
> 
> * [edk2-devel] [PATCH 3/3] BaseTools: add GetMaintainer.py script
>   http://mid.mail-archive.com/20190712170128.6495-4-leif.lindholm@linaro.org
>   https://edk2.groups.io/g/devel/message/43666
> 
> That's also how you will find them in my topic branch, referenced above
> (in particular, look for the "Message-Id" tags on Leif's patches,
> appended by my invocation of "git-am -m").
> 
> My understanding is that Leif would only like to pick up these patches
> once they are ready for pushing. That is, if corrections are necessary,
> I should post v2 (and I should post v2 of these four patches only) --
> Leif's series and mine will only be unified for the pushing.
> 
> (Technically, Leif could incorporate these patches at once in his topic
> branch, and post a unified v2; assuming corrections were necessary for
> the OvmfPkg-related patches. That's because I expect minimal changes if
> any, which Leif could implement on top "mindlessly". Of course, that's
> also the argument against Leif writing the updates -- we shouldn't shove
> mindless work over to other people. :) Anyway, I'm fine either way.)
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (4):
>   Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen"
>   Maintainers.txt: split out section "OvmfPkg: Xen-related modules"
>   Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related
>     modules"
>   Maintainers.txt: split out section "OvmfPkg: CSM modules"
> 
>  Maintainers.txt | 52 +++++++++++++++++---
>  1 file changed, 44 insertions(+), 8 deletions(-)

FWIW, for this series:
Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
(with various paths from each new sections, and also from the previous
section, then comparating).

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 2580 bytes --]

On Wed, 2019-07-17 at 11:38 +0200, Laszlo Ersek wrote:
> Stephano,
> 
> On 07/17/19 00:05, David Woodhouse wrote:
> > On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote:
> > > something must have gone wrong -- I don't see your message in my list
> > > folder, and I haven't received a moderation request either. Do you have
> > > an idea why your message may not have reached the list, or been
> > > reflected by the list?
> > > 
> > > The <mail-archive.com> list archive is missing your message too:
> > > 
> > > http://mid.mail-archive.com/bd9d4d7cc0fcdcb7e909f9bdf76f9d8bb050327d.camel@infradead.org
> > 
> > It was rejected, with a message saying "Your account is bouncing.
> > Please visit the web site to unbounce your account."
> > 
> > I have just done so. I did wonder if it actually meant that its email
> > to me was bouncing — but apparently not, since if that was the case
> > then it'd have a bounce message or an SMTP rejection to show me. It
> > didn't; just a link to click to "unbounce" my account. So I've no idea
> > what that's all about... just groups.io weirdness?
> 
> if you have time for this, may we please ask the groups.io admins as to
> what happened to David's message (please see the msgid included in the
> above link: <bd9d4d7cc0fcdcb7e909f9bdf76f9d8bb050327d.camel@infradead.org>).
> 
> Normally I wouldn't obsess about this too much, but David is a
> designated reviewer; it's not going to be a productive use of his time
> if his messages are repeatedly rejected.

I apparently stopped receiving messages on 2019-06-28. Looking at my
MTA logs, I was receiving messages just fine from addresses of the form
bounce+27952+43034+1459038+4027854@groups.io until at 20:55:37 GMT
there was a message from an invalid address which got rejected:

2019-06-28 20:55:37 +0000 H=web01.groups.io [66.175.222.12] sender verify fail for <bounceprobe+1459038+8818881604274358745@groups.io>: lb01.groups.io [45.79.81.153] : SMTP error from remote mail server after RCPT TO:<bounceprobe+1459038+8818881604274358745@groups.io>: 510 The group 'bounceprobe+1459038+8818881604274358745' does not exist.
2019-06-28 20:55:37 +0000 H=web01.groups.io [66.175.222.12] X=TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128 CV=no F=<bounceprobe+1459038+8818881604274358745@groups.io> rejected RCPT <dwmw2@infradead.org>: Sender verify failed
2019-06-28 20:55:37 +0000 unexpected disconnection while reading SMTP command from web01.groups.io [66.175.222.12] D=4s

After rejecting that invalid mail, nothing else from the list was received.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]

Re: [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

[Marc-André Lureau]

Hi

On Mon, Jul 15, 2019 at 9:04 PM Laszlo Ersek <lersek@redhat.com> wrote:
>
> We ask contributors to copy Marc-André and Stefan on patches that affect
> "TPM2 modules" under OvmfPkg. With the "GetMaintainer.py" script being
> introduced later, express this expectation in "Maintainers.txt" in
> machine-readable format.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  Maintainers.txt | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 3a690b2ee200..31ec66b3cb0d 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -206,16 +206,12 @@ M: Jiaxin Wu <jiaxin.wu@intel.com>
>  OvmfPkg
>  F: OvmfPkg/
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
>  M: Laszlo Ersek <lersek@redhat.com>
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> -R: Marc-André Lureau <marcandre.lureau@redhat.com>
> -   (TPM2 modules)
> -R: Stefan Berger <stefanb@linux.ibm.com>
> -   (TPM2 modules)
>  R: David Woodhouse <dwmw2@infradead.org>
>     (CSM modules)
>  S: Maintained
>
>  OvmfPkg: Xen-related modules
>  F: OvmfPkg/AcpiPlatformDxe/Xen.c
> @@ -238,12 +234,21 @@ F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
>  F: OvmfPkg/XenBusDxe/
>  F: OvmfPkg/XenIoPciDxe/
>  F: OvmfPkg/XenPvBlkDxe/
>  R: Anthony Perard <anthony.perard@citrix.com>
>  R: Julien Grall <julien.grall@arm.com>
>
> +OvmfPkg: TCG- and TPM2-related modules
> +F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
> +F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
> +F: OvmfPkg/PlatformPei/ClearCache.c
> +F: OvmfPkg/Tcg/
> +R: Marc-André Lureau <marcandre.lureau@redhat.com>
> +R: Stefan Berger <stefanb@linux.ibm.com>
> +
>  PcAtChipsetPkg
>  F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>
>  SecurityPkg
> --
> 2.19.1.3.g30247aa5d201
>
>

Re: [PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

[Laszlo Ersek]

On 07/18/19 06:54, Philippe Mathieu-Daudé wrote:
> On 7/15/19 7:04 PM, Laszlo Ersek wrote:
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: ovmfpkg_maintainers
>>
>> The patches in this series should be inserted between Leif's patches
>>
>> * [edk2-devel] [PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
>>   http://mid.mail-archive.com/20190712170128.6495-3-leif.lindholm@linaro.org
>>   https://edk2.groups.io/g/devel/message/43665
>>
>> and
>>
>> * [edk2-devel] [PATCH 3/3] BaseTools: add GetMaintainer.py script
>>   http://mid.mail-archive.com/20190712170128.6495-4-leif.lindholm@linaro.org
>>   https://edk2.groups.io/g/devel/message/43666
>>
>> That's also how you will find them in my topic branch, referenced above
>> (in particular, look for the "Message-Id" tags on Leif's patches,
>> appended by my invocation of "git-am -m").
>>
>> My understanding is that Leif would only like to pick up these patches
>> once they are ready for pushing. That is, if corrections are necessary,
>> I should post v2 (and I should post v2 of these four patches only) --
>> Leif's series and mine will only be unified for the pushing.
>>
>> (Technically, Leif could incorporate these patches at once in his topic
>> branch, and post a unified v2; assuming corrections were necessary for
>> the OvmfPkg-related patches. That's because I expect minimal changes if
>> any, which Leif could implement on top "mindlessly". Of course, that's
>> also the argument against Leif writing the updates -- we shouldn't shove
>> mindless work over to other people. :) Anyway, I'm fine either way.)
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Julien Grall <julien.grall@arm.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Stefan Berger <stefanb@linux.ibm.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (4):
>>   Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen"
>>   Maintainers.txt: split out section "OvmfPkg: Xen-related modules"
>>   Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related
>>     modules"
>>   Maintainers.txt: split out section "OvmfPkg: CSM modules"
>>
>>  Maintainers.txt | 52 +++++++++++++++++---
>>  1 file changed, 44 insertions(+), 8 deletions(-)
> 
> FWIW, for this series:
> Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
> (with various paths from each new sections, and also from the previous
> section, then comparating).
> 

Thank you!
Laszlo

Re: [edk2-devel] [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

[stefanb]

On 7/18/19 4:56 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jul 15, 2019 at 9:04 PM Laszlo Ersek <lersek@redhat.com> wrote:
>> We ask contributors to copy Marc-André and Stefan on patches that affect
>> "TPM2 modules" under OvmfPkg. With the "GetMaintainer.py" script being
>> introduced later, express this expectation in "Maintainers.txt" in
>> machine-readable format.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Stefan Berger <stefanb@linux.ibm.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

[Cetola, Stephano]

> -----Original Message-----
> From: David Woodhouse [mailto:dwmw2@infradead.org]
> Sent: Thursday, July 18, 2019 12:31 AM
> To: devel@edk2.groups.io; lersek@redhat.com; Philippe Mathieu-Daudé
> <philmd@redhat.com>; Cetola, Stephano <stephano.cetola@intel.com>
> Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Leif Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section
> "OvmfPkg: CSM modules"
> 
> I apparently stopped receiving messages on 2019-06-28. Looking at my
> MTA logs, I was receiving messages just fine from addresses of the form
> bounce+27952+43034+1459038+4027854@groups.io until at 20:55:37 GMT
> there was a message from an invalid address which got rejected:

Interesting. Looking at the logs that I have access to (admittedly limited), there
were a few bounces back in June:

Jun 15
[edk2-devel] [edk2-platforms] [patch 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules
550 Invalid address in message header. Consult RFC2822.

... then a few more of those until June 28th:

Jun 28
(message) Bounce probe
550 Verification failed for <bounceprobe+1459038+8818881604274358745@groups.io>
Called: 45.79.81.153 
Sent: RCPT TO:<bounceprobe+1459038+8818881604274358745@groups.io> 
Response: 510 The group 'bounceprobe+1459038+8818881604274358745' does not exist. 
Sender verify failed

I get more of those on July 2nd, 6th, 9th, 13th, then finally this bounce:

Jul 16
[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 17 July 2019
550 Invalid address in message header. Consult RFC2822.

> 
> After rejecting that invalid mail, nothing else from the list was received.

I'll have to dig into this more to see what might be going on.

Let me know if anything jumps out here.

Cheers,
Stephano