From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=CWtjQguf;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by groups.io with SMTP; Tue, 16 Jul 2019 02:16:34 -0700
Received: by mail-wr1-f65.google.com with SMTP id x4so20058250wrt.6
        for <devel@edk2.groups.io>; Tue, 16 Jul 2019 02:16:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=bXyY+BwefjX1gkV7xJ7NHRtMgIWwKnOnXVnoqdRb8U4=;
        b=CWtjQgufgEHCh+B6zsyWsBJnw+nteLlnebiwIkzJQ4ElDrTViedtcWS3edpmAFvg+r
         tFxOESo7agbUWvXiH/dm8WBlbSV8nw8uv1deRekx3BHL2Mq1Sjujyzp/enOv9MTUiqeT
         Hz6fs4TxWCHxkxWue2NHkZdrPKrd6Awxl1kgmElY32faywQA3p5E3U/APPePYzAkA9z7
         GD/0TwgQWmWdcB6CRfMYhQTEf/HeDckndpVE0a9ENmsNMHdmQzLJnZ5/wG5k0zAiTpyh
         3LWJ9wHQUPpqamUMvLIEOSLtx8NA5PDuVJmQE1wW9IAddVOrCBG9EAOMQvFRebiNlcr8
         UWKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=bXyY+BwefjX1gkV7xJ7NHRtMgIWwKnOnXVnoqdRb8U4=;
        b=D/oUzJlsjL0Gj+ljh8W40i4XEye22gsW3o6uLOSZ3wkU2wY2ty9o4BGThu6vKIeNmr
         Kj166Q3K8u03xW2nx+Asxy3JjwmVRTt2Xo+ZwP6D61fwoxiEsqDnxELhQS5Jxn7EkHsD
         rAZmQ0w+bb4Z1vNsLnkfi2JOIEJ36mxI77Y9wzzn1B993RZegPb/cXrdoUuyJQcJRSUn
         p1vWqwHs2A0/IPVgcjc6ijoeyjJXn9lhevspHV/0GI5vUucxQwcjQiVodXVblKpkSl1U
         YVJa19ndVsd0moGnWUykpY6dgrhoqi0uMzdyxJ1z4krcRzVT8wEAX2/OLijTYVo4O3Jb
         rZtg==
X-Gm-Message-State: APjAAAWJAlGStpChQKgl74+nBmgUKnAfMowT2EVOQpVF5yD98XAQpfTE
	/RHOsY+ZGmceQHeslV2hCy0uvw==
X-Google-Smtp-Source: APXvYqxxyqTnNNPk+U0c0CQ37oLdIPNKIJJcBMCMFobFcCQsxzKI4vlCHc9cCOYWo7P2OFW4faim1w==
X-Received: by 2002:a5d:540e:: with SMTP id g14mr36655756wrv.346.1563268592405;
        Tue, 16 Jul 2019 02:16:32 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id f10sm12111152wrs.22.2019.07.16.02.16.31
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Tue, 16 Jul 2019 02:16:31 -0700 (PDT)
Date: Tue, 16 Jul 2019 10:16:30 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com,
	liming.gao@intel.com, michael.d.kinney@intel.com, afish@apple.com
Subject: Re: [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Message-ID: <20190716091629.ykcasr4nop3sv5se@bivouac.eciton.net>
References: <20190715222516.53254-1-rebecca@bsdio.com>
MIME-Version: 1.0
In-Reply-To: <20190715222516.53254-1-rebecca@bsdio.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

For 1-5/6:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Afraid I'm going to need to bikeshed over 6/6.

On Mon, Jul 15, 2019 at 04:25:11PM -0600, Rebecca Cran wrote:
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  edksetup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/edksetup.sh b/edksetup.sh
> index 12a3e26a67..ab58fe4a6e 100755
> --- a/edksetup.sh
> +++ b/edksetup.sh
> @@ -71,7 +71,7 @@ function SetWorkspace()
>    #
>    # Set $WORKSPACE
>    #
> -  export WORKSPACE=`pwd`
> +  export WORKSPACE=$PWD
>    return 0
>  }
>  
> -- 
> 2.22.0
>