From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com,
liming.gao@intel.com, michael.d.kinney@intel.com,
afish@apple.com
Subject: Re: [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Date: Tue, 16 Jul 2019 12:40:23 +0100 [thread overview]
Message-ID: <20190716114023.ycic2pcynbua6bdn@bivouac.eciton.net> (raw)
In-Reply-To: <20190716091629.ykcasr4nop3sv5se@bivouac.eciton.net>
On Tue, Jul 16, 2019 at 10:16:30AM +0100, Leif Lindholm wrote:
> For 1-5/6:
*cough*
Blatantly given my follow-up email, I meant 1-4,6/6.
/
Leif
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Afraid I'm going to need to bikeshed over 6/6.
>
> On Mon, Jul 15, 2019 at 04:25:11PM -0600, Rebecca Cran wrote:
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> > edksetup.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/edksetup.sh b/edksetup.sh
> > index 12a3e26a67..ab58fe4a6e 100755
> > --- a/edksetup.sh
> > +++ b/edksetup.sh
> > @@ -71,7 +71,7 @@ function SetWorkspace()
> > #
> > # Set $WORKSPACE
> > #
> > - export WORKSPACE=`pwd`
> > + export WORKSPACE=$PWD
> > return 0
> > }
> >
> > --
> > 2.22.0
> >
prev parent reply other threads:[~2019-07-16 11:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 22:25 [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command rebecca
2019-07-15 22:25 ` [PATCH 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
2019-07-16 1:39 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed rebecca
2019-07-16 1:40 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing rebecca
2019-07-16 1:40 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions rebecca
2019-07-16 2:16 ` Laszlo Ersek
2019-07-16 2:27 ` rebecca
2019-07-16 10:38 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements rebecca
2019-07-16 1:47 ` Laszlo Ersek
2019-07-16 1:53 ` Laszlo Ersek
2019-07-16 2:20 ` [edk2-devel] " rebecca
2019-07-16 10:34 ` Laszlo Ersek
2019-07-16 1:37 ` [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command Laszlo Ersek
2019-07-16 2:13 ` rebecca
2019-07-16 10:32 ` Laszlo Ersek
2019-07-16 10:36 ` Laszlo Ersek
2019-07-16 9:16 ` Leif Lindholm
2019-07-16 11:40 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716114023.ycic2pcynbua6bdn@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox