From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=qBnmFZez;
 spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Tue, 16 Jul 2019 04:40:27 -0700
Received: by mail-wr1-f67.google.com with SMTP id z1so20533035wru.13
        for <devel@edk2.groups.io>; Tue, 16 Jul 2019 04:40:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=OKp5PIN73vdPfppvUG6eC4uVrRGGc7YVVj5arNZBzLE=;
        b=qBnmFZez7YG30beFNaOMxmsxbpRRXmbmDudCeEIZaps6PGYnqwIqh/mt2WHHfkBzLA
         UZp44z8Z1S3RPrHpj+mfwBXVhtzWDsvwBXhdJ6jpLuc7aSU2oyzjdyMhJZUdsFGMNk6b
         8Pe4jyAFiYl1zqELC2mzODYIKqbFYLhJtyV4Ap3yMMANmAJtRUzSm0RnJvUFJ+FCWNSQ
         yEXy0/w7zSaQ3uVguoz4Ata7vjFg9OYi2pPStz4LHQL4KLR93mg0kpcJkUgB0rjDY/66
         3jh69vH6W2q6xz5cZiXaU4SjYZNABSFr0Ob8UN51sXi5s6YNxqC3LdCxDmJjM4xkdhZg
         DTKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=OKp5PIN73vdPfppvUG6eC4uVrRGGc7YVVj5arNZBzLE=;
        b=A0McBdVm+zb3FlX9KiJt1sxGbSl2Qoa9LBu5DEau1dJFwCi57xtgTLNIyk2sr001Vi
         mh5Tz7SQqNhKC5U10gfMhd4yuEamaSAVwkfiE0nNtVDlDHjZDivREdPqF/jrPbiHoWg0
         OZMumNjl6qXSNklAz9XESUmPQOLW8CPEEjejmtrYuoClw21kTylv1fPUkRBOOoO/96dO
         Fomy4fwMvIbCkmVwC4m5TEBqaRMXWyUPFqFDDGPZAunqL/GItP1oK2gZz1EiwSWpv/ms
         W6E28jYFWiDFg5kf2MQQY72DPgb5A0cUoVqtQ2ur9qSMXaBBj/RSPAxkO9Oniv++PA6l
         9yVA==
X-Gm-Message-State: APjAAAXM3BAo0Gn915GClJVa+fiPwghMpfbbsjFuoGQ094k/gZdvt2tx
	b4GexN7Ie9dW5eRVlW1hyYTYOg==
X-Google-Smtp-Source: APXvYqwKgBGGgf60PEFWJ+Z4tp8+LwEHaqir/0mA/f+AZH72BgpCTrgdLOCgP76mKk+PUgWtMMLoOg==
X-Received: by 2002:adf:ff84:: with SMTP id j4mr34140482wrr.71.1563277226083;
        Tue, 16 Jul 2019 04:40:26 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id h8sm19648212wmf.12.2019.07.16.04.40.25
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Tue, 16 Jul 2019 04:40:25 -0700 (PDT)
Date: Tue, 16 Jul 2019 12:40:23 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com,
	liming.gao@intel.com, michael.d.kinney@intel.com, afish@apple.com
Subject: Re: [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Message-ID: <20190716114023.ycic2pcynbua6bdn@bivouac.eciton.net>
References: <20190715222516.53254-1-rebecca@bsdio.com>
 <20190716091629.ykcasr4nop3sv5se@bivouac.eciton.net>
MIME-Version: 1.0
In-Reply-To: <20190716091629.ykcasr4nop3sv5se@bivouac.eciton.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 16, 2019 at 10:16:30AM +0100, Leif Lindholm wrote:
> For 1-5/6:

*cough*
Blatantly given my follow-up email, I meant 1-4,6/6.

/
    Leif

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Afraid I'm going to need to bikeshed over 6/6.
> 
> On Mon, Jul 15, 2019 at 04:25:11PM -0600, Rebecca Cran wrote:
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> >  edksetup.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/edksetup.sh b/edksetup.sh
> > index 12a3e26a67..ab58fe4a6e 100755
> > --- a/edksetup.sh
> > +++ b/edksetup.sh
> > @@ -71,7 +71,7 @@ function SetWorkspace()
> >    #
> >    # Set $WORKSPACE
> >    #
> > -  export WORKSPACE=`pwd`
> > +  export WORKSPACE=$PWD
> >    return 0
> >  }
> >  
> > -- 
> > 2.22.0
> >