* [RFC] Fine-grained review ownership for MdeModulePkg
@ 2019-06-10 8:06 Wu, Hao A
2019-06-11 9:51 ` Leif Lindholm
2019-06-20 22:23 ` rebecca
0 siblings, 2 replies; 13+ messages in thread
From: Wu, Hao A @ 2019-06-10 8:06 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: lersek@redhat.com, Leif Lindholm, Kinney, Michael D, Andrew Fish,
Justen, Jordan L, Ard Biesheuvel, Gao, Liming, Yao, Jiewen,
Zeng, Star
Hello all,
Driven by the issue raised and discussions with thread:
https://edk2.groups.io/g/devel/topic/31907735#42076
This RFC proposal is raised to work out a fine-grained review ownership
for MdeModulePkg.
The goal is to update the 'MdeModulePkg' section in file Maintainers.txt
to resemble the format like the 'OvmfPkg' section. Several reviewers will
be listed to take the ownership to review patches for a specific feature
in the package.
In order to get the list of reviewers, a 2-step process will be adopted:
1. Work out a list that contains major features in MdeModulePkg.
2. Call for owners for every item in the list.
For 1, a coarse feature list is:
Acpi
Bds
Capsule
Compress
Console
Core (PeiCore, DxeCore, PiSmmCore, etc. Mainly content in MdeModulePkg/Core/ folder)
Device (peripheral & storage)
Disk
EBC
HII
MemoryManagement (include memory test, memory allocation, memory profile, etc.)
PCD
PCI bus
Reset
S3 (including LockBox)
SMBIOS
SMM
Status Code
UI
Variable
Misc (all the components that do not fit in the above items)
Once we think the granularity of the above list is fine and there is no
significant feature missing, I will update such list to include the
modules that belong to a specific feature. So adjustments can be done to
work out the final feature list.
The proposal here is far from mature, so any feedback/suggestion will be
appreciated.
Best Regards,
Hao Wu
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-10 8:06 [RFC] Fine-grained review ownership for MdeModulePkg Wu, Hao A
@ 2019-06-11 9:51 ` Leif Lindholm
2019-06-11 15:41 ` Laszlo Ersek
2019-06-19 5:09 ` Wu, Hao A
2019-06-20 22:23 ` rebecca
1 sibling, 2 replies; 13+ messages in thread
From: Leif Lindholm @ 2019-06-11 9:51 UTC (permalink / raw)
To: Wu, Hao A
Cc: devel@edk2.groups.io, lersek@redhat.com, Kinney, Michael D,
Andrew Fish, Justen, Jordan L, Ard Biesheuvel, Gao, Liming,
Yao, Jiewen, Zeng, Star
Hi Wu Hao,
I am working on a proposal (and proof-of-concept) machine readable
Maintainers.txt format, and a GetMaintainer.py script, based on the
format used by QEMU.
One of the key features of that format is the F: tag, which specifes a
filesytem path (with wildcard support).
While this is just an RFC in progress (to be sent out later in week),
if you could take that into account, and figure out which paths
correspond to which areas of responsibility, that would make a test
run of the script much easier.
For my part, I would suggest adding (not just for MdeModulePkg)
F: */ARM/*
F: */AARCH64/*
as maintained by myself and Ard.
Best Regards,
Leif
On Mon, Jun 10, 2019 at 08:06:23AM +0000, Wu, Hao A wrote:
> Hello all,
>
> Driven by the issue raised and discussions with thread:
> https://edk2.groups.io/g/devel/topic/31907735#42076
>
> This RFC proposal is raised to work out a fine-grained review ownership
> for MdeModulePkg.
>
> The goal is to update the 'MdeModulePkg' section in file Maintainers.txt
> to resemble the format like the 'OvmfPkg' section. Several reviewers will
> be listed to take the ownership to review patches for a specific feature
> in the package.
>
> In order to get the list of reviewers, a 2-step process will be adopted:
> 1. Work out a list that contains major features in MdeModulePkg.
> 2. Call for owners for every item in the list.
>
> For 1, a coarse feature list is:
> Acpi
> Bds
> Capsule
> Compress
> Console
> Core (PeiCore, DxeCore, PiSmmCore, etc. Mainly content in MdeModulePkg/Core/ folder)
> Device (peripheral & storage)
> Disk
> EBC
> HII
> MemoryManagement (include memory test, memory allocation, memory profile, etc.)
> PCD
> PCI bus
> Reset
> S3 (including LockBox)
> SMBIOS
> SMM
> Status Code
> UI
> Variable
> Misc (all the components that do not fit in the above items)
>
> Once we think the granularity of the above list is fine and there is no
> significant feature missing, I will update such list to include the
> modules that belong to a specific feature. So adjustments can be done to
> work out the final feature list.
>
> The proposal here is far from mature, so any feedback/suggestion will be
> appreciated.
>
>
> Best Regards,
> Hao Wu
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-11 9:51 ` Leif Lindholm
@ 2019-06-11 15:41 ` Laszlo Ersek
2019-06-19 5:09 ` Wu, Hao A
1 sibling, 0 replies; 13+ messages in thread
From: Laszlo Ersek @ 2019-06-11 15:41 UTC (permalink / raw)
To: Leif Lindholm, Wu, Hao A
Cc: devel@edk2.groups.io, Kinney, Michael D, Andrew Fish,
Justen, Jordan L, Ard Biesheuvel, Gao, Liming, Yao, Jiewen,
Zeng, Star
On 06/11/19 11:51, Leif Lindholm wrote:
> Hi Wu Hao,
>
> I am working on a proposal (and proof-of-concept) machine readable
> Maintainers.txt format, and a GetMaintainer.py script, based on the
> format used by QEMU.
>
> One of the key features of that format is the F: tag, which specifes a
> filesytem path (with wildcard support).
This is great news! QEMU's pathnames are very flexible.
>
> While this is just an RFC in progress (to be sent out later in week),
> if you could take that into account, and figure out which paths
> correspond to which areas of responsibility, that would make a test
> run of the script much easier.
>
> For my part, I would suggest adding (not just for MdeModulePkg)
> F: */ARM/*
> F: */AARCH64/*
> as maintained by myself and Ard.
* Under ArmVirtPkg, we distinguish "Xen modules":
R: Julien Grall <julien.grall@arm.com>
(Xen modules)
I hope that Ard can come up with a set of patterns for these modules. :)
* Under OvmfPkg, we distinguish:
R: Anthony Perard <anthony.perard@citrix.com>
(Xen modules)
R: Julien Grall <julien.grall@arm.com>
(Xen modules)
and
R: Marc-André Lureau <marcandre.lureau@redhat.com>
(TPM2 modules)
R: Stefan Berger <stefanb@linux.ibm.com>
(TPM2 modules)
For "Xen modules", I'd suggest:
F: OvmfPkg/AcpiPlatformDxe/Xen.c
F: OvmfPkg/Include/Guid/Xen*.h
F: OvmfPkg/Include/IndustryStandard/Xen/
F: OvmfPkg/Include/Library/Xen*.h
F: OvmfPkg/Include/Protocol/Xen*.h
F: OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
F: OvmfPkg/Library/XenConsoleSerialPortLib/
F: OvmfPkg/Library/XenHypercallLib/
F: OvmfPkg/Library/XenIoMmioLib
F: OvmfPkg/PlatformPei/Xen.*
F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
F: OvmfPkg/XenBusDxe/
F: OvmfPkg/XenIoPciDxe/
F: OvmfPkg/XenPvBlkDxe/
For "TPM2 modules":
F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
F: OvmfPkg/Tcg/
Thanks
Laszlo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-11 9:51 ` Leif Lindholm
2019-06-11 15:41 ` Laszlo Ersek
@ 2019-06-19 5:09 ` Wu, Hao A
2019-06-19 9:35 ` Leif Lindholm
1 sibling, 1 reply; 13+ messages in thread
From: Wu, Hao A @ 2019-06-19 5:09 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: Leif Lindholm, lersek@redhat.com, Kinney, Michael D, Andrew Fish,
Justen, Jordan L, Ard Biesheuvel, Gao, Liming, Yao, Jiewen,
Zeng, Star
Hello all,
As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are
classified to a list of features.
Please note that:
* The below list is a draft at this moment, please help to provide
feedbacks/comments;
* Modules with no clear classification are listed under the 'Misc' section
at the bottom of the list.
ACPI:
MdeModulePkg/Include/*/*Acpi*.h
MdeModulePkg/Universal/Acpi/
BDS:
MdeModulePkg/Include/Library/PlatformBootManagerLib.h
MdeModulePkg/Include/Library/UefiBootManagerLib.h
MdeModulePkg/Library/PlatformBootManagerLibNull/
MdeModulePkg/Library/UefiBootManagerLib/
MdeModulePkg/Universal/BdsDxe/
MdeModulePkg/Universal/BootManagerPolicyDxe/
MdeModulePkg/Universal/LoadFileOnFv2/
MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
Console:
MdeModulePkg/Include/Guid/ConnectConInEvent.h
MdeModulePkg/Include/Guid/ConsoleInDevice.h
MdeModulePkg/Include/Guid/ConsoleOutDevice.h
MdeModulePkg/Include/Guid/StandardErrorDevice.h
MdeModulePkg/Include/Guid/TtyTerm.h
MdeModulePkg/Universal/Console/ConPlatformDxe/
MdeModulePkg/Universal/Console/ConSplitterDxe/
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/
MdeModulePkg/Universal/Console/TerminalDxe/
Core (PEI, DXE and Runtime):
MdeModulePkg/Core/Dxe/*
MdeModulePkg/Core/Dxe/Dispatcher/
MdeModulePkg/Core/Dxe/DxeMain/
MdeModulePkg/Core/Dxe/Event/
MdeModulePkg/Core/Dxe/FwVol*/
MdeModulePkg/Core/Dxe/Hand/
MdeModulePkg/Core/Dxe/Image/
MdeModulePkg/Core/Dxe/Library/
MdeModulePkg/Core/Dxe/Misc/
MdeModulePkg/Core/Dxe/SectionExtraction/
MdeModulePkg/Core/DxeIplPeim/
MdeModulePkg/Core/Pei/*
MdeModulePkg/Core/Pei/BootMode/
MdeModulePkg/Core/Pei/CpuIo/
MdeModulePkg/Core/Pei/Dependency/
MdeModulePkg/Core/Pei/Dispatcher/
MdeModulePkg/Core/Pei/FwVol/
MdeModulePkg/Core/Pei/Hob/
MdeModulePkg/Core/Pei/Image/
MdeModulePkg/Core/Pei/PeiMain/
MdeModulePkg/Core/Pei/Ppi/
MdeModulePkg/Core/Pei/Security/
MdeModulePkg/Core/RuntimeDxe/
MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
MdeModulePkg/Include/Guid/IdleLoopEvent.h
MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
MdeModulePkg/Include/Library/SecurityManagementLib.h
MdeModulePkg/Library/*SectionExtract*/
MdeModulePkg/Library/DxeSecurityManagementLib/
MdeModulePkg/Universal/PlatformDriOverrideDxe/
MdeModulePkg/Universal/SectionExtraction*/
MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
Debug:
MdeModulePkg/Include/Guid/DebugMask.h
MdeModulePkg/Include/Library/DebugAgentLib.h
MdeModulePkg/Include/Ppi/Debug.h
MdeModulePkg/Library/*Debug*/
MdeModulePkg/Universal/Debug*/
Decompress:
MdeModulePkg/Include/Guid/LzmaDecompress.h
MdeModulePkg/Library/*Decompress*/
Device:
MdeModulePkg/Bus/Ata/
MdeModulePkg/Bus/I2c/
MdeModulePkg/Bus/Isa/
MdeModulePkg/Bus/Pci/Ehci*/
MdeModulePkg/Bus/Pci/IdeBusPei/
MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/
MdeModulePkg/Bus/Pci/NvmExpress*/
MdeModulePkg/Bus/Pci/PciSioSerialDxe/
MdeModulePkg/Bus/Pci/SataControllerDxe/
MdeModulePkg/Bus/Pci/SdMmc*/
MdeModulePkg/Bus/Pci/Ufs*/
MdeModulePkg/Bus/Pci/Uhci*/
MdeModulePkg/Bus/Pci/Xhci*/
MdeModulePkg/Bus/Scsi/
MdeModulePkg/Bus/Sd/
MdeModulePkg/Bus/Ufs/
MdeModulePkg/Bus/Usb/
MdeModulePkg/Include/*/*Ata*.h
MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
MdeModulePkg/Include/*/*NvmExpress*.h
MdeModulePkg/Include/*/*SerialPort*.h
MdeModulePkg/Include/*/*SdMmc*.h
MdeModulePkg/Include/*/*Ufs*.h
MdeModulePkg/Include/*/*Usb*.h
MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
MdeModulePkg/Include/Guid/RecoveryDevice.h
MdeModulePkg/Include/Guid/UsbKeyBoardLayout.h
MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
MdeModulePkg/Include/Protocol/Ps2Policy.h
MdeModulePkg/Library/BaseSerialPortLib16550/
MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
MdeModulePkg/Universal/SerialDxe/
Disk:
MdeModulePkg/Universal/Disk/
EBC:
MdeModulePkg/Include/*/*Ebc*.h
MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
MdeModulePkg/Universal/EbcDxe/
Firmware Update:
MdeModulePkg/Application/CapsuleApp/
MdeModulePkg/Include/*/*Capsule*.h
MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
MdeModulePkg/Include/Library/FmpAuthenticationLib.h
MdeModulePkg/Include/Protocol/EsrtManagement.h
MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
MdeModulePkg/Library/DisplayUpdateProgressLib*/
MdeModulePkg/Library/DxeCapsuleLib*/
MdeModulePkg/Library/FmpAuthenticationLibNull/
MdeModulePkg/Universal/Capsule*/
MdeModulePkg/Universal/Esrt*/
Graphic:
MdeModulePkg/Include/*/*Logo*.h
MdeModulePkg/Include/Library/BmpSupportLib.h
MdeModulePkg/Include/Library/FrameBufferBltLib.h
MdeModulePkg/Library/BaseBmpSupportLib/
MdeModulePkg/Library/BootLogoLib/
MdeModulePkg/Library/FrameBufferBltLib/
MdeModulePkg/Logo/
MdeModulePkg/Universal/Console/GraphicsOutputDxe/
HII/UI:
MdeModulePkg/Application/BootManagerMenuApp/
MdeModulePkg/Application/UiApp/
MdeModulePkg/Include/*/*FileExplorer*.h
MdeModulePkg/Include/*/*FormBrowser*.h
MdeModulePkg/Include/*/*Hii*.h
MdeModulePkg/Include/Library/CustomizedDisplayLib.h
MdeModulePkg/Include/Protocol/DisplayProtocol.h
MdeModulePkg/Library/*FileExplorer*/
MdeModulePkg/Library/*Hii*/
MdeModulePkg/Library/*UiLib/
MdeModulePkg/Library/CustomizedDisplayLib/
MdeModulePkg/Universal/DisplayEngineDxe/
MdeModulePkg/Universal/FileExplorerDxe/
MdeModulePkg/Universal/Hii*/
MdeModulePkg/Universal/SetupBrowserDxe/
IPMI:
MdeModulePkg/Include/*/*Ipmi*.h
MdeModulePkg/Library/*Ipmi*/
Memory Management:
MdeModulePkg/Application/MemoryProfileInfo/
MdeModulePkg/Core/Dxe/Gcd/
MdeModulePkg/Core/Dxe/Mem/
MdeModulePkg/Core/Pei/Memory/
MdeModulePkg/Include/*/*Mem*.h
MdeModulePkg/Include/*/*IoMmu*.h
MdeModulePkg/Library/*MemoryAllocation*/
MdeModulePkg/Universal/MemoryTest/
PCD:
MdeModulePkg/Application/DumpDynPcd/
MdeModulePkg/Include/*/*Pcd*.h
MdeModulePkg/Universal/PCD/
PCI Bus:
MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
MdeModulePkg/Bus/Pci/PciBusDxe/
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
MdeModulePkg/Core/Pei/PciCfg2/
MdeModulePkg/Include/Library/PciHostBridgeLib.h
MdeModulePkg/Library/PciHostBridgeLibNull/
MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
Performance:
MdeModulePkg/Include/*/*Perf*.h
MdeModulePkg/Library/*Perf*/
Reset:
MdeModulePkg/Core/Pei/Reset/
MdeModulePkg/Include/*/*Reset*.h
MdeModulePkg/Library/*Reset*/
MdeModulePkg/Universal/ResetSystem*/
S3:
MdeModulePkg/Include/*/*BootScript*.h
MdeModulePkg/Include/*/*LockBox*.h
MdeModulePkg/Include/*/*S3*.h
MdeModulePkg/Library/*LockBox*/
MdeModulePkg/Library/*S3*/
MdeModulePkg/Universal/LockBox/
SMBIOS:
MdeModulePkg/Universal/Smbios*/
SMM:
MdeModulePkg/Application/SmiHandlerProfileInfo/
MdeModulePkg/Core/PiSmmCore/
MdeModulePkg/Include/*/*Smi*.h
MdeModulePkg/Include/*/*Smm*.h
MdeModulePkg/Library/*Smi*/
MdeModulePkg/Library/*Smm*/
MdeModulePkg/Universal/SmmCommunicationBufferDxe/
Status Code:
MdeModulePkg/Core/Pei/StatusCode/
MdeModulePkg/Include/*/*StatusCode*.h
MdeModulePkg/Library/*StatusCode*/
MdeModulePkg/Universal/*StatusCode*/
Variable:
MdeModulePkg/Application/VariableInfo/
MdeModulePkg/Include/*/*FaultTolerantWrite*.h
MdeModulePkg/Include/*/*Var*.h
MdeModulePkg/Include/Guid/SystemNvDataGuid.h
MdeModulePkg/Include/Protocol/SwapAddressRange.h
MdeModulePkg/Library/*Var*/
MdeModulePkg/Universal/FaultTolerantWrite*/
MdeModulePkg/Universal/Variable/
Misc:
MdeModulePkg/Application/HelloWorld/
MdeModulePkg/Include/Guid/MdeModulePkgTokenSpace.h
MdeModulePkg/Include/Guid/MtcVendor.h
MdeModulePkg/Include/Guid/ZeroGuid.h
MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
MdeModulePkg/Include/Library/PlatformHookLib.h
MdeModulePkg/Include/Library/RecoveryLib.h
MdeModulePkg/Include/Library/SortLib.h
MdeModulePkg/Include/Library/TpmMeasurementLib.h
MdeModulePkg/Include/Protocol/Dpc.h
MdeModulePkg/Include/Protocol/LoadPe32Image.h
MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
MdeModulePkg/Include/Protocol/Print2.h
MdeModulePkg/Library/BaseHobLibNull/
MdeModulePkg/Library/BasePlatformHookLibNull/
MdeModulePkg/Library/BaseSortLib/
MdeModulePkg/Library/CpuExceptionHandlerLibNull/
MdeModulePkg/Library/DxePrintLibPrint2Protocol/
MdeModulePkg/Library/PeiRecoveryLibNull/
MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
MdeModulePkg/Library/TpmMeasurementLibNull/
MdeModulePkg/Library/UefiSortLib/
MdeModulePkg/Universal/DevicePathDxe/
MdeModulePkg/Universal/DriverHealthManagerDxe/
MdeModulePkg/Universal/DriverSampleDxe/
MdeModulePkg/Universal/FvSimpleFileSystemDxe/
MdeModulePkg/Universal/LegacyRegion2Dxe/
MdeModulePkg/Universal/Metronome/
MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
MdeModulePkg/Universal/PrintDxe/
MdeModulePkg/Universal/RegularExpressionDxe/
MdeModulePkg/Universal/TimestampDxe/
MdeModulePkg/Universal/WatchdogTimerDxe/
Best Regards,
Hao Wu
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, June 11, 2019 5:52 PM
> To: Wu, Hao A
> Cc: devel@edk2.groups.io; lersek@redhat.com; Kinney, Michael D; Andrew
> Fish; Justen, Jordan L; Ard Biesheuvel; Gao, Liming; Yao, Jiewen; Zeng, Star
> Subject: Re: [RFC] Fine-grained review ownership for MdeModulePkg
>
> Hi Wu Hao,
>
> I am working on a proposal (and proof-of-concept) machine readable
> Maintainers.txt format, and a GetMaintainer.py script, based on the
> format used by QEMU.
>
> One of the key features of that format is the F: tag, which specifes a
> filesytem path (with wildcard support).
>
> While this is just an RFC in progress (to be sent out later in week),
> if you could take that into account, and figure out which paths
> correspond to which areas of responsibility, that would make a test
> run of the script much easier.
>
> For my part, I would suggest adding (not just for MdeModulePkg)
> F: */ARM/*
> F: */AARCH64/*
> as maintained by myself and Ard.
>
> Best Regards,
>
> Leif
>
> On Mon, Jun 10, 2019 at 08:06:23AM +0000, Wu, Hao A wrote:
> > Hello all,
> >
> > Driven by the issue raised and discussions with thread:
> > https://edk2.groups.io/g/devel/topic/31907735#42076
> >
> > This RFC proposal is raised to work out a fine-grained review ownership
> > for MdeModulePkg.
> >
> > The goal is to update the 'MdeModulePkg' section in file Maintainers.txt
> > to resemble the format like the 'OvmfPkg' section. Several reviewers will
> > be listed to take the ownership to review patches for a specific feature
> > in the package.
> >
> > In order to get the list of reviewers, a 2-step process will be adopted:
> > 1. Work out a list that contains major features in MdeModulePkg.
> > 2. Call for owners for every item in the list.
> >
> > For 1, a coarse feature list is:
> > Acpi
> > Bds
> > Capsule
> > Compress
> > Console
> > Core (PeiCore, DxeCore, PiSmmCore, etc. Mainly content in
> MdeModulePkg/Core/ folder)
> > Device (peripheral & storage)
> > Disk
> > EBC
> > HII
> > MemoryManagement (include memory test, memory allocation, memory
> profile, etc.)
> > PCD
> > PCI bus
> > Reset
> > S3 (including LockBox)
> > SMBIOS
> > SMM
> > Status Code
> > UI
> > Variable
> > Misc (all the components that do not fit in the above items)
> >
> > Once we think the granularity of the above list is fine and there is no
> > significant feature missing, I will update such list to include the
> > modules that belong to a specific feature. So adjustments can be done to
> > work out the final feature list.
> >
> > The proposal here is far from mature, so any feedback/suggestion will be
> > appreciated.
> >
> >
> > Best Regards,
> > Hao Wu
> >
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-19 5:09 ` Wu, Hao A
@ 2019-06-19 9:35 ` Leif Lindholm
2019-06-20 15:43 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 13+ messages in thread
From: Leif Lindholm @ 2019-06-19 9:35 UTC (permalink / raw)
To: Wu, Hao A
Cc: devel@edk2.groups.io, lersek@redhat.com, Kinney, Michael D,
Andrew Fish, Justen, Jordan L, Ard Biesheuvel, Gao, Liming,
Yao, Jiewen, Zeng, Star
On Wed, Jun 19, 2019 at 05:09:40AM +0000, Wu, Hao A wrote:
> Hello all,
>
> As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are
> classified to a list of features.
>
> Please note that:
> * The below list is a draft at this moment, please help to provide
> feedbacks/comments;
> * Modules with no clear classification are listed under the 'Misc' section
> at the bottom of the list.
Thank you for doing the heavy lifting.
A few comments below on how this could be more easily described in the
Maintainer.txt syntax.
> ACPI:
> MdeModulePkg/Include/*/*Acpi*.h
> MdeModulePkg/Universal/Acpi/
>
> BDS:
> MdeModulePkg/Include/Library/PlatformBootManagerLib.h
> MdeModulePkg/Include/Library/UefiBootManagerLib.h
> MdeModulePkg/Library/PlatformBootManagerLibNull/
> MdeModulePkg/Library/UefiBootManagerLib/
MdeModulePkg/*BootManagerLib*/
> MdeModulePkg/Universal/BdsDxe/
> MdeModulePkg/Universal/BootManagerPolicyDxe/
Or maybe even
MdeModulePkg/*BootManager*/, which would also match the line above.
> MdeModulePkg/Universal/LoadFileOnFv2/
> MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
>
> Console:
> MdeModulePkg/Include/Guid/ConnectConInEvent.h
> MdeModulePkg/Include/Guid/ConsoleInDevice.h
> MdeModulePkg/Include/Guid/ConsoleOutDevice.h
> MdeModulePkg/Include/Guid/StandardErrorDevice.h
> MdeModulePkg/Include/Guid/TtyTerm.h
> MdeModulePkg/Universal/Console/ConPlatformDxe/
> MdeModulePkg/Universal/Console/ConSplitterDxe/
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/
> MdeModulePkg/Universal/Console/TerminalDxe/
I was intrigued as to why this did not specify
MdeModulePkg/Universal/Console/
See [1] below.
However, even if suggestions included below were not implemented, the
situation could be described as:
F: MdeModulePkg/Universal/Console/
X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> Core (PEI, DXE and Runtime):
> MdeModulePkg/Core/Dxe/*
> MdeModulePkg/Core/Dxe/Dispatcher/
> MdeModulePkg/Core/Dxe/DxeMain/
> MdeModulePkg/Core/Dxe/Event/
> MdeModulePkg/Core/Dxe/FwVol*/
> MdeModulePkg/Core/Dxe/Hand/
> MdeModulePkg/Core/Dxe/Image/
> MdeModulePkg/Core/Dxe/Library/
> MdeModulePkg/Core/Dxe/Misc/
> MdeModulePkg/Core/Dxe/SectionExtraction/
F: MdeModulePkg/Core/Dxe/
X: MdeModulePkg/Core/Dxe/Mem/
> MdeModulePkg/Core/DxeIplPeim/
> MdeModulePkg/Core/Pei/*
> MdeModulePkg/Core/Pei/BootMode/
> MdeModulePkg/Core/Pei/CpuIo/
> MdeModulePkg/Core/Pei/Dependency/
> MdeModulePkg/Core/Pei/Dispatcher/
> MdeModulePkg/Core/Pei/FwVol/
> MdeModulePkg/Core/Pei/Hob/
> MdeModulePkg/Core/Pei/Image/
> MdeModulePkg/Core/Pei/PeiMain/
> MdeModulePkg/Core/Pei/Ppi/
> MdeModulePkg/Core/Pei/Security/
F: MdeModulePkg/Core/Pei/
X: MdeModulePkg/Core/Pei/Memory/
X: MdeModulePkg/Core/Pei/PciCfg2/
X: MdeModulePkg/Core/Pei/Reset/
X: MdeModulePkg/Core/Pei/StatusCode/
I'm going to stop there, because I'm lazy, and I realise this is about
the responsibility areas rather than an actual patch to
Maintainers.txt - and I think my point is made.
Further comments below.
> MdeModulePkg/Core/RuntimeDxe/
> MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> MdeModulePkg/Include/Guid/IdleLoopEvent.h
> MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> MdeModulePkg/Include/Library/SecurityManagementLib.h
> MdeModulePkg/Library/*SectionExtract*/
> MdeModulePkg/Library/DxeSecurityManagementLib/
> MdeModulePkg/Universal/PlatformDriOverrideDxe/
> MdeModulePkg/Universal/SectionExtraction*/
> MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
>
> Debug:
> MdeModulePkg/Include/Guid/DebugMask.h
> MdeModulePkg/Include/Library/DebugAgentLib.h
> MdeModulePkg/Include/Ppi/Debug.h
> MdeModulePkg/Library/*Debug*/
> MdeModulePkg/Universal/Debug*/
>
> Decompress:
> MdeModulePkg/Include/Guid/LzmaDecompress.h
> MdeModulePkg/Library/*Decompress*/
>
> Device:
> MdeModulePkg/Bus/Ata/
> MdeModulePkg/Bus/I2c/
> MdeModulePkg/Bus/Isa/
> MdeModulePkg/Bus/Pci/Ehci*/
> MdeModulePkg/Bus/Pci/IdeBusPei/
> MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/
> MdeModulePkg/Bus/Pci/NvmExpress*/
> MdeModulePkg/Bus/Pci/PciSioSerialDxe/
> MdeModulePkg/Bus/Pci/SataControllerDxe/
> MdeModulePkg/Bus/Pci/SdMmc*/
> MdeModulePkg/Bus/Pci/Ufs*/
> MdeModulePkg/Bus/Pci/Uhci*/
> MdeModulePkg/Bus/Pci/Xhci*/
> MdeModulePkg/Bus/Scsi/
> MdeModulePkg/Bus/Sd/
> MdeModulePkg/Bus/Ufs/
> MdeModulePkg/Bus/Usb/
> MdeModulePkg/Include/*/*Ata*.h
> MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> MdeModulePkg/Include/*/*NvmExpress*.h
> MdeModulePkg/Include/*/*SerialPort*.h
> MdeModulePkg/Include/*/*SdMmc*.h
> MdeModulePkg/Include/*/*Ufs*.h
> MdeModulePkg/Include/*/*Usb*.h
> MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> MdeModulePkg/Include/Guid/RecoveryDevice.h
> MdeModulePkg/Include/Guid/UsbKeyBoardLayout.h
> MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> MdeModulePkg/Include/Protocol/Ps2Policy.h
> MdeModulePkg/Library/BaseSerialPortLib16550/
> MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
> MdeModulePkg/Universal/SerialDxe/
>
> Disk:
> MdeModulePkg/Universal/Disk/
>
> EBC:
> MdeModulePkg/Include/*/*Ebc*.h
> MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> MdeModulePkg/Universal/EbcDxe/
>
> Firmware Update:
> MdeModulePkg/Application/CapsuleApp/
> MdeModulePkg/Include/*/*Capsule*.h
> MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> MdeModulePkg/Include/Protocol/EsrtManagement.h
> MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> MdeModulePkg/Library/DisplayUpdateProgressLib*/
> MdeModulePkg/Library/DxeCapsuleLib*/
> MdeModulePkg/Library/FmpAuthenticationLibNull/
> MdeModulePkg/Universal/Capsule*/
> MdeModulePkg/Universal/Esrt*/
>
> Graphic:
> MdeModulePkg/Include/*/*Logo*.h
> MdeModulePkg/Include/Library/BmpSupportLib.h
> MdeModulePkg/Include/Library/FrameBufferBltLib.h
> MdeModulePkg/Library/BaseBmpSupportLib/
> MdeModulePkg/Library/BootLogoLib/
> MdeModulePkg/Library/FrameBufferBltLib/
> MdeModulePkg/Logo/
> MdeModulePkg/Universal/Console/GraphicsOutputDxe/
[1] I would say this suggests GraphicsOutputDxe could be moved to,
say, MdeModulePkg/Universal/Graphics - and Logo be moved there
too.
>
> HII/UI:
> MdeModulePkg/Application/BootManagerMenuApp/
> MdeModulePkg/Application/UiApp/
> MdeModulePkg/Include/*/*FileExplorer*.h
> MdeModulePkg/Include/*/*FormBrowser*.h
> MdeModulePkg/Include/*/*Hii*.h
> MdeModulePkg/Include/Library/CustomizedDisplayLib.h
> MdeModulePkg/Include/Protocol/DisplayProtocol.h
> MdeModulePkg/Library/*FileExplorer*/
> MdeModulePkg/Library/*Hii*/
> MdeModulePkg/Library/*UiLib/
> MdeModulePkg/Library/CustomizedDisplayLib/
> MdeModulePkg/Universal/DisplayEngineDxe/
> MdeModulePkg/Universal/FileExplorerDxe/
> MdeModulePkg/Universal/Hii*/
> MdeModulePkg/Universal/SetupBrowserDxe/
>
> IPMI:
> MdeModulePkg/Include/*/*Ipmi*.h
> MdeModulePkg/Library/*Ipmi*/
>
> Memory Management:
> MdeModulePkg/Application/MemoryProfileInfo/
> MdeModulePkg/Core/Dxe/Gcd/
> MdeModulePkg/Core/Dxe/Mem/
> MdeModulePkg/Core/Pei/Memory/
> MdeModulePkg/Include/*/*Mem*.h
> MdeModulePkg/Include/*/*IoMmu*.h
> MdeModulePkg/Library/*MemoryAllocation*/
> MdeModulePkg/Universal/MemoryTest/
>
> PCD:
> MdeModulePkg/Application/DumpDynPcd/
> MdeModulePkg/Include/*/*Pcd*.h
> MdeModulePkg/Universal/PCD/
>
> PCI Bus:
> MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> MdeModulePkg/Bus/Pci/PciBusDxe/
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> MdeModulePkg/Core/Pei/PciCfg2/
> MdeModulePkg/Include/Library/PciHostBridgeLib.h
> MdeModulePkg/Library/PciHostBridgeLibNull/
> MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
>
> Performance:
> MdeModulePkg/Include/*/*Perf*.h
> MdeModulePkg/Library/*Perf*/
>
> Reset:
> MdeModulePkg/Core/Pei/Reset/
> MdeModulePkg/Include/*/*Reset*.h
> MdeModulePkg/Library/*Reset*/
> MdeModulePkg/Universal/ResetSystem*/
>
> S3:
> MdeModulePkg/Include/*/*BootScript*.h
> MdeModulePkg/Include/*/*LockBox*.h
> MdeModulePkg/Include/*/*S3*.h
> MdeModulePkg/Library/*LockBox*/
> MdeModulePkg/Library/*S3*/
> MdeModulePkg/Universal/LockBox/
>
> SMBIOS:
> MdeModulePkg/Universal/Smbios*/
>
> SMM:
> MdeModulePkg/Application/SmiHandlerProfileInfo/
> MdeModulePkg/Core/PiSmmCore/
> MdeModulePkg/Include/*/*Smi*.h
> MdeModulePkg/Include/*/*Smm*.h
> MdeModulePkg/Library/*Smi*/
> MdeModulePkg/Library/*Smm*/
> MdeModulePkg/Universal/SmmCommunicationBufferDxe/
>
> Status Code:
> MdeModulePkg/Core/Pei/StatusCode/
> MdeModulePkg/Include/*/*StatusCode*.h
> MdeModulePkg/Library/*StatusCode*/
> MdeModulePkg/Universal/*StatusCode*/
>
> Variable:
> MdeModulePkg/Application/VariableInfo/
> MdeModulePkg/Include/*/*FaultTolerantWrite*.h
> MdeModulePkg/Include/*/*Var*.h
> MdeModulePkg/Include/Guid/SystemNvDataGuid.h
> MdeModulePkg/Include/Protocol/SwapAddressRange.h
> MdeModulePkg/Library/*Var*/
> MdeModulePkg/Universal/FaultTolerantWrite*/
> MdeModulePkg/Universal/Variable/
>
> Misc:
I have no issue with the below, but just wanted to point out that if
there was an overarching MdeModulePkg/
section, these would automatically match against that anyway - we
don't need to explicitly tag everything.
> MdeModulePkg/Application/HelloWorld/
> MdeModulePkg/Include/Guid/MdeModulePkgTokenSpace.h
> MdeModulePkg/Include/Guid/MtcVendor.h
> MdeModulePkg/Include/Guid/ZeroGuid.h
> MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
> MdeModulePkg/Include/Library/PlatformHookLib.h
> MdeModulePkg/Include/Library/RecoveryLib.h
> MdeModulePkg/Include/Library/SortLib.h
> MdeModulePkg/Include/Library/TpmMeasurementLib.h
> MdeModulePkg/Include/Protocol/Dpc.h
> MdeModulePkg/Include/Protocol/LoadPe32Image.h
> MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
> MdeModulePkg/Include/Protocol/Print2.h
> MdeModulePkg/Library/BaseHobLibNull/
> MdeModulePkg/Library/BasePlatformHookLibNull/
> MdeModulePkg/Library/BaseSortLib/
> MdeModulePkg/Library/CpuExceptionHandlerLibNull/
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/
> MdeModulePkg/Library/PeiRecoveryLibNull/
> MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> MdeModulePkg/Library/TpmMeasurementLibNull/
> MdeModulePkg/Library/UefiSortLib/
> MdeModulePkg/Universal/DevicePathDxe/
> MdeModulePkg/Universal/DriverHealthManagerDxe/
> MdeModulePkg/Universal/DriverSampleDxe/
> MdeModulePkg/Universal/FvSimpleFileSystemDxe/
> MdeModulePkg/Universal/LegacyRegion2Dxe/
> MdeModulePkg/Universal/Metronome/
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
> MdeModulePkg/Universal/PrintDxe/
> MdeModulePkg/Universal/RegularExpressionDxe/
> MdeModulePkg/Universal/TimestampDxe/
> MdeModulePkg/Universal/WatchdogTimerDxe/
Looking through this made me realise it would be useful to have a way
of quickly looking up section matches for a given path. So I added a
command line option -l/--lookup to GetMaintainer.py - inline below:
/
Leif
>From 11a04f4690e7b8bc348483a26bb3840b74b1fd9d Mon Sep 17 00:00:00 2001
From: Leif Lindholm <leif.lindholm@linaro.org>
Date: Wed, 19 Jun 2019 10:07:26 +0100
Subject: [RFC PATCH 1/1] BaseTools: add lookup function to GetMaintainer.py
Add command line option -l/--lookup, which lets you specify a path
(existent or not in the current tree) to look up maintainers for.
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
BaseTools/Scripts/GetMaintainer.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py
index 616342cdb434..444e601c55d1 100644
--- a/BaseTools/Scripts/GetMaintainer.py
+++ b/BaseTools/Scripts/GetMaintainer.py
@@ -160,15 +160,22 @@ if __name__ == '__main__':
help='git revision to examine (default: HEAD)',
nargs='?',
default='HEAD')
+ PARSER.add_argument('-l', '--lookup',
+ help='Find section matches for path LOOKUP',
+ required=False)
ARGS = PARSER.parse_args()
REPO = SetupGit.locate_repo()
- FILES = get_modified_files(REPO, ARGS)
CONFIG_FILE = os.path.join(REPO.working_dir, 'Maintainers.txt')
SECTIONS = parse_maintainers_file(CONFIG_FILE)
+ if ARGS.lookup:
+ FILES = [ARGS.lookup]
+ else:
+ FILES = get_modified_files(REPO, ARGS)
+
ADDRESSES = []
for file in FILES:
--
2.11.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-19 9:35 ` Leif Lindholm
@ 2019-06-20 15:43 ` Laszlo Ersek
2019-06-24 1:16 ` Wu, Hao A
0 siblings, 1 reply; 13+ messages in thread
From: Laszlo Ersek @ 2019-06-20 15:43 UTC (permalink / raw)
To: devel, leif.lindholm, Wu, Hao A
Cc: Kinney, Michael D, Andrew Fish, Justen, Jordan L, Ard Biesheuvel,
Gao, Liming, Yao, Jiewen, Zeng, Star
On 06/19/19 11:35, Leif Lindholm wrote:
> On Wed, Jun 19, 2019 at 05:09:40AM +0000, Wu, Hao A wrote:
>> Hello all,
>>
>> As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are
>> classified to a list of features.
>>
>> Please note that:
>> * The below list is a draft at this moment, please help to provide
>> feedbacks/comments;
>> * Modules with no clear classification are listed under the 'Misc' section
>> at the bottom of the list.
>
> Thank you for doing the heavy lifting.
+1
> A few comments below on how this could be more easily described in the
> Maintainer.txt syntax.
With Leif's comments addressed, I'd be super pleased to have this
pattern list for covering MdeModulePkg, minimally as a starting point.
(I'm neutral on moving around GraphicsOutputDxe and Logo -- we could do
that now, or as a later improvement.)
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-10 8:06 [RFC] Fine-grained review ownership for MdeModulePkg Wu, Hao A
2019-06-11 9:51 ` Leif Lindholm
@ 2019-06-20 22:23 ` rebecca
2019-06-21 0:11 ` Wu, Hao A
1 sibling, 1 reply; 13+ messages in thread
From: rebecca @ 2019-06-20 22:23 UTC (permalink / raw)
To: devel, hao.a.wu
Cc: lersek@redhat.com, Leif Lindholm, Kinney, Michael D, Andrew Fish,
Justen, Jordan L, Ard Biesheuvel, Gao, Liming, Yao, Jiewen,
Zeng, Star
On 2019-06-10 02:06, Wu, Hao A wrote:
> Hello all,
>
> Driven by the issue raised and discussions with thread:
> https://edk2.groups.io/g/devel/topic/31907735#42076
>
> This RFC proposal is raised to work out a fine-grained review ownership
> for MdeModulePkg.
Being an RFC, I think this should be CC'd to rfc@edk2.groups.io
(https://edk2.groups.io/g/rfc)?
--
Rebecca Cran
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-20 22:23 ` rebecca
@ 2019-06-21 0:11 ` Wu, Hao A
0 siblings, 0 replies; 13+ messages in thread
From: Wu, Hao A @ 2019-06-21 0:11 UTC (permalink / raw)
To: devel@edk2.groups.io, rebecca@bluestop.org
Cc: lersek@redhat.com, Leif Lindholm, Kinney, Michael D, Andrew Fish,
Justen, Jordan L, Ard Biesheuvel, Gao, Liming, Yao, Jiewen,
Zeng, Star
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebecca@bluestop.org
> Sent: Friday, June 21, 2019 6:24 AM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: lersek@redhat.com; Leif Lindholm; Kinney, Michael D; Andrew Fish;
> Justen, Jordan L; Ard Biesheuvel; Gao, Liming; Yao, Jiewen; Zeng, Star
> Subject: Re: [edk2-devel] [RFC] Fine-grained review ownership for
> MdeModulePkg
>
> On 2019-06-10 02:06, Wu, Hao A wrote:
> > Hello all,
> >
> > Driven by the issue raised and discussions with thread:
> > https://edk2.groups.io/g/devel/topic/31907735#42076
> >
> > This RFC proposal is raised to work out a fine-grained review ownership
> > for MdeModulePkg.
>
>
> Being an RFC, I think this should be CC'd to rfc@edk2.groups.io
> (https://edk2.groups.io/g/rfc)?
Thanks for the reminder, I will post the next update to the above list.
Best Regards,
Hao Wu
>
>
> --
> Rebecca Cran
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-20 15:43 ` [edk2-devel] " Laszlo Ersek
@ 2019-06-24 1:16 ` Wu, Hao A
2019-06-24 20:29 ` Laszlo Ersek
2019-07-16 13:53 ` Leif Lindholm
0 siblings, 2 replies; 13+ messages in thread
From: Wu, Hao A @ 2019-06-24 1:16 UTC (permalink / raw)
To: rfc@edk2.groups.io, devel@edk2.groups.io
Cc: Andrew Fish, Laszlo Ersek, Leif Lindholm, Kinney, Michael D,
Wang, Jian J, Ni, Ray, Zeng, Star
Hello all,
With Leif's comment on the better usage of the wildcard character & 'X:' tag:
https://edk2.groups.io/g/devel/message/42587
The list is updated as shown below.
Also, I forgot to mention that some directory/file may be classified into
multiple classes. I think it is a valid case, for example:
MdeModulePkg/Library/SmmMemoryAllocationProfileLib
matches both 'Memory Management' and 'SMM' sections:
Memory Management - F: MdeModulePkg/*Mem*/
SMM - F: MdeModulePkg/*Smm*/
Then, reviewers from both classes should be Cc-ed when changes are made in
the above library.
If the updated list is good enough, the next step will be determining the
reviewer(s) for each feature in the list.
The updated list:
ACPI:
F: MdeModulePkg/Include/*/*Acpi*.h
F: MdeModulePkg/Universal/Acpi/
BDS:
F: MdeModulePkg/*BootManager*/
X: MdeModulePkg/Application/BootManagerMenuApp/
F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
F: MdeModulePkg/Universal/BdsDxe/
F: MdeModulePkg/Universal/LoadFileOnFv2/
F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
Console:
F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
F: MdeModulePkg/Include/Guid/Console*.h
F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
F: MdeModulePkg/Include/Guid/TtyTerm.h
F: MdeModulePkg/Universal/Console/
X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
Core (PEI, DXE and Runtime):
F: MdeModulePkg/*SectionExtract*/
F: MdeModulePkg/Core/Dxe/
X: MdeModulePkg/Core/Dxe/Gcd/
X: MdeModulePkg/Core/Dxe/Mem/
F: MdeModulePkg/Core/DxeIplPeim/
F: MdeModulePkg/Core/Pei/
X: MdeModulePkg/Core/Pei/Memory/
X: MdeModulePkg/Core/Pei/PciCfg2/
X: MdeModulePkg/Core/Pei/Reset/
X: MdeModulePkg/Core/Pei/StatusCode/
F: MdeModulePkg/Core/RuntimeDxe/
F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
F: MdeModulePkg/Include/Library/SecurityManagementLib.h
F: MdeModulePkg/Library/DxeSecurityManagementLib/
F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
Debug:
F: MdeModulePkg/*Debug*/
X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
F: MdeModulePkg/Include/Guid/DebugMask.h
F: MdeModulePkg/Include/Library/DebugAgentLib.h
F: MdeModulePkg/Include/Ppi/Debug.h
Decompress:
F: MdeModulePkg/Include/Guid/LzmaDecompress.h
F: MdeModulePkg/Library/*Decompress*/
Device:
F: MdeModulePkg/*Serial*/
X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
F: MdeModulePkg/Bus/
X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
X: MdeModulePkg/Bus/Pci/PciBusDxe/
X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
F: MdeModulePkg/Include/*/*Ata*.h
F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
F: MdeModulePkg/Include/*/*NvmExpress*.h
F: MdeModulePkg/Include/*/*SerialPort*.h
F: MdeModulePkg/Include/*/*SdMmc*.h
F: MdeModulePkg/Include/*/*Ufs*.h
F: MdeModulePkg/Include/*/*Usb*.h
F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
F: MdeModulePkg/Include/Guid/RecoveryDevice.h
F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
F: MdeModulePkg/Include/Protocol/Ps2Policy.h
F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
Disk:
F: MdeModulePkg/Universal/Disk/
EBC:
F: MdeModulePkg/Include/*/*Ebc*.h
F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
F: MdeModulePkg/Universal/EbcDxe/
Firmware Update:
F: MdeModulePkg/*Capsule*/
F: MdeModulePkg/Include/*/*Capsule*.h
F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
F: MdeModulePkg/Include/Protocol/EsrtManagement.h
F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
F: MdeModulePkg/Library/FmpAuthenticationLibNull/
F: MdeModulePkg/Universal/Esrt*/
Graphic:
F: MdeModulePkg/*Logo*/
F: MdeModulePkg/Include/*/*Logo*.h
F: MdeModulePkg/Include/Library/BmpSupportLib.h
F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
F: MdeModulePkg/Library/BaseBmpSupportLib/
F: MdeModulePkg/Library/FrameBufferBltLib/
F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
HII/UI:
F: MdeModulePkg/*FileExplorer*/
F: MdeModulePkg/*Hii*/
F: MdeModulePkg/*Ui*/
F: MdeModulePkg/Application/BootManagerMenuApp/
F: MdeModulePkg/Include/*/*FileExplorer*.h
F: MdeModulePkg/Include/*/*FormBrowser*.h
F: MdeModulePkg/Include/*/*Hii*.h
F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
F: MdeModulePkg/Library/CustomizedDisplayLib/
F: MdeModulePkg/Universal/DisplayEngineDxe/
F: MdeModulePkg/Universal/SetupBrowserDxe/
IPMI:
F: MdeModulePkg/Include/*/*Ipmi*.h
F: MdeModulePkg/Library/*Ipmi*/
Memory Management:
F: MdeModulePkg/*Mem*/
F: MdeModulePkg/Core/Dxe/Gcd/
F: MdeModulePkg/Include/*/*Mem*.h
F: MdeModulePkg/Include/*/*IoMmu*.h
PCD:
F: MdeModulePkg/Application/DumpDynPcd/
F: MdeModulePkg/Include/*/*Pcd*.h
F: MdeModulePkg/Universal/PCD/
PCI Bus:
F: MdeModulePkg/*PciHostBridge*/
F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
F: MdeModulePkg/Bus/Pci/PciBusDxe/
F: MdeModulePkg/Core/Pei/PciCfg2/
F: MdeModulePkg/Include/Library/PciHostBridgeLib.h
F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
Performance:
F: MdeModulePkg/Include/*/*Perf*.h
F: MdeModulePkg/Library/*Perf*/
Reset:
F: MdeModulePkg/*Reset*/
F: MdeModulePkg/Include/*/*Reset*.h
S3:
F: MdeModulePkg/*LockBox*/
F: MdeModulePkg/Include/*/*BootScript*.h
F: MdeModulePkg/Include/*/*LockBox*.h
F: MdeModulePkg/Include/*/*S3*.h
F: MdeModulePkg/Library/*S3*/
SMBIOS:
F: MdeModulePkg/Universal/Smbios*/
SMM:
F: MdeModulePkg/*Smi*/
F: MdeModulePkg/*Smm*/
F: MdeModulePkg/Include/*/*Smi*.h
F: MdeModulePkg/Include/*/*Smm*.h
Status Code:
F: MdeModulePkg/*StatusCode*/
F: MdeModulePkg/Include/*/*StatusCode*.h
Variable:
F: MdeModulePkg/*Var*/
F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h
F: MdeModulePkg/Include/*/*Var*.h
F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h
F: MdeModulePkg/Include/Protocol/SwapAddressRange.h
F: MdeModulePkg/Universal/FaultTolerantWrite*/
Misc:
F: MdeModulePkg/Application/HelloWorld/
F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h
F: MdeModulePkg/Include/Guid/MtcVendor.h
F: MdeModulePkg/Include/Guid/ZeroGuid.h
F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
F: MdeModulePkg/Include/Library/PlatformHookLib.h
F: MdeModulePkg/Include/Library/RecoveryLib.h
F: MdeModulePkg/Include/Library/SortLib.h
F: MdeModulePkg/Include/Library/TpmMeasurementLib.h
F: MdeModulePkg/Include/Protocol/Dpc.h
F: MdeModulePkg/Include/Protocol/LoadPe32Image.h
F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
F: MdeModulePkg/Include/Protocol/Print2.h
F: MdeModulePkg/Library/BaseHobLibNull/
F: MdeModulePkg/Library/BasePlatformHookLibNull/
F: MdeModulePkg/Library/BaseSortLib/
F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/
F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/
F: MdeModulePkg/Library/PeiRecoveryLibNull/
F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
F: MdeModulePkg/Library/TpmMeasurementLibNull/
F: MdeModulePkg/Library/UefiSortLib/
F: MdeModulePkg/Universal/DevicePathDxe/
F: MdeModulePkg/Universal/DriverHealthManagerDxe/
F: MdeModulePkg/Universal/DriverSampleDxe/
F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/
F: MdeModulePkg/Universal/LegacyRegion2Dxe/
F: MdeModulePkg/Universal/Metronome/
F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
F: MdeModulePkg/Universal/PrintDxe/
F: MdeModulePkg/Universal/RegularExpressionDxe/
F: MdeModulePkg/Universal/TimestampDxe/
F: MdeModulePkg/Universal/WatchdogTimerDxe/
Best Regards,
Hao Wu
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-24 1:16 ` Wu, Hao A
@ 2019-06-24 20:29 ` Laszlo Ersek
2019-06-24 22:58 ` Yao, Jiewen
2019-07-16 13:53 ` Leif Lindholm
1 sibling, 1 reply; 13+ messages in thread
From: Laszlo Ersek @ 2019-06-24 20:29 UTC (permalink / raw)
To: Wu, Hao A, rfc@edk2.groups.io, devel@edk2.groups.io
Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D, Wang, Jian J,
Ni, Ray, Zeng, Star
On 06/24/19 03:16, Wu, Hao A wrote:
> Hello all,
>
> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
> https://edk2.groups.io/g/devel/message/42587
>
> The list is updated as shown below.
>
> Also, I forgot to mention that some directory/file may be classified into
> multiple classes. I think it is a valid case, for example:
>
> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
>
> matches both 'Memory Management' and 'SMM' sections:
>
> Memory Management - F: MdeModulePkg/*Mem*/
> SMM - F: MdeModulePkg/*Smm*/
>
> Then, reviewers from both classes should be Cc-ed when changes are made in
> the above library.
>
> If the updated list is good enough, the next step will be determining the
> reviewer(s) for each feature in the list.
I think it's good enough. :)
Thanks
Laszlo
>
>
> The updated list:
> ACPI:
> F: MdeModulePkg/Include/*/*Acpi*.h
> F: MdeModulePkg/Universal/Acpi/
>
> BDS:
> F: MdeModulePkg/*BootManager*/
> X: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> F: MdeModulePkg/Universal/BdsDxe/
> F: MdeModulePkg/Universal/LoadFileOnFv2/
> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
>
> Console:
> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> F: MdeModulePkg/Include/Guid/Console*.h
> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> F: MdeModulePkg/Include/Guid/TtyTerm.h
> F: MdeModulePkg/Universal/Console/
> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>
> Core (PEI, DXE and Runtime):
> F: MdeModulePkg/*SectionExtract*/
> F: MdeModulePkg/Core/Dxe/
> X: MdeModulePkg/Core/Dxe/Gcd/
> X: MdeModulePkg/Core/Dxe/Mem/
> F: MdeModulePkg/Core/DxeIplPeim/
> F: MdeModulePkg/Core/Pei/
> X: MdeModulePkg/Core/Pei/Memory/
> X: MdeModulePkg/Core/Pei/PciCfg2/
> X: MdeModulePkg/Core/Pei/Reset/
> X: MdeModulePkg/Core/Pei/StatusCode/
> F: MdeModulePkg/Core/RuntimeDxe/
> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> F: MdeModulePkg/Library/DxeSecurityManagementLib/
> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
>
> Debug:
> F: MdeModulePkg/*Debug*/
> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> F: MdeModulePkg/Include/Guid/DebugMask.h
> F: MdeModulePkg/Include/Library/DebugAgentLib.h
> F: MdeModulePkg/Include/Ppi/Debug.h
>
> Decompress:
> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> F: MdeModulePkg/Library/*Decompress*/
>
> Device:
> F: MdeModulePkg/*Serial*/
> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Bus/
> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> X: MdeModulePkg/Bus/Pci/PciBusDxe/
> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> F: MdeModulePkg/Include/*/*Ata*.h
> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> F: MdeModulePkg/Include/*/*NvmExpress*.h
> F: MdeModulePkg/Include/*/*SerialPort*.h
> F: MdeModulePkg/Include/*/*SdMmc*.h
> F: MdeModulePkg/Include/*/*Ufs*.h
> F: MdeModulePkg/Include/*/*Usb*.h
> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
>
> Disk:
> F: MdeModulePkg/Universal/Disk/
>
> EBC:
> F: MdeModulePkg/Include/*/*Ebc*.h
> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> F: MdeModulePkg/Universal/EbcDxe/
>
> Firmware Update:
> F: MdeModulePkg/*Capsule*/
> F: MdeModulePkg/Include/*/*Capsule*.h
> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> F: MdeModulePkg/Universal/Esrt*/
>
> Graphic:
> F: MdeModulePkg/*Logo*/
> F: MdeModulePkg/Include/*/*Logo*.h
> F: MdeModulePkg/Include/Library/BmpSupportLib.h
> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
> F: MdeModulePkg/Library/BaseBmpSupportLib/
> F: MdeModulePkg/Library/FrameBufferBltLib/
> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>
> HII/UI:
> F: MdeModulePkg/*FileExplorer*/
> F: MdeModulePkg/*Hii*/
> F: MdeModulePkg/*Ui*/
> F: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/*/*FileExplorer*.h
> F: MdeModulePkg/Include/*/*FormBrowser*.h
> F: MdeModulePkg/Include/*/*Hii*.h
> F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
> F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
> F: MdeModulePkg/Library/CustomizedDisplayLib/
> F: MdeModulePkg/Universal/DisplayEngineDxe/
> F: MdeModulePkg/Universal/SetupBrowserDxe/
>
> IPMI:
> F: MdeModulePkg/Include/*/*Ipmi*.h
> F: MdeModulePkg/Library/*Ipmi*/
>
> Memory Management:
> F: MdeModulePkg/*Mem*/
> F: MdeModulePkg/Core/Dxe/Gcd/
> F: MdeModulePkg/Include/*/*Mem*.h
> F: MdeModulePkg/Include/*/*IoMmu*.h
>
> PCD:
> F: MdeModulePkg/Application/DumpDynPcd/
> F: MdeModulePkg/Include/*/*Pcd*.h
> F: MdeModulePkg/Universal/PCD/
>
> PCI Bus:
> F: MdeModulePkg/*PciHostBridge*/
> F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> F: MdeModulePkg/Bus/Pci/PciBusDxe/
> F: MdeModulePkg/Core/Pei/PciCfg2/
> F: MdeModulePkg/Include/Library/PciHostBridgeLib.h
> F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
>
> Performance:
> F: MdeModulePkg/Include/*/*Perf*.h
> F: MdeModulePkg/Library/*Perf*/
>
> Reset:
> F: MdeModulePkg/*Reset*/
> F: MdeModulePkg/Include/*/*Reset*.h
>
> S3:
> F: MdeModulePkg/*LockBox*/
> F: MdeModulePkg/Include/*/*BootScript*.h
> F: MdeModulePkg/Include/*/*LockBox*.h
> F: MdeModulePkg/Include/*/*S3*.h
> F: MdeModulePkg/Library/*S3*/
>
> SMBIOS:
> F: MdeModulePkg/Universal/Smbios*/
>
> SMM:
> F: MdeModulePkg/*Smi*/
> F: MdeModulePkg/*Smm*/
> F: MdeModulePkg/Include/*/*Smi*.h
> F: MdeModulePkg/Include/*/*Smm*.h
>
> Status Code:
> F: MdeModulePkg/*StatusCode*/
> F: MdeModulePkg/Include/*/*StatusCode*.h
>
> Variable:
> F: MdeModulePkg/*Var*/
> F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h
> F: MdeModulePkg/Include/*/*Var*.h
> F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h
> F: MdeModulePkg/Include/Protocol/SwapAddressRange.h
> F: MdeModulePkg/Universal/FaultTolerantWrite*/
>
> Misc:
> F: MdeModulePkg/Application/HelloWorld/
> F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h
> F: MdeModulePkg/Include/Guid/MtcVendor.h
> F: MdeModulePkg/Include/Guid/ZeroGuid.h
> F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
> F: MdeModulePkg/Include/Library/PlatformHookLib.h
> F: MdeModulePkg/Include/Library/RecoveryLib.h
> F: MdeModulePkg/Include/Library/SortLib.h
> F: MdeModulePkg/Include/Library/TpmMeasurementLib.h
> F: MdeModulePkg/Include/Protocol/Dpc.h
> F: MdeModulePkg/Include/Protocol/LoadPe32Image.h
> F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
> F: MdeModulePkg/Include/Protocol/Print2.h
> F: MdeModulePkg/Library/BaseHobLibNull/
> F: MdeModulePkg/Library/BasePlatformHookLibNull/
> F: MdeModulePkg/Library/BaseSortLib/
> F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/
> F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/
> F: MdeModulePkg/Library/PeiRecoveryLibNull/
> F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Library/TpmMeasurementLibNull/
> F: MdeModulePkg/Library/UefiSortLib/
> F: MdeModulePkg/Universal/DevicePathDxe/
> F: MdeModulePkg/Universal/DriverHealthManagerDxe/
> F: MdeModulePkg/Universal/DriverSampleDxe/
> F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/
> F: MdeModulePkg/Universal/LegacyRegion2Dxe/
> F: MdeModulePkg/Universal/Metronome/
> F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
> F: MdeModulePkg/Universal/PrintDxe/
> F: MdeModulePkg/Universal/RegularExpressionDxe/
> F: MdeModulePkg/Universal/TimestampDxe/
> F: MdeModulePkg/Universal/WatchdogTimerDxe/
>
>
> Best Regards,
> Hao Wu
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-24 20:29 ` Laszlo Ersek
@ 2019-06-24 22:58 ` Yao, Jiewen
0 siblings, 0 replies; 13+ messages in thread
From: Yao, Jiewen @ 2019-06-24 22:58 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Wu, Hao A, rfc@edk2.groups.io, Andrew Fish, Leif Lindholm,
Kinney, Michael D, Wang, Jian J, Ni, Ray, Zeng, Star
thanks
How about to put driversample to ui?
How about to put iommu to device?
thank you!
Yao, Jiewen
> 在 2019年6月25日，上午4:30，Laszlo Ersek <lersek@redhat.com> 写道：
>
>> On 06/24/19 03:16, Wu, Hao A wrote:
>> Hello all,
>>
>> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
>> https://edk2.groups.io/g/devel/message/42587
>>
>> The list is updated as shown below.
>>
>> Also, I forgot to mention that some directory/file may be classified into
>> multiple classes. I think it is a valid case, for example:
>>
>> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
>>
>> matches both 'Memory Management' and 'SMM' sections:
>>
>> Memory Management - F: MdeModulePkg/*Mem*/
>> SMM - F: MdeModulePkg/*Smm*/
>>
>> Then, reviewers from both classes should be Cc-ed when changes are made in
>> the above library.
>>
>> If the updated list is good enough, the next step will be determining the
>> reviewer(s) for each feature in the list.
>
> I think it's good enough. :)
>
> Thanks
> Laszlo
>
>>
>>
>> The updated list:
>> ACPI:
>> F: MdeModulePkg/Include/*/*Acpi*.h
>> F: MdeModulePkg/Universal/Acpi/
>>
>> BDS:
>> F: MdeModulePkg/*BootManager*/
>> X: MdeModulePkg/Application/BootManagerMenuApp/
>> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
>> F: MdeModulePkg/Universal/BdsDxe/
>> F: MdeModulePkg/Universal/LoadFileOnFv2/
>> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
>>
>> Console:
>> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
>> F: MdeModulePkg/Include/Guid/Console*.h
>> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
>> F: MdeModulePkg/Include/Guid/TtyTerm.h
>> F: MdeModulePkg/Universal/Console/
>> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>>
>> Core (PEI, DXE and Runtime):
>> F: MdeModulePkg/*SectionExtract*/
>> F: MdeModulePkg/Core/Dxe/
>> X: MdeModulePkg/Core/Dxe/Gcd/
>> X: MdeModulePkg/Core/Dxe/Mem/
>> F: MdeModulePkg/Core/DxeIplPeim/
>> F: MdeModulePkg/Core/Pei/
>> X: MdeModulePkg/Core/Pei/Memory/
>> X: MdeModulePkg/Core/Pei/PciCfg2/
>> X: MdeModulePkg/Core/Pei/Reset/
>> X: MdeModulePkg/Core/Pei/StatusCode/
>> F: MdeModulePkg/Core/RuntimeDxe/
>> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
>> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
>> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
>> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
>> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
>> F: MdeModulePkg/Library/DxeSecurityManagementLib/
>> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
>> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
>>
>> Debug:
>> F: MdeModulePkg/*Debug*/
>> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
>> F: MdeModulePkg/Include/Guid/DebugMask.h
>> F: MdeModulePkg/Include/Library/DebugAgentLib.h
>> F: MdeModulePkg/Include/Ppi/Debug.h
>>
>> Decompress:
>> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
>> F: MdeModulePkg/Library/*Decompress*/
>>
>> Device:
>> F: MdeModulePkg/*Serial*/
>> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
>> F: MdeModulePkg/Bus/
>> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
>> X: MdeModulePkg/Bus/Pci/PciBusDxe/
>> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
>> F: MdeModulePkg/Include/*/*Ata*.h
>> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
>> F: MdeModulePkg/Include/*/*NvmExpress*.h
>> F: MdeModulePkg/Include/*/*SerialPort*.h
>> F: MdeModulePkg/Include/*/*SdMmc*.h
>> F: MdeModulePkg/Include/*/*Ufs*.h
>> F: MdeModulePkg/Include/*/*Usb*.h
>> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
>> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
>> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
>> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
>> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
>>
>> Disk:
>> F: MdeModulePkg/Universal/Disk/
>>
>> EBC:
>> F: MdeModulePkg/Include/*/*Ebc*.h
>> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
>> F: MdeModulePkg/Universal/EbcDxe/
>>
>> Firmware Update:
>> F: MdeModulePkg/*Capsule*/
>> F: MdeModulePkg/Include/*/*Capsule*.h
>> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
>> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
>> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
>> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
>> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
>> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
>> F: MdeModulePkg/Universal/Esrt*/
>>
>> Graphic:
>> F: MdeModulePkg/*Logo*/
>> F: MdeModulePkg/Include/*/*Logo*.h
>> F: MdeModulePkg/Include/Library/BmpSupportLib.h
>> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
>> F: MdeModulePkg/Library/BaseBmpSupportLib/
>> F: MdeModulePkg/Library/FrameBufferBltLib/
>> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>>
>> HII/UI:
>> F: MdeModulePkg/*FileExplorer*/
>> F: MdeModulePkg/*Hii*/
>> F: MdeModulePkg/*Ui*/
>> F: MdeModulePkg/Application/BootManagerMenuApp/
>> F: MdeModulePkg/Include/*/*FileExplorer*.h
>> F: MdeModulePkg/Include/*/*FormBrowser*.h
>> F: MdeModulePkg/Include/*/*Hii*.h
>> F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
>> F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
>> F: MdeModulePkg/Library/CustomizedDisplayLib/
>> F: MdeModulePkg/Universal/DisplayEngineDxe/
>> F: MdeModulePkg/Universal/SetupBrowserDxe/
>>
>> IPMI:
>> F: MdeModulePkg/Include/*/*Ipmi*.h
>> F: MdeModulePkg/Library/*Ipmi*/
>>
>> Memory Management:
>> F: MdeModulePkg/*Mem*/
>> F: MdeModulePkg/Core/Dxe/Gcd/
>> F: MdeModulePkg/Include/*/*Mem*.h
>> F: MdeModulePkg/Include/*/*IoMmu*.h
>>
>> PCD:
>> F: MdeModulePkg/Application/DumpDynPcd/
>> F: MdeModulePkg/Include/*/*Pcd*.h
>> F: MdeModulePkg/Universal/PCD/
>>
>> PCI Bus:
>> F: MdeModulePkg/*PciHostBridge*/
>> F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
>> F: MdeModulePkg/Bus/Pci/PciBusDxe/
>> F: MdeModulePkg/Core/Pei/PciCfg2/
>> F: MdeModulePkg/Include/Library/PciHostBridgeLib.h
>> F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
>>
>> Performance:
>> F: MdeModulePkg/Include/*/*Perf*.h
>> F: MdeModulePkg/Library/*Perf*/
>>
>> Reset:
>> F: MdeModulePkg/*Reset*/
>> F: MdeModulePkg/Include/*/*Reset*.h
>>
>> S3:
>> F: MdeModulePkg/*LockBox*/
>> F: MdeModulePkg/Include/*/*BootScript*.h
>> F: MdeModulePkg/Include/*/*LockBox*.h
>> F: MdeModulePkg/Include/*/*S3*.h
>> F: MdeModulePkg/Library/*S3*/
>>
>> SMBIOS:
>> F: MdeModulePkg/Universal/Smbios*/
>>
>> SMM:
>> F: MdeModulePkg/*Smi*/
>> F: MdeModulePkg/*Smm*/
>> F: MdeModulePkg/Include/*/*Smi*.h
>> F: MdeModulePkg/Include/*/*Smm*.h
>>
>> Status Code:
>> F: MdeModulePkg/*StatusCode*/
>> F: MdeModulePkg/Include/*/*StatusCode*.h
>>
>> Variable:
>> F: MdeModulePkg/*Var*/
>> F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h
>> F: MdeModulePkg/Include/*/*Var*.h
>> F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h
>> F: MdeModulePkg/Include/Protocol/SwapAddressRange.h
>> F: MdeModulePkg/Universal/FaultTolerantWrite*/
>>
>> Misc:
>> F: MdeModulePkg/Application/HelloWorld/
>> F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h
>> F: MdeModulePkg/Include/Guid/MtcVendor.h
>> F: MdeModulePkg/Include/Guid/ZeroGuid.h
>> F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
>> F: MdeModulePkg/Include/Library/PlatformHookLib.h
>> F: MdeModulePkg/Include/Library/RecoveryLib.h
>> F: MdeModulePkg/Include/Library/SortLib.h
>> F: MdeModulePkg/Include/Library/TpmMeasurementLib.h
>> F: MdeModulePkg/Include/Protocol/Dpc.h
>> F: MdeModulePkg/Include/Protocol/LoadPe32Image.h
>> F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>> F: MdeModulePkg/Include/Protocol/Print2.h
>> F: MdeModulePkg/Library/BaseHobLibNull/
>> F: MdeModulePkg/Library/BasePlatformHookLibNull/
>> F: MdeModulePkg/Library/BaseSortLib/
>> F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/
>> F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/
>> F: MdeModulePkg/Library/PeiRecoveryLibNull/
>> F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
>> F: MdeModulePkg/Library/TpmMeasurementLibNull/
>> F: MdeModulePkg/Library/UefiSortLib/
>> F: MdeModulePkg/Universal/DevicePathDxe/
>> F: MdeModulePkg/Universal/DriverHealthManagerDxe/
>> F: MdeModulePkg/Universal/DriverSampleDxe/
>> F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/
>> F: MdeModulePkg/Universal/LegacyRegion2Dxe/
>> F: MdeModulePkg/Universal/Metronome/
>> F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
>> F: MdeModulePkg/Universal/PrintDxe/
>> F: MdeModulePkg/Universal/RegularExpressionDxe/
>> F: MdeModulePkg/Universal/TimestampDxe/
>> F: MdeModulePkg/Universal/WatchdogTimerDxe/
>>
>>
>> Best Regards,
>> Hao Wu
>>
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-06-24 1:16 ` Wu, Hao A
2019-06-24 20:29 ` Laszlo Ersek
@ 2019-07-16 13:53 ` Leif Lindholm
2019-07-17 1:47 ` Wu, Hao A
1 sibling, 1 reply; 13+ messages in thread
From: Leif Lindholm @ 2019-07-16 13:53 UTC (permalink / raw)
To: Wu, Hao A
Cc: rfc@edk2.groups.io, devel@edk2.groups.io, Andrew Fish,
Laszlo Ersek, Kinney, Michael D, Wang, Jian J, Ni, Ray,
Zeng, Star
Hi Hao Wu,
Are you ready to send out a v1 yet? (Or did I miss it?)
I would prefer to get this in before the GetMaintainer.py script, and
after the comment updates to Maintainers.txt.
Best Regards,
Leif
On Mon, Jun 24, 2019 at 01:16:05AM +0000, Wu, Hao A wrote:
> Hello all,
>
> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
> https://edk2.groups.io/g/devel/message/42587
>
> The list is updated as shown below.
>
> Also, I forgot to mention that some directory/file may be classified into
> multiple classes. I think it is a valid case, for example:
>
> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
>
> matches both 'Memory Management' and 'SMM' sections:
>
> Memory Management - F: MdeModulePkg/*Mem*/
> SMM - F: MdeModulePkg/*Smm*/
>
> Then, reviewers from both classes should be Cc-ed when changes are made in
> the above library.
>
> If the updated list is good enough, the next step will be determining the
> reviewer(s) for each feature in the list.
>
>
> The updated list:
> ACPI:
> F: MdeModulePkg/Include/*/*Acpi*.h
> F: MdeModulePkg/Universal/Acpi/
>
> BDS:
> F: MdeModulePkg/*BootManager*/
> X: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> F: MdeModulePkg/Universal/BdsDxe/
> F: MdeModulePkg/Universal/LoadFileOnFv2/
> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
>
> Console:
> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> F: MdeModulePkg/Include/Guid/Console*.h
> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> F: MdeModulePkg/Include/Guid/TtyTerm.h
> F: MdeModulePkg/Universal/Console/
> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>
> Core (PEI, DXE and Runtime):
> F: MdeModulePkg/*SectionExtract*/
> F: MdeModulePkg/Core/Dxe/
> X: MdeModulePkg/Core/Dxe/Gcd/
> X: MdeModulePkg/Core/Dxe/Mem/
> F: MdeModulePkg/Core/DxeIplPeim/
> F: MdeModulePkg/Core/Pei/
> X: MdeModulePkg/Core/Pei/Memory/
> X: MdeModulePkg/Core/Pei/PciCfg2/
> X: MdeModulePkg/Core/Pei/Reset/
> X: MdeModulePkg/Core/Pei/StatusCode/
> F: MdeModulePkg/Core/RuntimeDxe/
> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> F: MdeModulePkg/Library/DxeSecurityManagementLib/
> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
>
> Debug:
> F: MdeModulePkg/*Debug*/
> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> F: MdeModulePkg/Include/Guid/DebugMask.h
> F: MdeModulePkg/Include/Library/DebugAgentLib.h
> F: MdeModulePkg/Include/Ppi/Debug.h
>
> Decompress:
> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> F: MdeModulePkg/Library/*Decompress*/
>
> Device:
> F: MdeModulePkg/*Serial*/
> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Bus/
> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> X: MdeModulePkg/Bus/Pci/PciBusDxe/
> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> F: MdeModulePkg/Include/*/*Ata*.h
> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> F: MdeModulePkg/Include/*/*NvmExpress*.h
> F: MdeModulePkg/Include/*/*SerialPort*.h
> F: MdeModulePkg/Include/*/*SdMmc*.h
> F: MdeModulePkg/Include/*/*Ufs*.h
> F: MdeModulePkg/Include/*/*Usb*.h
> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
>
> Disk:
> F: MdeModulePkg/Universal/Disk/
>
> EBC:
> F: MdeModulePkg/Include/*/*Ebc*.h
> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> F: MdeModulePkg/Universal/EbcDxe/
>
> Firmware Update:
> F: MdeModulePkg/*Capsule*/
> F: MdeModulePkg/Include/*/*Capsule*.h
> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> F: MdeModulePkg/Universal/Esrt*/
>
> Graphic:
> F: MdeModulePkg/*Logo*/
> F: MdeModulePkg/Include/*/*Logo*.h
> F: MdeModulePkg/Include/Library/BmpSupportLib.h
> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
> F: MdeModulePkg/Library/BaseBmpSupportLib/
> F: MdeModulePkg/Library/FrameBufferBltLib/
> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>
> HII/UI:
> F: MdeModulePkg/*FileExplorer*/
> F: MdeModulePkg/*Hii*/
> F: MdeModulePkg/*Ui*/
> F: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/*/*FileExplorer*.h
> F: MdeModulePkg/Include/*/*FormBrowser*.h
> F: MdeModulePkg/Include/*/*Hii*.h
> F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
> F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
> F: MdeModulePkg/Library/CustomizedDisplayLib/
> F: MdeModulePkg/Universal/DisplayEngineDxe/
> F: MdeModulePkg/Universal/SetupBrowserDxe/
>
> IPMI:
> F: MdeModulePkg/Include/*/*Ipmi*.h
> F: MdeModulePkg/Library/*Ipmi*/
>
> Memory Management:
> F: MdeModulePkg/*Mem*/
> F: MdeModulePkg/Core/Dxe/Gcd/
> F: MdeModulePkg/Include/*/*Mem*.h
> F: MdeModulePkg/Include/*/*IoMmu*.h
>
> PCD:
> F: MdeModulePkg/Application/DumpDynPcd/
> F: MdeModulePkg/Include/*/*Pcd*.h
> F: MdeModulePkg/Universal/PCD/
>
> PCI Bus:
> F: MdeModulePkg/*PciHostBridge*/
> F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> F: MdeModulePkg/Bus/Pci/PciBusDxe/
> F: MdeModulePkg/Core/Pei/PciCfg2/
> F: MdeModulePkg/Include/Library/PciHostBridgeLib.h
> F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
>
> Performance:
> F: MdeModulePkg/Include/*/*Perf*.h
> F: MdeModulePkg/Library/*Perf*/
>
> Reset:
> F: MdeModulePkg/*Reset*/
> F: MdeModulePkg/Include/*/*Reset*.h
>
> S3:
> F: MdeModulePkg/*LockBox*/
> F: MdeModulePkg/Include/*/*BootScript*.h
> F: MdeModulePkg/Include/*/*LockBox*.h
> F: MdeModulePkg/Include/*/*S3*.h
> F: MdeModulePkg/Library/*S3*/
>
> SMBIOS:
> F: MdeModulePkg/Universal/Smbios*/
>
> SMM:
> F: MdeModulePkg/*Smi*/
> F: MdeModulePkg/*Smm*/
> F: MdeModulePkg/Include/*/*Smi*.h
> F: MdeModulePkg/Include/*/*Smm*.h
>
> Status Code:
> F: MdeModulePkg/*StatusCode*/
> F: MdeModulePkg/Include/*/*StatusCode*.h
>
> Variable:
> F: MdeModulePkg/*Var*/
> F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h
> F: MdeModulePkg/Include/*/*Var*.h
> F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h
> F: MdeModulePkg/Include/Protocol/SwapAddressRange.h
> F: MdeModulePkg/Universal/FaultTolerantWrite*/
>
> Misc:
> F: MdeModulePkg/Application/HelloWorld/
> F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h
> F: MdeModulePkg/Include/Guid/MtcVendor.h
> F: MdeModulePkg/Include/Guid/ZeroGuid.h
> F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
> F: MdeModulePkg/Include/Library/PlatformHookLib.h
> F: MdeModulePkg/Include/Library/RecoveryLib.h
> F: MdeModulePkg/Include/Library/SortLib.h
> F: MdeModulePkg/Include/Library/TpmMeasurementLib.h
> F: MdeModulePkg/Include/Protocol/Dpc.h
> F: MdeModulePkg/Include/Protocol/LoadPe32Image.h
> F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
> F: MdeModulePkg/Include/Protocol/Print2.h
> F: MdeModulePkg/Library/BaseHobLibNull/
> F: MdeModulePkg/Library/BasePlatformHookLibNull/
> F: MdeModulePkg/Library/BaseSortLib/
> F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/
> F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/
> F: MdeModulePkg/Library/PeiRecoveryLibNull/
> F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Library/TpmMeasurementLibNull/
> F: MdeModulePkg/Library/UefiSortLib/
> F: MdeModulePkg/Universal/DevicePathDxe/
> F: MdeModulePkg/Universal/DriverHealthManagerDxe/
> F: MdeModulePkg/Universal/DriverSampleDxe/
> F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/
> F: MdeModulePkg/Universal/LegacyRegion2Dxe/
> F: MdeModulePkg/Universal/Metronome/
> F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
> F: MdeModulePkg/Universal/PrintDxe/
> F: MdeModulePkg/Universal/RegularExpressionDxe/
> F: MdeModulePkg/Universal/TimestampDxe/
> F: MdeModulePkg/Universal/WatchdogTimerDxe/
>
>
> Best Regards,
> Hao Wu
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
2019-07-16 13:53 ` Leif Lindholm
@ 2019-07-17 1:47 ` Wu, Hao A
0 siblings, 0 replies; 13+ messages in thread
From: Wu, Hao A @ 2019-07-17 1:47 UTC (permalink / raw)
To: Leif Lindholm
Cc: rfc@edk2.groups.io, devel@edk2.groups.io, Andrew Fish,
Laszlo Ersek, Kinney, Michael D, Wang, Jian J, Ni, Ray,
Zeng, Star
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, July 16, 2019 9:53 PM
> To: Wu, Hao A
> Cc: rfc@edk2.groups.io; devel@edk2.groups.io; Andrew Fish; Laszlo Ersek;
> Kinney, Michael D; Wang, Jian J; Ni, Ray; Zeng, Star
> Subject: Re: [edk2-devel] [RFC] Fine-grained review ownership for
> MdeModulePkg
>
> Hi Hao Wu,
>
> Are you ready to send out a v1 yet? (Or did I miss it?)
> I would prefer to get this in before the GetMaintainer.py script, and
> after the comment updates to Maintainers.txt.
Sorry Leif,
You did not miss anything.
I was planning to send out the patch after your proposed changes are pushed.
Now, I have sent out the patch at:
https://edk2.groups.io/g/devel/message/43827
Best Regards,
Hao Wu
>
> Best Regards,
>
> Leif
>
> On Mon, Jun 24, 2019 at 01:16:05AM +0000, Wu, Hao A wrote:
> > Hello all,
> >
> > With Leif's comment on the better usage of the wildcard character & 'X:' tag:
> > https://edk2.groups.io/g/devel/message/42587
> >
> > The list is updated as shown below.
> >
> > Also, I forgot to mention that some directory/file may be classified into
> > multiple classes. I think it is a valid case, for example:
> >
> > MdeModulePkg/Library/SmmMemoryAllocationProfileLib
> >
> > matches both 'Memory Management' and 'SMM' sections:
> >
> > Memory Management - F: MdeModulePkg/*Mem*/
> > SMM - F: MdeModulePkg/*Smm*/
> >
> > Then, reviewers from both classes should be Cc-ed when changes are
> made in
> > the above library.
> >
> > If the updated list is good enough, the next step will be determining the
> > reviewer(s) for each feature in the list.
> >
> >
> > The updated list:
> > ACPI:
> > F: MdeModulePkg/Include/*/*Acpi*.h
> > F: MdeModulePkg/Universal/Acpi/
> >
> > BDS:
> > F: MdeModulePkg/*BootManager*/
> > X: MdeModulePkg/Application/BootManagerMenuApp/
> > F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> > F: MdeModulePkg/Universal/BdsDxe/
> > F: MdeModulePkg/Universal/LoadFileOnFv2/
> > F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
> >
> > Console:
> > F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> > F: MdeModulePkg/Include/Guid/Console*.h
> > F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> > F: MdeModulePkg/Include/Guid/TtyTerm.h
> > F: MdeModulePkg/Universal/Console/
> > X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> >
> > Core (PEI, DXE and Runtime):
> > F: MdeModulePkg/*SectionExtract*/
> > F: MdeModulePkg/Core/Dxe/
> > X: MdeModulePkg/Core/Dxe/Gcd/
> > X: MdeModulePkg/Core/Dxe/Mem/
> > F: MdeModulePkg/Core/DxeIplPeim/
> > F: MdeModulePkg/Core/Pei/
> > X: MdeModulePkg/Core/Pei/Memory/
> > X: MdeModulePkg/Core/Pei/PciCfg2/
> > X: MdeModulePkg/Core/Pei/Reset/
> > X: MdeModulePkg/Core/Pei/StatusCode/
> > F: MdeModulePkg/Core/RuntimeDxe/
> > F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> > F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> > F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> > F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> > F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> > F: MdeModulePkg/Library/DxeSecurityManagementLib/
> > F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> > F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> >
> > Debug:
> > F: MdeModulePkg/*Debug*/
> > X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> > F: MdeModulePkg/Include/Guid/DebugMask.h
> > F: MdeModulePkg/Include/Library/DebugAgentLib.h
> > F: MdeModulePkg/Include/Ppi/Debug.h
> >
> > Decompress:
> > F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> > F: MdeModulePkg/Library/*Decompress*/
> >
> > Device:
> > F: MdeModulePkg/*Serial*/
> > X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> > F: MdeModulePkg/Bus/
> > X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> > X: MdeModulePkg/Bus/Pci/PciBusDxe/
> > X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> > F: MdeModulePkg/Include/*/*Ata*.h
> > F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> > F: MdeModulePkg/Include/*/*NvmExpress*.h
> > F: MdeModulePkg/Include/*/*SerialPort*.h
> > F: MdeModulePkg/Include/*/*SdMmc*.h
> > F: MdeModulePkg/Include/*/*Ufs*.h
> > F: MdeModulePkg/Include/*/*Usb*.h
> > F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> > F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> > F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> > F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> > F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
> >
> > Disk:
> > F: MdeModulePkg/Universal/Disk/
> >
> > EBC:
> > F: MdeModulePkg/Include/*/*Ebc*.h
> > F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> > F: MdeModulePkg/Universal/EbcDxe/
> >
> > Firmware Update:
> > F: MdeModulePkg/*Capsule*/
> > F: MdeModulePkg/Include/*/*Capsule*.h
> > F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> > F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> > F: MdeModulePkg/Include/Protocol/EsrtManagement.h
> > F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> > F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
> > F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> > F: MdeModulePkg/Universal/Esrt*/
> >
> > Graphic:
> > F: MdeModulePkg/*Logo*/
> > F: MdeModulePkg/Include/*/*Logo*.h
> > F: MdeModulePkg/Include/Library/BmpSupportLib.h
> > F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
> > F: MdeModulePkg/Library/BaseBmpSupportLib/
> > F: MdeModulePkg/Library/FrameBufferBltLib/
> > F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> >
> > HII/UI:
> > F: MdeModulePkg/*FileExplorer*/
> > F: MdeModulePkg/*Hii*/
> > F: MdeModulePkg/*Ui*/
> > F: MdeModulePkg/Application/BootManagerMenuApp/
> > F: MdeModulePkg/Include/*/*FileExplorer*.h
> > F: MdeModulePkg/Include/*/*FormBrowser*.h
> > F: MdeModulePkg/Include/*/*Hii*.h
> > F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
> > F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
> > F: MdeModulePkg/Library/CustomizedDisplayLib/
> > F: MdeModulePkg/Universal/DisplayEngineDxe/
> > F: MdeModulePkg/Universal/SetupBrowserDxe/
> >
> > IPMI:
> > F: MdeModulePkg/Include/*/*Ipmi*.h
> > F: MdeModulePkg/Library/*Ipmi*/
> >
> > Memory Management:
> > F: MdeModulePkg/*Mem*/
> > F: MdeModulePkg/Core/Dxe/Gcd/
> > F: MdeModulePkg/Include/*/*Mem*.h
> > F: MdeModulePkg/Include/*/*IoMmu*.h
> >
> > PCD:
> > F: MdeModulePkg/Application/DumpDynPcd/
> > F: MdeModulePkg/Include/*/*Pcd*.h
> > F: MdeModulePkg/Universal/PCD/
> >
> > PCI Bus:
> > F: MdeModulePkg/*PciHostBridge*/
> > F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> > F: MdeModulePkg/Bus/Pci/PciBusDxe/
> > F: MdeModulePkg/Core/Pei/PciCfg2/
> > F: MdeModulePkg/Include/Library/PciHostBridgeLib.h
> > F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
> >
> > Performance:
> > F: MdeModulePkg/Include/*/*Perf*.h
> > F: MdeModulePkg/Library/*Perf*/
> >
> > Reset:
> > F: MdeModulePkg/*Reset*/
> > F: MdeModulePkg/Include/*/*Reset*.h
> >
> > S3:
> > F: MdeModulePkg/*LockBox*/
> > F: MdeModulePkg/Include/*/*BootScript*.h
> > F: MdeModulePkg/Include/*/*LockBox*.h
> > F: MdeModulePkg/Include/*/*S3*.h
> > F: MdeModulePkg/Library/*S3*/
> >
> > SMBIOS:
> > F: MdeModulePkg/Universal/Smbios*/
> >
> > SMM:
> > F: MdeModulePkg/*Smi*/
> > F: MdeModulePkg/*Smm*/
> > F: MdeModulePkg/Include/*/*Smi*.h
> > F: MdeModulePkg/Include/*/*Smm*.h
> >
> > Status Code:
> > F: MdeModulePkg/*StatusCode*/
> > F: MdeModulePkg/Include/*/*StatusCode*.h
> >
> > Variable:
> > F: MdeModulePkg/*Var*/
> > F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h
> > F: MdeModulePkg/Include/*/*Var*.h
> > F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h
> > F: MdeModulePkg/Include/Protocol/SwapAddressRange.h
> > F: MdeModulePkg/Universal/FaultTolerantWrite*/
> >
> > Misc:
> > F: MdeModulePkg/Application/HelloWorld/
> > F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h
> > F: MdeModulePkg/Include/Guid/MtcVendor.h
> > F: MdeModulePkg/Include/Guid/ZeroGuid.h
> > F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
> > F: MdeModulePkg/Include/Library/PlatformHookLib.h
> > F: MdeModulePkg/Include/Library/RecoveryLib.h
> > F: MdeModulePkg/Include/Library/SortLib.h
> > F: MdeModulePkg/Include/Library/TpmMeasurementLib.h
> > F: MdeModulePkg/Include/Protocol/Dpc.h
> > F: MdeModulePkg/Include/Protocol/LoadPe32Image.h
> > F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
> > F: MdeModulePkg/Include/Protocol/Print2.h
> > F: MdeModulePkg/Library/BaseHobLibNull/
> > F: MdeModulePkg/Library/BasePlatformHookLibNull/
> > F: MdeModulePkg/Library/BaseSortLib/
> > F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/
> > F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/
> > F: MdeModulePkg/Library/PeiRecoveryLibNull/
> > F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> > F: MdeModulePkg/Library/TpmMeasurementLibNull/
> > F: MdeModulePkg/Library/UefiSortLib/
> > F: MdeModulePkg/Universal/DevicePathDxe/
> > F: MdeModulePkg/Universal/DriverHealthManagerDxe/
> > F: MdeModulePkg/Universal/DriverSampleDxe/
> > F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/
> > F: MdeModulePkg/Universal/LegacyRegion2Dxe/
> > F: MdeModulePkg/Universal/Metronome/
> > F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
> > F: MdeModulePkg/Universal/PrintDxe/
> > F: MdeModulePkg/Universal/RegularExpressionDxe/
> > F: MdeModulePkg/Universal/TimestampDxe/
> > F: MdeModulePkg/Universal/WatchdogTimerDxe/
> >
> >
> > Best Regards,
> > Hao Wu
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-07-17 1:47 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-10 8:06 [RFC] Fine-grained review ownership for MdeModulePkg Wu, Hao A
2019-06-11 9:51 ` Leif Lindholm
2019-06-11 15:41 ` Laszlo Ersek
2019-06-19 5:09 ` Wu, Hao A
2019-06-19 9:35 ` Leif Lindholm
2019-06-20 15:43 ` [edk2-devel] " Laszlo Ersek
2019-06-24 1:16 ` Wu, Hao A
2019-06-24 20:29 ` Laszlo Ersek
2019-06-24 22:58 ` Yao, Jiewen
2019-07-16 13:53 ` Leif Lindholm
2019-07-17 1:47 ` Wu, Hao A
2019-06-20 22:23 ` rebecca
2019-06-21 0:11 ` Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox