public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v3 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
@ 2019-07-16 16:53 rebecca
  2019-07-16 16:53 ` [PATCH v3 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: rebecca @ 2019-07-16 16:53 UTC (permalink / raw)
  To: devel, lersek, bob.c.feng, liming.gao, leif.lindholm,
	michael.d.kinney, afish
  Cc: Rebecca Cran

This is a (very minor) optimization: `pwd` runs the command (even as a
built-in), whereas $PWD simply evaluates the value of the variable.

ALso, modern scripts should generally use $(...) to run commands,
instead of `...`.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
 edksetup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edksetup.sh b/edksetup.sh
index 12a3e26a67..ab58fe4a6e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -71,7 +71,7 @@ function SetWorkspace()
   #
   # Set $WORKSPACE
   #
-  export WORKSPACE=`pwd`
+  export WORKSPACE=$PWD
   return 0
 }
 
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-16 16:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-16 16:53 [PATCH v3 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command rebecca
2019-07-16 16:53 ` [PATCH v3 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
2019-07-16 16:53 ` [PATCH v3 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed rebecca
2019-07-16 16:53 ` [PATCH v3 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing rebecca

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox