From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: bsdio.com, ip: 65.103.231.193, mailfrom: rebecca@bsdio.com) Received: from muon.bsdio.com (muon.bsdio.com [65.103.231.193]) by groups.io with SMTP; Tue, 16 Jul 2019 09:55:43 -0700 Received: from muon.bsdio.com (localhost [127.0.0.1]) by muon.bsdio.com (Postfix) with ESMTP id 264D4802C1; Tue, 16 Jul 2019 10:56:03 -0600 (MDT) Received: from muon.bsdio.com ([127.0.0.1]) by muon.bsdio.com (muon.bsdio.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mRZTUMV1ciUT; Tue, 16 Jul 2019 10:56:02 -0600 (MDT) Received: from photon.int.bluestop.org (unknown [10.0.10.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by muon.bsdio.com (Postfix) with ESMTPSA; Tue, 16 Jul 2019 10:56:02 -0600 (MDT) From: rebecca@bsdio.com To: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com, liming.gao@intel.com, michael.d.kinney@intel.com, afish@apple.com, zhijux.fan@intel.com, leif.lindholm@linaro.org Cc: Rebecca Cran Subject: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command Date: Tue, 16 Jul 2019 10:55:33 -0600 Message-Id: <20190716165538.57960-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a (very minor) optimization: `pwd` runs the command (even as a built-in), whereas $PWD simply evaluates the value of the variable. ALso, modern scripts should generally use $(...) to run commands, instead of `...`. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 12a3e26a67..ab58fe4a6e 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -71,7 +71,7 @@ function SetWorkspace() # # Set $WORKSPACE # - export WORKSPACE=3D`pwd` + export WORKSPACE=3D$PWD return 0 } =20 --=20 2.22.0