From: rebecca@bsdio.com
To: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com,
liming.gao@intel.com, michael.d.kinney@intel.com,
afish@apple.com, zhijux.fan@intel.com, leif.lindholm@linaro.org
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH v4 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed
Date: Tue, 16 Jul 2019 10:55:35 -0600 [thread overview]
Message-ID: <20190716165538.57960-3-rebecca@bsdio.com> (raw)
In-Reply-To: <20190716165538.57960-1-rebecca@bsdio.com>
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 752e47e7cb..76c8d7916e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -199,7 +199,7 @@ do
break
;;
esac
- I=$(($I - 1))
+ I=$((I - 1))
done
if [ $I -gt 0 ]
--
2.22.0
next prev parent reply other threads:[~2019-07-16 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 16:55 [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command rebecca
2019-07-16 16:55 ` [PATCH v4 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
2019-07-16 16:55 ` rebecca [this message]
2019-07-16 16:55 ` [PATCH v4 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing rebecca
2019-07-16 16:55 ` [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions rebecca
2019-07-16 18:48 ` Laszlo Ersek
2019-07-16 16:55 ` [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements rebecca
2019-07-17 2:56 ` [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command Liming Gao
2019-07-22 22:16 ` [edk2-devel] " Laszlo Ersek
2019-07-22 22:52 ` rebecca
2019-07-23 8:51 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716165538.57960-3-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox