From: rebecca@bsdio.com
To: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com,
liming.gao@intel.com, michael.d.kinney@intel.com,
afish@apple.com, zhijux.fan@intel.com, leif.lindholm@linaro.org
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.
Date: Tue, 16 Jul 2019 10:55:37 -0600 [thread overview]
Message-ID: <20190716165538.57960-5-rebecca@bsdio.com> (raw)
In-Reply-To: <20190716165538.57960-1-rebecca@bsdio.com>
On Linux, "whereis" matches python3, python3.7, as well as
man pages, libs etc. While on macOS it only matches the specified
name, and so misses python3.7. Improve this by looping over
potential version numbers and seeing if such a binary exists and
can be executed.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
edksetup.sh | 44 +++++++-------------------------------------
1 file changed, 7 insertions(+), 37 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index 06d2f041e6..5b90e55ed8 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -107,24 +107,10 @@ function SetupEnv()
function SetupPython3()
{
- if [ $origin_version ];then
- origin_version=
- fi
- for python in $(whereis python3)
- do
- python=$(echo $python | grep "[[:digit:]]$" || true)
- python_version=${python##*python}
- if [ -z "${python_version}" ] || (! command -v $python >/dev/null 2>&1);then
- continue
- fi
- if [ -z $origin_version ];then
- origin_version=$python_version
- export PYTHON_COMMAND=$python
- continue
- fi
- if [[ "$origin_version" < "$python_version" ]]; then
- origin_version=$python_version
+ for ((pyver=15; pyver>=1; --pyver)); do
+ if python=$(command -v python3.$pyver); then
export PYTHON_COMMAND=$python
+ break
fi
done
return 0
@@ -146,27 +132,11 @@ function SetupPython()
SetupPython3
fi
- if [ $PYTHON3_ENABLE ] && [ $PYTHON3_ENABLE != TRUE ]
- then
- if [ $origin_version ];then
- origin_version=
- fi
- for python in $(whereis python2)
- do
- python=$(echo $python | grep "[[:digit:]]$" || true)
- python_version=${python##*python}
- if [ -z "${python_version}" ] || (! command -v $python >/dev/null 2>&1);then
- continue
- fi
- if [ -z $origin_version ]
- then
- origin_version=$python_version
- export PYTHON_COMMAND=$python
- continue
- fi
- if [[ "$origin_version" < "$python_version" ]]; then
- origin_version=$python_version
+ if [ -n "$PYTHON3_ENABLE" ] && [ "$PYTHON3_ENABLE" != "TRUE" ]; then
+ for ((pyver=10; pyver>=1; --pyver)); do
+ if python=$(command -v python2.$pyver); then
export PYTHON_COMMAND=$python
+ break
fi
done
return 0
--
2.22.0
next prev parent reply other threads:[~2019-07-16 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 16:55 [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command rebecca
2019-07-16 16:55 ` [PATCH v4 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
2019-07-16 16:55 ` [PATCH v4 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed rebecca
2019-07-16 16:55 ` [PATCH v4 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing rebecca
2019-07-16 16:55 ` rebecca [this message]
2019-07-16 18:48 ` [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions Laszlo Ersek
2019-07-16 16:55 ` [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements rebecca
2019-07-17 2:56 ` [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command Liming Gao
2019-07-22 22:16 ` [edk2-devel] " Laszlo Ersek
2019-07-22 22:52 ` rebecca
2019-07-23 8:51 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716165538.57960-5-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox