From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: bsdio.com, ip: 65.103.231.193, mailfrom: rebecca@bsdio.com) Received: from muon.bsdio.com (muon.bsdio.com [65.103.231.193]) by groups.io with SMTP; Tue, 16 Jul 2019 09:55:47 -0700 Received: from muon.bsdio.com (localhost [127.0.0.1]) by muon.bsdio.com (Postfix) with ESMTP id AD814802E7; Tue, 16 Jul 2019 10:56:07 -0600 (MDT) Received: from muon.bsdio.com ([127.0.0.1]) by muon.bsdio.com (muon.bsdio.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QqYLChZyp0D4; Tue, 16 Jul 2019 10:56:07 -0600 (MDT) Received: from photon.int.bluestop.org (unknown [10.0.10.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by muon.bsdio.com (Postfix) with ESMTPSA; Tue, 16 Jul 2019 10:56:07 -0600 (MDT) From: rebecca@bsdio.com To: devel@edk2.groups.io, lersek@redhat.com, bob.c.feng@intel.com, liming.gao@intel.com, michael.d.kinney@intel.com, afish@apple.com, zhijux.fan@intel.com, leif.lindholm@linaro.org Cc: Rebecca Cran Subject: [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements Date: Tue, 16 Jul 2019 10:55:38 -0600 Message-Id: <20190716165538.57960-6-rebecca@bsdio.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190716165538.57960-1-rebecca@bsdio.com> References: <20190716165538.57960-1-rebecca@bsdio.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable There are unquoted variables that remain: only the ones considered most important to fix (in terms of potential bugs) were changed in this commit. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index 5b90e55ed8..9dc6913ad2 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -118,7 +118,7 @@ function SetupPython3() =20 function SetupPython() { - if [ $PYTHON_COMMAND ] && [ -z $PYTHON3_ENABLE ];then + if [ -n "$PYTHON_COMMAND" ] && [ -z "$PYTHON3_ENABLE" ];then if ( command -v $PYTHON_COMMAND >/dev/null 2>&1 );then return 0 else @@ -127,7 +127,7 @@ function SetupPython() fi fi =20 - if [ $PYTHON3_ENABLE ] && [ $PYTHON3_ENABLE =3D=3D TRUE ] + if [ "$PYTHON3_ENABLE" =3D=3D "TRUE" ] then SetupPython3 fi --=20 2.22.0