public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>,
	Chandana Kumar <chandana.c.kumar@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: [Patch v3 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiServices table
Date: Wed, 17 Jul 2019 09:58:58 +0800	[thread overview]
Message-ID: <20190717015900.29224-1-eric.dong@intel.com> (raw)

V3 Changes:
1. Remove IsCpuFeatureMatch function.

V2 Changes:
1. Revert IsBitMaskMatchCheck change which is not correct.
2. refine some variable name.

v1 changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972

AP calls CollectProcessorData() to collect processor info.
CollectProcessorData function finally calls PcdGetSize function to get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS which caused ASSERT. 
This patch serial fixes the issue and enhances the related code to avoid later report this issue again.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Chandana Kumar <chandana.c.kumar@intel.com>
Cc: Star Zeng <star.zeng@intel.com>


Dong, Eric (1):
  UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD.

Eric Dong (1):
  UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiServices table.

 .../CpuFeaturesInitialize.c                   |  77 +++++++------
 .../RegisterCpuFeatures.h                     |  10 +-
 .../RegisterCpuFeaturesLib.c                  | 102 +++++++-----------
 3 files changed, 87 insertions(+), 102 deletions(-)

-- 
2.21.0.windows.1


             reply	other threads:[~2019-07-17  1:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17  1:58 Dong, Eric [this message]
2019-07-17  1:58 ` [Patch v3 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiServices table Dong, Eric
2019-07-17  1:59 ` [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD Dong, Eric
2019-07-17  3:40   ` Zeng, Star
2019-07-17  3:57     ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190717015900.29224-1-eric.dong@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox