From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=lg8Oa2AJ; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Wed, 17 Jul 2019 04:44:13 -0700 Received: by mail-wr1-f67.google.com with SMTP id 31so24501287wrm.1 for ; Wed, 17 Jul 2019 04:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T7DyiHF9MBZcZdCtxHz8DCQk5XClmruCoWz0XspOji8=; b=lg8Oa2AJo+lVlTL+XcH4+Q6C6tmk1cWqaFvdZ1DKbbXy2iUsOPM1gNRX0hYbztAIni h/Ei0FdyelGBGtDpxhCdcyTuP0Ae7STtIw8MIyg/IDy8eQoU3+x6gZBXLi7R4ArM/qMm CyrZyzIGdskHghdFT1zYalcJkTEOf6ju3RWcSLRugXgxPZ9U/gqxX72dk0Dn4AyTqHP8 zPlCd6TjK0+fRkcNJxtIVCKiYJxLzKgyqDxiawWuihv+7TeiT8HBvNvaG4752xkB6Vem wlOgK51DPabc3CgX3JR0wpYOaVu4kBd/tANvjS3A0mPYamFHO9VS3r98XA6cIRYnzfbX oAYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T7DyiHF9MBZcZdCtxHz8DCQk5XClmruCoWz0XspOji8=; b=BCFSmmrM8iGEJs90EJnn6rvndITbKoOLiWyR0cEyrSpkArGvmSuBIPMvDqhaY02A+G UYBktP+Afm7HmzX5u+cQjxyYBhfNm9L1qOGi1rOZQVhS8HJkICsnOFROk4mnD2FyR5c0 3O9PEUcJhOOe2odtXqpOzoqFlU24oC6PZD596Jmg2rUBzuQM10o8DO5SsuBJL4Ipho/4 OBCDty/b6V58OFtOJ1KsZAi8Acs7wm6qnNzOfGtwMtE2MYsXVDtINcw6dC+m+my5nFj5 uaW6uVllVQgBD0XXUueyeCtdqEEU2Lg+3hpmxMP4scS1WtGTW+NazVqJTnTVhSdfcwsn da/A== X-Gm-Message-State: APjAAAUiFADZ/pVK1R1QTLcIopjuRplxn7N5AQWd9M0+n7riY7UuQK9B e44AJXbxQluK28ipIUGP+5ozHA== X-Google-Smtp-Source: APXvYqyCPC4kYXDpiSFnci71K/N+VIqknE9evLtvHfJQT3fYAHjLFn7jFSqof3krOGRVbO++OPakEA== X-Received: by 2002:adf:ea8b:: with SMTP id s11mr41993733wrm.100.1563363851505; Wed, 17 Jul 2019 04:44:11 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v23sm20978198wmj.32.2019.07.17.04.44.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 17 Jul 2019 04:44:10 -0700 (PDT) Date: Wed, 17 Jul 2019 12:44:08 +0100 From: "Leif Lindholm" To: "Ooi, Tzy Way" Cc: "devel@edk2.groups.io" , Ard BieSheuvel , "Kinney, Michael D" , "Loh, Tien Hock" Subject: Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver Message-ID: <20190717114408.GA2712@bivouac.eciton.net> References: <20190708070507.2493-1-tzy.way.ooi@intel.com> <20190711164316.o7cioscn55mv6bqi@bivouac.eciton.net> <5F1105621EDF844291AF8B109E27C06D34D2E67E@PGSMSX109.gar.corp.intel.com> <20190716172227.wuczvla67izm7ccr@bivouac.eciton.net> <5F1105621EDF844291AF8B109E27C06D34D2EC31@PGSMSX109.gar.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <5F1105621EDF844291AF8B109E27C06D34D2EC31@PGSMSX109.gar.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Tzy Way, On Wed, Jul 17, 2019 at 09:25:49AM +0000, Ooi, Tzy Way wrote: > Ya. I am on Linux. I managed to replicated the warning that you have > provided in the previous email thread by using the gcc 8.3. Excellent. > Currently, I'm looking at the compiler warning/error. While I am > fixing the issue when compiling the source code, I encountered > another issue where the compiler complain "undefined reference to > __stack_chk_fail". I check from google and it can be solved by > setting -fnostack-protector. Hence, I would like to ask if is it ok > to set this to the CFLAGs for the compiler? We don't need that workaround - since we have a proper way of handling it in MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf Adding a NULL resolution to the appropriate [LibraryClasses] section in the .dsc should resolve this for you. See (for example) edk2/EmbeddedPkg/EmbeddedPkg.dsc for guidance. Best Regards, Leif