From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=H1ou1eD/; spf=pass (domain: arm.com, ip: 40.107.8.55, mailfrom: krzysztof.koch@arm.com) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.55]) by groups.io with SMTP; Thu, 18 Jul 2019 05:32:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZrvpGkTbRlcLvbx1qNMerOczRdfnkXpsT0Rq5tDp92T6JjoHRALD/Y81jz9K3jthfyNSil1ybjZy0i92PJrRufw5GvQD8uo5TyKexkm3ya0GVVmeVmsAHWS0DzR+EhRLj7dJOqJPw3rgLKkR1ReMgtOClW6CkRG34CnkevGCSmffeYvo7YmX25bNX+kehSYndFnLbApk4ED7GAucHrIzKZi61NNAj1JXF+itc/lOWuqbnQpa28FLOC8jTmoVSaka5Ffx+gS2nUruTCFXWgPIS8KDTD8QDnCZj/uu0ddV29Lvc43OYSkVmWeeK8aOm7HE6nfhB6Ib55gelxQnTZ9TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gtoe/8Eer41zMQbE12cgXWkt/E45M3JkVKMfEheKHxA=; b=D1LHIKhHRVN9J1GLBEVm+Hu084zxPcdY/SoU7BsgGOaUUmFhYZlZQQ6Q8hmW9E7qY+tlua9mTpDNDfpnf06A6SArcAGMEVMq9q6MjZqnRrtsxHqtsRGz3QmFpEftu6ZvlNUdizSBUQhZIqr1seRxFK0mh6OmoyYU1c4s8Ta7gQqF/K9ZXUFBjBvJHhW9FqH5I/gPqI2lkE49rt1Woyrwb1ammTbw1mLx2rtvW6btc4R1d3nrt20gFouSwZOFLrtx+kTiDaced3567IKkUocWXXla6zfhLHJwH0YjxNs8Pn6tRlOsd1SK8Hw7Fbp/C7+QOkPsxEG/I/WFGF+OAqVQjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=temperror (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com;dmarc=temperror action=none header.from=arm.com;dkim=none (message not signed);arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gtoe/8Eer41zMQbE12cgXWkt/E45M3JkVKMfEheKHxA=; b=H1ou1eD/nRsSRecah4oaW1KfT36LOcunysO+1cxhC6FTvYSiGA+xtRvwFZDEKTUlAUbEwItz5wOV40wRHgWwXNZut2+zegiEvRvJgj8s6mn10yjN5GUwg3ZvjsrM9koTcKCyYVU0oRhDC7/rjQKsxDvlTcqvr/KkBRrdRyBm074= Received: from VE1PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:803:104::41) by DB8PR08MB4956.eurprd08.prod.outlook.com (2603:10a6:10:e0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.11; Thu, 18 Jul 2019 12:31:56 +0000 Received: from AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::200) by VE1PR08CA0028.outlook.office365.com (2603:10a6:803:104::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2073.14 via Frontend Transport; Thu, 18 Jul 2019 12:31:55 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT020.mail.protection.outlook.com (10.152.16.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2052.18 via Frontend Transport; Thu, 18 Jul 2019 12:31:54 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Thu, 18 Jul 2019 12:31:51 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Thu, 18 Jul 2019 12:31:51 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [PATCH v1 3/6] ShellPkg: acpiview: RSDP: Make code consistent with other parsers Date: Thu, 18 Jul 2019 13:31:39 +0100 Message-ID: <20190718123142.5696-4-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20190718123142.5696-1-krzysztof.koch@arm.com> References: <20190718123142.5696-1-krzysztof.koch@arm.com> Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(376002)(136003)(39860400002)(2980300002)(199004)(189003)(70586007)(305945005)(5660300002)(2906002)(11346002)(446003)(63350400001)(63370400001)(476003)(2616005)(54906003)(1076003)(70206006)(486006)(4326008)(126002)(14444005)(53416004)(2351001)(426003)(336012)(86362001)(48376002)(6916009)(47776003)(186003)(44832011)(50226002)(356004)(8676002)(6666004)(68736007)(76176011)(81156014)(53936002)(8936002)(7696005)(51416003)(478600001)(316002)(16586007)(50466002)(81166006)(36756003)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB8PR08MB4956;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abba7cbd-6716-4593-45e8-08d70b7bead1 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328);SRVR:DB8PR08MB4956; X-MS-TrafficTypeDiagnostic: DB8PR08MB4956: X-Microsoft-Antispam-PRVS: NoDisclaimer: True X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 01026E1310 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: DA10viekm2nuSfDY0l28rbmHY/faU7bdO+kVkoIrnN7dauhq/IUrNR480sZ41tZoM6QEz2Oh7cRkyzdid+FashuwPz73sx0j4Jwo4xiBef49KNPqN6FTJwzsfiUJlUyBr7SNUzL6wBC89QcyLCYopjGfLhlTq9YgR3Pu9z3VMgtDG2YRiSJm6X9ksiSxUcC4a5s6dD4NHiZxv/M0LJtS2fUZ5f8qahQny12z75Dsb/3ib9cwroXSk7klf4ZSJDw/7yeMby8FZRNKw56tyec+QJ5iW9Cou5wcP7V19uctzO3PmhLP5fxAXY7rmpcihzU9yDxs97AUFC3uYscrRQ8Ep4mbfFOWIFr4E4wnUaahv6veYRcakbI73LaQadn8DJ+eBLDcdixMaDR8S09s/KiY9c+V6Msuy9ex2PXK5CaTrQQ= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2019 12:31:54.3369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abba7cbd-6716-4593-45e8-08d70b7bead1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4956 Content-Type: text/plain List ParseAcpi() function arguments one per line in order to make this function call consistent with ParseAcpi() calls in other ACPI table parsers. Also, notify the user that XsdtAddress value of 0 results in RSDP parsing being terminated and that the XSDT table will not be processed. This effectively means that no more ACPI tables will be parsed because of this RSDP table content error. Signed-off-by: Krzysztof Koch --- Notes: v1: - minor code style enhancements [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c index 586de7cbfb12f856c0c735b6e295c1cc32eb2ceb..bceda91386b5c070b81b2beac83e2a0102a9b64e 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c @@ -159,7 +159,14 @@ ParseAcpiRsdp ( VerifyChecksum (TRUE, Ptr, AcpiTableLength); } - ParseAcpi (Trace, 0, "RSDP", Ptr, AcpiTableLength, PARSER_PARAMS (RsdpParser)); + ParseAcpi ( + Trace, + 0, + "RSDP", + Ptr, + AcpiTableLength, + PARSER_PARAMS (RsdpParser) + ); // This code currently supports parsing of XSDT table only // and does not parse the RSDT table. Platforms provide the @@ -167,7 +174,7 @@ ParseAcpiRsdp ( // Therefore the RSDT should not be used on ARM platforms. if ((*XsdtAddress) == 0) { IncrementErrorCount (); - Print (L"ERROR: XSDT Pointer is not set.\n"); + Print (L"ERROR: XSDT Pointer is not set. RSDP parsing aborted.\n"); return; } -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'