From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=lJgAh/jR; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Fri, 19 Jul 2019 02:00:32 -0700 Received: by mail-wm1-f67.google.com with SMTP id x15so28034783wmj.3 for ; Fri, 19 Jul 2019 02:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u/ag4kzmtWbdFtf8NAWpjPQSB2Oh440NB17JTBYxDGE=; b=lJgAh/jRhmDBk785FAQgf5l1wn3cC5Lu3jCWfORFhFodLlz9FVQ2Pj0JXp3/BCSTBR 7Qwe7lA0QIlhRSvWdYGF27zb8HmMIA2Ra7pvRzzOHMINGdJg/OJb0qWIsfmk60YESUd2 /dhUdCPdMh31Ah/b88xQVyE6DNbC99hYWDO1ZbX/XHd2NjRWEB7MClpINo/3jdZNTQk1 hlogFivQZG4JmQm1RTFExhKGgZKj7OJYm11Y3MAwAd7gSkAfVlQiWIi7PD4bVy2pBAVx 212HkRDNM3TKcrckp8+FBwRUJRhwBTf/Ehj/n2w6lzkTJuc+uWODYv+ZCH3kWv6M45dz pQRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u/ag4kzmtWbdFtf8NAWpjPQSB2Oh440NB17JTBYxDGE=; b=fIMlAWrlRTeNRccf8fxMO25RdNf0bM0eyu9Q0Ur8VYqnCodxkq4aYCylmaNvqte6Yo BpbqhwM4/3epAAbt6RqrrriJOn5uS2wOI2ENgSCiGjxZdzc5h7arZHcKTo2lEqs01bMk ktkEzOvenVbeJb9mxu+J8XLkpLJ+rYEKGGZb9SS53vjt//QxdX6Bn8Nzk//GL73rGE7y IozdbQ2Z0qPZStP+rmiUxeMfWlIxYmtj123Zu9vupKfOaqFzv7gSPagk3m2yG3CHUJZj QqEOh1UyPGcT8TL+fzF9tAmKfm7wVURvz5TNdEFQtAWEuOxZ8itnx3oWWxeRJHrsKBsA xy/Q== X-Gm-Message-State: APjAAAXdce14EzAyMQrdsug5vm4+llm+2wUcC209oYytgNrKKaabdldh hc8J5bwZ4SUNNYs8hFz1PhM2kQ== X-Google-Smtp-Source: APXvYqze81M9L+pZIYjOFNOukC7EOuFJeAmrf9DY0qINofje+hsoGII/b651CSZhbEeHxrQOZdFgug== X-Received: by 2002:a1c:2314:: with SMTP id j20mr46807177wmj.152.1563526830438; Fri, 19 Jul 2019 02:00:30 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e6sm30226330wrw.23.2019.07.19.02.00.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 02:00:29 -0700 (PDT) Date: Fri, 19 Jul 2019 10:00:28 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: edk2-devel-groups-io , Andrew Fish , Michael D Kinney , Philippe Mathieu-Daude , Bob Feng , Liming Gao , "Wu, Hao A" , Stefan Berger Subject: Re: [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) Message-ID: <20190719090027.GP2712@bivouac.eciton.net> References: <20190712170128.6495-1-leif.lindholm@linaro.org> <6799dc07-2d8c-0ad1-286e-23b2b68c413a@redhat.com> MIME-Version: 1.0 In-Reply-To: <6799dc07-2d8c-0ad1-286e-23b2b68c413a@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 18, 2019 at 11:17:30PM +0200, Laszlo Ersek wrote: > On 07/18/19 18:27, Leif Lindholm wrote: > > Laszlo, Hao - I have prepared a set for pushing as below. > > > > (Reviewed-by: Leif Lindholm for all of your > > patches.) > > *But*, I need a review from Bob and/or Liming before I push the final one: > > "BaseTools: add GetMaintainer.py script" - > > https://edk2.groups.io/g/devel/message/43666 > > > > I have verified reviews/acks by all affected reviewers, except for Stefan > > Berger for Ovmf TCG/TPM2. > > Stefan's R-b has arrived as well: > > http://mid.mail-archive.com/7201b3fb-d84b-30e0-61c8-bf9bb9defa7a@linux.ibm.com > > So, I agree, those four patches regarding OvmfPkg reviewership are now > fully approved. > > Please pick up Phil's feedback as well. > > > While I would prefer to have that too, this is a file format shift - not a > > change in responsibility areas. > > Laszlo, do you agree? > > If so, I can push 1-7/8 as is. > > See above -- then I'm OK. 1-7/8 pushed as: 3dafa0382286..296c908c6968 Will push the GetMaintainer.py script once approved by BaseTools maintainers. Thanks! / Leif > Thank you! > Laszlo > > > > > / > > Leif > > > > Hao A Wu (1): > > Maintainers.txt: Fine-grained review ownership for MdeModulePkg > > > > Laszlo Ersek (4): > > Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" > > Maintainers.txt: split out section "OvmfPkg: Xen-related modules" > > Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related > > modules" > > Maintainers.txt: split out section "OvmfPkg: CSM modules" > > > > Leif Lindholm (3): > > Maintainers.txt: update for filesystem area descriptions > > Maintainers.txt: add wildcard path association for Arm/AArch64 > > BaseTools: add GetMaintainer.py script > > > > > > On Fri, 12 Jul 2019 at 18:01, Leif Lindholm > > wrote: > > > >> Changes are available directly from: > >> > >> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-v1 > >> > >> This series adds new tags to the Maintainers.txt format, making it possible > >> to describe which filesystem paths are looked after by which people, and > >> hence automating the extraction of a list over who should be cc:d on a > >> patch > >> submission. > >> > >> Remaining shorcomings in v1: > >> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines > >> interspersed with the tag lines. These lines will be removed as areas of > >> responsibility is formally rewritten as tags. > >> - * Wildcard support is not fully filesystem compliant except in first or > >> last position in the file pattern (it translates as regex .* elsewhere). > >> However, actual cases of mismatch are expected to be unlikely, and they > >> will be false positives rather than false negatives - so I think this is > >> good enough at least for a start. > >> - Provides no information of why certain people or meiling lists were > >> picked - it just bundles all recipients up, deduplicates them, and > >> prints them out. > >> > >> Using the script requires the gitpython module to be installed. > >> > >> Worthwhile mentioning outside the ChangeLog is the added -l flag, which > >> lets you look up what a given path would return in the way of matches. > >> E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" > >> would return: > >> --- > >> Non/Existing/Path > >> "Non/Existing/Path": no maintainers found, looking for default > >> Andrew Fish > >> Laszlo Ersek > >> Leif Lindholm > >> Michael D Kinney > >> devel@edk2.groups.io > >> --- > >> > >> This series would still result in GetMaintainers.py missing some > >> maintainers/reviewers due to descriptions in prose rather than filename > >> patterns. My preferred way of handling this would be to merge 1-2/3 as > >> soon as found acceptable, following up and merging patches to update > >> ArmVirtPkg, MdeModulePkg, and OvmfPkg, and finally once the file is > >> consistent, proceed to merge 3/3. > >> > >> Changelog: > >> v1: > >> - Rebase to current Maintainers.txt. > >> - Fix typos and missed bits in Maintainers.txt. > >> - Get rid of the magic '' filename, let the single-char '*' > >> wildcard resolve this (_using_ the magic '' filename in the > >> script, but treating it as if it was a file in the top-level directory). > >> - Add -l flag to script to look up which maintainers would be returned for > >> a given path (which need not exist). > >> rfc: > >> - Split patches up > >> - one for new Maintainers.txt format (documentation and F: tags). > >> - one for adding a new wilcards responsibility area for */Arm, */AArch64 > >> - one for the GetMaintainer.py script > >> - Reworked wildcard handling based on Laszlo's explanation > >> - Trailing / covers everything under that directory > >> - Trailing * does not cover subdirectories > >> - Added support for X: tag > >> - Added support for magic '' pathname > >> - Also prints mailing list addresses for matching L: tags > >> > >> Cc: Andrew Fish > >> Cc: Laszlo Ersek > >> Cc: Michael D Kinney > >> Cc: Bob Feng > >> Cc: Liming Gao > >> Cc: Philippe Mathieu-Daude > >> Cc: "Wu, Hao A" > >> > >> Leif Lindholm (3): > >> Maintainers.txt: update for filesystem area descriptions > >> Maintainers.txt: add wildcard path association for Arm/AArch64 > >> BaseTools: add GetMaintainer.py script > >> > >> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ > >> Maintainers.txt | 54 ++++++++ > >> 2 files changed, 244 insertions(+) > >> create mode 100644 BaseTools/Scripts/GetMaintainer.py > >> > >> -- > >> 2.20.1 > >> > >> > > >