From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [edk2-platforms: PATCH v2 0/2] Platform/RPi3: Improve boot order and add custom freqs
Date: Fri, 19 Jul 2019 12:36:10 +0100 [thread overview]
Message-ID: <20190719113610.GT2712@bivouac.eciton.net> (raw)
In-Reply-To: <20190704165120.8800-1-pete@akeo.ie>
On Thu, Jul 04, 2019 at 05:51:18PM +0100, Pete Batard wrote:
> v2 to:
> - Break a long line PlatformBm.c.
> - Use a BOOLEAN for the SkipTurbo parameter.
> - Keep already defined gRaspberryPiTokenSpaceGuid.### values as they are.
>
> Note that, as opposed to what was discussed, EFI_VARIABLE_RUNTIME_ACCESS was
> not removed because doing so effectively prevents the custom value to be
> applied in the firmware menu. Without EFI_VARIABLE_RUNTIME_ACCESS you will get
> the following notice when trying to save your changes:
>
> Submit Fail For Form: Chipset Configuration.
> Press D(d) to discard changes for this form, Press G(g) to go to this form
>
> So I guess EFI_VARIABLE_RUNTIME_ACCESS applies to more than OS access.
As I told Pete offline, I wanted to dig into why the RUNTIME_ACCESS
was required, but haven't found the time. And the patches have been
waiting long enough.
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e80b3f804cae..3542dfdecab1.
Thanks!
/
> Regards,
>
> /Pete
>
> Pete Batard (2):
> Platform/RPi3: Set the boot option of UEFI Shell as non-active
> Platform/Rpi3: Add custom CPU frequency support
>
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13 +++++++++++-
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf | 1 +
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxeHii.uni | 4 ++++
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxeHii.vfr | 22 ++++++++++++++++++++
> Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++--
> Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h | 3 ++-
> Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c | 3 ++-
> Platform/RaspberryPi/RPi3/RPi3.dec | 1 +
> Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
> Platform/RaspberryPi/RPi3/Readme.md | 6 +++---
> 10 files changed, 52 insertions(+), 8 deletions(-)
>
> --
> 2.21.0.windows.1
>
prev parent reply other threads:[~2019-07-19 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 16:51 [edk2-platforms: PATCH v2 0/2] Platform/RPi3: Improve boot order and add custom freqs Pete Batard
2019-07-04 16:51 ` [edk2-platforms: PATCH v2 1/2] Platform/RPi3: Set the boot option of UEFI Shell as non-active Pete Batard
2019-07-04 16:51 ` [edk2-platforms: PATCH v2 2/2] Platform/Rpi3: Add custom CPU frequency support Pete Batard
2019-07-19 11:36 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719113610.GT2712@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox