From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ORmTb1I1; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Fri, 19 Jul 2019 04:36:14 -0700 Received: by mail-wm1-f66.google.com with SMTP id s15so7352077wmj.3 for ; Fri, 19 Jul 2019 04:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GIYkuFKMa5UeSeXfZXeDQJ4LY0djOuGUGCT0dyS4pU0=; b=ORmTb1I1yRQQY7ge5xz8eBAH9CbOWK4in5X9Va6Jmo8QJsQHOaFlIV8b6xvm/oDvCr r4JbrBg5U6qpVvu4xweUrXE8MZneNt7FdCyV6EviENYG6GnZM4UgXta7WfqGpj5I1cZ1 HPO8EFw9KoI8WSZclYwyZUG2aVKAwwlo8MpFJtPFckwrhem86TKUT+wc64fgmd+GiMBH EmfrJz3f0nKUSxXU6V9gg4xhcCftqpRRFHmgrX6QnWnyFu7EIiZ8lIV57CJ6ip+kVDJy ug4T2NtPpF6O5ryRx9Jzh1v60h2y3fdsycjAbY24bhs4fhcJDsFl0ed4SMOjPxVrsAPC 4Ziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GIYkuFKMa5UeSeXfZXeDQJ4LY0djOuGUGCT0dyS4pU0=; b=T0ggZjXDeQY2Zw7Tt+HBteAqFOfm2CsJLcg+RxlvNhFSMHehs20H8tf+hW7+fL376J 27Poc7OgJybPj6eqh8+j8+/9Ey7+aRRP4pPGGOW8b1La9gPNBvjOTcKprZuEIvNKrgdZ WC1d+t5oZM+mS8iCzafJZx9CygCsX6Sn72qOZ810NqQODdOR5OyysecX/khfd0dlfs9E rFHRbJeLV6RjXkE83FAqSid2T7PZAxIbzOQStQL6L2vq4Kec6fBSg5Z+GVYMCzajPRuH RHz/CZEhtcg8JDttmPpk0TT/UB4aQHiJXxKBplQu8vRkKN65oIvHZZDIKFV3bejYH+DZ THKg== X-Gm-Message-State: APjAAAX5n/M3yvIwv12yOHTGczKrWBizdel/RHhDOYj2MbT6Uz4J+f1W P6XtfQwrtMYGHUCtf9VGImSEHQ== X-Google-Smtp-Source: APXvYqwM1N9HisegEGNqV4ytxLGYAxQpAxzSLRFLT0N084/kgPsdkrx8dvYNIax53nnnNxe1o3Znxw== X-Received: by 2002:a7b:c104:: with SMTP id w4mr49838139wmi.42.1563536172978; Fri, 19 Jul 2019 04:36:12 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h1sm20749480wrt.20.2019.07.19.04.36.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 04:36:12 -0700 (PDT) Date: Fri, 19 Jul 2019 12:36:10 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms: PATCH v2 0/2] Platform/RPi3: Improve boot order and add custom freqs Message-ID: <20190719113610.GT2712@bivouac.eciton.net> References: <20190704165120.8800-1-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20190704165120.8800-1-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 04, 2019 at 05:51:18PM +0100, Pete Batard wrote: > v2 to: > - Break a long line PlatformBm.c. > - Use a BOOLEAN for the SkipTurbo parameter. > - Keep already defined gRaspberryPiTokenSpaceGuid.### values as they are. > > Note that, as opposed to what was discussed, EFI_VARIABLE_RUNTIME_ACCESS was > not removed because doing so effectively prevents the custom value to be > applied in the firmware menu. Without EFI_VARIABLE_RUNTIME_ACCESS you will get > the following notice when trying to save your changes: > > Submit Fail For Form: Chipset Configuration. > Press D(d) to discard changes for this form, Press G(g) to go to this form > > So I guess EFI_VARIABLE_RUNTIME_ACCESS applies to more than OS access. As I told Pete offline, I wanted to dig into why the RUNTIME_ACCESS was required, but haven't found the time. And the patches have been waiting long enough. For the series: Reviewed-by: Leif Lindholm Pushed as e80b3f804cae..3542dfdecab1. Thanks! / > Regards, > > /Pete > > Pete Batard (2): > Platform/RPi3: Set the boot option of UEFI Shell as non-active > Platform/Rpi3: Add custom CPU frequency support > > Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13 +++++++++++- > Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf | 1 + > Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxeHii.uni | 4 ++++ > Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxeHii.vfr | 22 ++++++++++++++++++++ > Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++-- > Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h | 3 ++- > Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c | 3 ++- > Platform/RaspberryPi/RPi3/RPi3.dec | 1 + > Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + > Platform/RaspberryPi/RPi3/Readme.md | 6 +++--- > 10 files changed, 52 insertions(+), 8 deletions(-) > > -- > 2.21.0.windows.1 >