From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=LJRlSSt5; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Fri, 19 Jul 2019 04:53:27 -0700 Received: by mail-wr1-f68.google.com with SMTP id n9so32052844wru.0 for ; Fri, 19 Jul 2019 04:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RHNgVEjtfqrnnIi9O+L6WAGYWAPIA0gb2qT9QVw+qjw=; b=LJRlSSt5NrMSUnAAc4xay6/LYl3t+6+787P5FXczQMRGeiT4X5taXwuAe+ExMq5cU0 a1J862y2LmCWlwNoMnJXpKll3/u4l3KgPft1R4+lft8w1Qz7zMyE9ygdeb65VqFmhlx2 VGSx26GwfAc/RAHBJtppshfXwg59eiaqGAjo321KBn6fTaO4PN4bemNzt/UD+MKh0kka PVDbrz1NG0ld9uILRd1TjcrJXF/v3KeJ+g+EAmUXkMKNOpe4xgx6aqIy/mtOxsRGGRdi L1h9NSlWo/t1FERmx7B16sdWTjwxsBijsjkyg2iJFBvVrtqwjjg/VzzYnhN7Gjv9unU1 vZgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RHNgVEjtfqrnnIi9O+L6WAGYWAPIA0gb2qT9QVw+qjw=; b=pvPHKnWgTDNwMoHSCJVKMH43glY0u+on45McefAoN+4cRmjBRLoNzgYlx+6dI3QK30 loVv74Xuww2vKp8/zZmEuGhhChXqG58S9Fc/oThfbOFNpxokdgdbApjPbs7gTkK+LLeH HaCFAgHc70vivK79mEqynhayB5ae6z/eYAxwfpXYeS8XrkWCl8rzO66xE1auBdjcEH8s ms4HrwNyKGs3QlXiB/RRPFqiq1WrNZzJPNtOBbhRAjZxuKP5yb92NwTS0jCyKpZBYdNa 2HPGtlN5Zclkny0gQ93sAtKzgP3TtuH7VrQcxFkMSTt9mOKrpbSUX6ylmS1kaWwCdNkP FJnQ== X-Gm-Message-State: APjAAAVDT1c1OF02PulvUUwrVgEKXvXGjvog78qrMqEuhEqN14jLqFL/ Sb/+In/SnstuvxGlCvQGjBDYCQ== X-Google-Smtp-Source: APXvYqx9NredWIelly4HKhE3kBQI6JtWiJ30cil+uDyM9+c+f+gr/GE4YtfbXI0UZvaMNp1U4qinVQ== X-Received: by 2002:a5d:46cf:: with SMTP id g15mr58274381wrs.93.1563537205868; Fri, 19 Jul 2019 04:53:25 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y16sm29301992wrw.33.2019.07.19.04.53.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 04:53:25 -0700 (PDT) Date: Fri, 19 Jul 2019 12:53:23 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe Message-ID: <20190719115323.GU2712@bivouac.eciton.net> References: <20190717114645.7776-1-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20190717114645.7776-1-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Pete, On Wed, Jul 17, 2019 at 12:46:42PM +0100, Pete Batard wrote: > Networking applications (e.g. iPXE) might experience failures when submitting > a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out > when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal > error. > > With these patches, iPXE is able to successfully download a 128MB test file > via HTTP. The patches look good, and I don't mind you upstreaming Michael's code, *but* I don't want patches submitted with anyone other than the contributor's Signed-off-by:. (It's the equivalent of saying "Yeah, Michael says he's OK with https://developercertificate.org/, and of no actual use.) (If patches are modified after contribution, but before being pushed, then then additional contributions can be reflected with additional Signed-off-bys. Make sense?) The From: tag ensures he still retains authorship. Are you OK with me dropping Michael's Signed-off-by before pushing? Best Regards, Leif > Michael Brown (3): > Platform/RPi3: Use Wait4Bit return value consistently > Platform/RPi3: Gracefully disable USB channel after a timeout > Platform/RPi3: Reduce debug noise when using a USB network device > > Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 44 +++++++++++--------- > 1 file changed, 25 insertions(+), 19 deletions(-) > > -- > 2.21.0.windows.1 >