From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.155.175, mailfrom: anthony.perard@citrix.com) Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by groups.io with SMTP; Fri, 19 Jul 2019 09:42:26 -0700 Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: vFwHmBIakjm0A0YiaMgZ/vDbzZGbZU/e2K0YFCrPZ8WPckhEE2NHdF2tZ3m/a0K0TU4/IMW0c7 CIshkBrHdqP6yq0A4hxTvVWQ4f5HueP/RwItYe8L7FMGJ3DcLlQ10zMMgnKdr9pBxB1VJlc0dn BKSPSFz/UPFKCvnFqNHKgwv64HnQGrzY3okl9QDbge3H8kLCPD4qMOBQPVxcp4R/hvl7+XyC1u KSc7Q2DB0FzzwUp6xeR/bXufBidQmN7C2P7Kjtkqmt3l4vrgHwE39KTnhFYN2KQ5ScmFtRnTvy htQ= X-SBRS: 2.7 X-MesageID: 3284133 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,283,1559534400"; d="scan'208";a="3284133" Date: Fri, 19 Jul 2019 17:42:23 +0100 From: "Anthony PERARD" To: Laszlo Ersek CC: , , Ard Biesheuvel , Jordan Justen , Julien Grall , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests Message-ID: <20190719164223.GE1208@perard.uk.xensource.com> References: <20190704144233.27968-1-anthony.perard@citrix.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Fri, Jul 05, 2019 at 02:21:13PM +0200, Laszlo Ersek wrote: > The patches on the list are malformed. They have > > Content-Transfer-Encoding: quoted-printable > > which is fine, in itself; however, they have CR-CR-LF line terminators. > > For example, from the first patch: > > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/L= > ibrary/ResetSystemLib/ResetSystemLib.inf > index 7c44f99a5c..2f24dac87f 100644 > --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > @@ -30,4 +30,5 @@ [Packages] > [LibraryClasses]=0D=0D > DebugLib=0D=0D > IoLib=0D=0D > + PciLib=0D=0D > TimerLib=0D=0D > > Note "=0D=0D". > > Now, if I try to apply this full set with git-am like that, the first > patch in the series applies, but the second still fails: > > > error: corrupt patch at line 23 > > Patch failed at 0002 OvmfPkg: Create platform OvmfXen > > Based on the email headers, the "iphmx.com" references suggest (via a > google search) "Cisco's Ironport Cloud email service". > > I think that email service (MTA) is broken. > > If you could use a different MTA (or get the current one fixed), that > would be helpful. (Yes, yes: if the edk2 project didn't use CRLF line > terminators, that would be *even more* helpful.) I'm not sure that using a different MTA is going to help. I don't think I can find a patch on the list that I can apply (without using unix2dos). I did send a patch to my gmail address, and it looks fine (=0D in the expected places and nowhere else). So maybe when a patch is sent through a mailing list, some more formating is done? Anyway, can I try sending patch encoded in base64 instead of quoted-printable? That would probably work better. I found <20190704040731.5303-1-glin@suse.com> on the list that is base64 encoded, that I can easily apply and patchew too. -- Anthony PERARD