public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Michael Brown <mcb30@ipxe.org>
Cc: devel@edk2.groups.io, Pete Batard <pete@akeo.ie>,
	ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe
Date: Fri, 19 Jul 2019 17:43:52 +0100	[thread overview]
Message-ID: <20190719164352.GX2712@bivouac.eciton.net> (raw)
In-Reply-To: <8eff7a87-d428-dc50-d043-937378237e85@ipxe.org>

On Fri, Jul 19, 2019 at 04:22:10PM +0100, Michael Brown wrote:
> On 19/07/2019 12:53, Leif Lindholm wrote:
> > The patches look good, and I don't mind you upstreaming Michael's
> > code, *but* I don't want patches submitted with anyone other than the
> > contributor's Signed-off-by:. (It's the equivalent of saying "Yeah,
> > Michael says he's OK with https://developercertificate.org/, and of no
> > actual use.)
> 
> Sorry; this is almost certainly my fault.

Well, there is nothing *wrong* with that - only there is no value in
second-hand signed-off-bys.

> My Signed-off-by was present in
> the original patches that I sent to Pete, and Pete kindly offered to take
> care of upstreaming the patches for me.  For the avoidance of any doubt: I
> definitely agree to the statements in https://developercertificate.org/.

Glad to hear it :)
This means I *could* have included them, but...

> I am happy for you to either drop or retain my Signed-off-by before pushing,
> as you see fit.

...to reduce confusion, I dropped them before pushing - but you're
still set as the author.

If in future you contribute directly yourself, please keep the
Signed-off-by in.

Best Regards,

Leif

  reply	other threads:[~2019-07-19 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 11:46 [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe Pete Batard
2019-07-17 11:46 ` [edk2-platforms: PATCH 1/3] Platform/RPi3: Use Wait4Bit return value consistently Pete Batard
2019-07-17 11:46 ` [edk2-platforms: PATCH 2/3] Platform/RPi3: Gracefully disable USB channel after a timeout Pete Batard
2019-07-17 11:46 ` [edk2-platforms: PATCH 3/3] Platform/RPi3: Reduce debug noise when using a USB network device Pete Batard
2019-07-19 11:53 ` [edk2-platforms: PATCH 0/3] Platform/RPi3: Improve timeout handling in DwUsbHostDxe Leif Lindholm
2019-07-19 15:22   ` [edk2-devel] " Michael Brown
2019-07-19 16:43     ` Leif Lindholm [this message]
2019-07-19 15:40   ` Pete Batard
2019-07-19 16:35     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719164352.GX2712@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox