From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhichao.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Sun, 21 Jul 2019 23:58:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jul 2019 23:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,294,1559545200"; d="scan'208";a="188545637" Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga001.fm.intel.com with ESMTP; 21 Jul 2019 23:58:16 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jaben Carsey , Ray Ni , Oleksiy Subject: [PATCH V2] ShellPkg/Pci.c: Update supported link speed to PCI4.0 Date: Mon, 22 Jul 2019 14:57:54 +0800 Message-Id: <20190722065756.18856-1-zhichao.gao@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1955 Refer PCI express base specification Reversion 4.0, Version 1.0, Table 7-32, Supported Link Speeds Vector bit 3 indicate the speed 16 GT/s. Add it to shell command 'pci ...'. Change the MaxLinkSpeed other values' result from 'Unknown' to 'Reserved'. Cc: Jaben Carsey Cc: Ray Ni Cc: Oleksiy Signed-off-by: Zhichao Gao --- V2: Update the copyright. And remind that this patch isn't update the code to match PCI 5.0. I didn't find edk repo update the related code to PCI 5.0. Please let me know if there is a requirement to update this code to PCI 5.0. ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c index ba9caa7743..b58ce3c2f0 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c @@ -1,7 +1,7 @@ /** @file Main file for Pci shell Debug1 function. - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.
(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
(C) Copyright 2016 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -4515,8 +4515,11 @@ ExplainPcieLinkCap ( case 3: MaxLinkSpeed = L"8.0 GT/s"; break; + case 4: + MaxLinkSpeed = L"16.0 GT/s"; + break; default: - MaxLinkSpeed = L"Unknown"; + MaxLinkSpeed = L"Reserved"; break; } ShellPrintEx (-1, -1, @@ -4672,6 +4675,9 @@ ExplainPcieLinkStatus ( case 3: CurLinkSpeed = L"8.0 GT/s"; break; + case 4: + CurLinkSpeed = L"16.0 GT/s"; + break; default: CurLinkSpeed = L"Reserved"; break; -- 2.21.0.windows.1