From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jian Wang <jian.j.wang@intel.com>, Ting Ye <ting.ye@intel.com>
Subject: Re: [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]
Date: Mon, 22 Jul 2019 11:37:55 +0100 [thread overview]
Message-ID: <20190722103755.GA11541@bivouac.eciton.net> (raw)
In-Reply-To: <20190719164319.9070-1-lersek@redhat.com>
On Fri, Jul 19, 2019 at 06:43:15PM +0200, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: internal_hdrs
>
> The BaseTools build feature introduced for TianoCore#1804 / in commit
> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF
> file", 2019-06-10) logs some (non-fatal) warnings about unlisted
> internal header files. List those files explicitly.
Urgh.
Yeah. I'm still not super comfortable with this duplication of
dependency scanning (as discussed in
https://edk2.groups.io/g/devel/topic/31866190), but I have to confess
I also don't really care enough to do anything about it.
So, while I'm tempted to keep the warnings around as a reminder, if
you prefer to get rid of them - for the pat of the series I was cc:d on:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
/
Leif
next prev parent reply other threads:[~2019-07-22 10:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 16:43 [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] Laszlo Ersek
2019-07-19 16:43 ` [PATCH 1/4] ArmPkg: list module-internal header files in INF [Sources] Laszlo Ersek
2019-07-19 16:43 ` [PATCH 2/4] ArmPlatformPkg: " Laszlo Ersek
2019-07-19 17:13 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-19 16:43 ` [PATCH 3/4] CryptoPkg/BaseCryptLib: " Laszlo Ersek
2019-07-19 17:09 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-22 5:48 ` Wang, Jian J
2019-07-19 16:43 ` [PATCH 4/4] EmbeddedPkg: " Laszlo Ersek
2019-07-19 17:08 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-22 10:37 ` Leif Lindholm [this message]
2019-07-22 17:32 ` [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] Laszlo Ersek
2019-07-22 18:47 ` [edk2-devel] " Michael D Kinney
2019-07-22 22:56 ` Laszlo Ersek
2019-07-23 9:06 ` Leif Lindholm
2019-07-23 11:54 ` Laszlo Ersek
2019-07-23 12:19 ` Leif Lindholm
2019-07-23 13:02 ` Liming Gao
2019-07-23 13:25 ` Leif Lindholm
2019-07-23 17:23 ` Laszlo Ersek
2019-07-24 15:17 ` Liming Gao
2019-07-24 17:00 ` Leif Lindholm
2019-07-25 19:27 ` Laszlo Ersek
2019-07-23 17:02 ` Laszlo Ersek
2019-07-22 22:30 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722103755.GA11541@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox