From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.145.142, mailfrom: anthony.perard@citrix.com) Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by groups.io with SMTP; Mon, 22 Jul 2019 06:49:20 -0700 Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: RmJsBKw4dyOtrQllUt5jvWkH8wWETWB4nYKXwqdOXFmmB/uks7G+tZyWUUT97zQAch6Ed1U8N9 2xEt+5FcJSUyQgoeYzHF6BzWVXnD0/EGzPZkIdGvkrEbWAah5RwYNFfTf+MDxkgzp3JOh3N8Bh aQ45mIhfvyTugVvS+8gm45ntHNQcfEq86d7RQcff3hVG80Y89cybGdSBMPrUqucF/1ahVTvcNd yBzivegatLTv7ovfwI0hP6ITbXehsCY0xv+AbFkp5hgepE7dvhCIC8iufufKs9XcmJdc8UmHhW n8M= X-SBRS: 2.7 X-MesageID: 3299383 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,295,1559534400"; d="scan'208";a="3299383" Date: Mon, 22 Jul 2019 14:49:12 +0100 From: "Anthony PERARD" To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: , , Ard Biesheuvel , Jordan Justen , Laszlo Ersek , Julien Grall , "Andrew Cooper" Subject: Re: [PATCH v3 09/35] OvmfPkg/OvmfXen: use a TimerLib instance that depends only on the CPU Message-ID: <20190722134912.GF1208@perard.uk.xensource.com> References: <20190704144233.27968-1-anthony.perard@citrix.com> <20190704144233.27968-10-anthony.perard@citrix.com> <20190715142219.m2t67v2dcyabqp2p@MacBook-Air-de-Roger.local> MIME-Version: 1.0 In-Reply-To: <20190715142219.m2t67v2dcyabqp2p@MacBook-Air-de-Roger.local> User-Agent: Mutt/1.12.1 (2019-06-15) Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jul 15, 2019 at 04:22:19PM +0200, Roger Pau Monné wrote: > On Thu, Jul 04, 2019 at 03:42:07PM +0100, Anthony PERARD wrote: > > ACPI Timer does not work in a PVH guest, but local APIC works on both > > This is not accurate. It's not that the ACPI timer doesn't work, it's > just that it's not present. The PM_TMR_BLK should be set to 0 to > indicate the lack of PM timer support, or else there's something > broken. I'll reword that first sentence. OVMF doesn't look at the PM_TMR_BLK value when initializing that timer, it only looks at the PCI host bridge device ID because OVMF is built with QEMU in mind and there are only two possibles choices, QEMU is running with a piix or q35 machine type, I think. > > PVH and HVM. > > > > Note that the use of SecPeiDxeTimerLibCpu might be an issue with a > > driver of type DXE_RUNTIME_DRIVER. I've attemptde to find out which of > ^ attempted > > the DXE_RUNTIME_DRIVER uses the TimerLib at runtime. I've done that by > > replacing the TimerLib evaluation in > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] by a different one and > > check every module that uses it (with the --report-file=report build > ^ checking > > option). > > > > ResetSystemRuntimeDxe is calling the TimerLib API at runtime to do the > > operation "EfiResetCold", so this may never complete if the OS have > > disabled the Local APIC Timer. > > Thanks, Roger. Thanks, -- Anthony PERARD