From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.87, mailfrom: glin@suse.com) Received: from m4a0041g.houston.softwaregrp.com (m4a0041g.houston.softwaregrp.com [15.124.2.87]) by groups.io with SMTP; Tue, 23 Jul 2019 01:53:10 -0700 Received: FROM m4a0041g.houston.softwaregrp.com (15.120.17.146) BY m4a0041g.houston.softwaregrp.com WITH ESMTP; Tue, 23 Jul 2019 08:53:01 +0000 Received: from M4W0335.microfocus.com (2002:f78:1193::f78:1193) by M4W0334.microfocus.com (2002:f78:1192::f78:1192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 23 Jul 2019 08:52:18 +0000 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (15.124.8.11) by M4W0335.microfocus.com (15.120.17.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Tue, 23 Jul 2019 08:52:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdfuyul34ha8L86s6Jc48NcAUb4FuVx9v1ez4tcvsSpiuf+mJQH8TiBqokxFKFqD79gdtmyLv+/GDlQG+IFDMs79anOOCoYZM4FmPiXDNSWlA+DophFUHYtpwP6gR/PjJCVKcN0I2ooxGDqDc0nqgjLG8PIv79bhSBUoM871j+0GGOKxlGZjoh65nZvtsAdSiuNuGupwxGO/NEPZS983xW+GWyevph48hsdhJZYDm8XvXOeWB4VaDrtEs31DXUFPRyLvlt93aol56ZGDp83oEJoJUOcM0IUUGBN8i+JfxRzyXClCMnaLxtuoHiCO1DK5TCJ9hRQ/QlEhq2f5ypWzQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W9r8GGRNCGaHuqW4BXS5sIlWEVV4yLWfFC0wEiFd7qc=; b=XeLyPjyFFp5HPPOpakD+Hs0ji+/4fhWSNW7tk+ZnqRXW1+UgSkkuEzB7kxj3jQvfKZGYz4kkXDFbifH8m+jAiyKjHqWBfptCpuvs2xfhd0ufsXJnxlKY3X8p1nZLZNw4LlCvmsmBfM8mqr7y2g8Pb2Od9BP6+/lh9xmhA4ICNH3W3sR+R5an5v2xmo0ukMKqiFGW36SiN5rvYjOtSxN+AWp1Y1E21kg3MgNbgupFfwPtnpgpu4KtPW8xcXtm9lSiU4ES/MNmOPrZrZXf/KAJQDxZorpjBzCp21n3Ph2+OxV2M8rYVwd79Ngm83ZZGrmAszID25DTC3Ox3j0wI3Ud/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3147.namprd18.prod.outlook.com (10.255.172.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 08:52:17 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 08:52:17 +0000 From: "Gary Lin" To: Michael D Kinney CC: "devel@edk2.groups.io" , Yi Qian , Zailiang Sun Subject: Re: [edk2-platforms Patch V3 07/12] Vlv2Tbl2DevicePkg/EfiRegTableLib: Use S3_BOOT_SCRIPT_LIB_WIDTH Thread-Topic: [edk2-platforms Patch V3 07/12] Vlv2Tbl2DevicePkg/EfiRegTableLib: Use S3_BOOT_SCRIPT_LIB_WIDTH Thread-Index: AQHVQOEhp5OeDIXlE0usIekujfkLBKbX5guA Date: Tue, 23 Jul 2019 08:52:17 +0000 Message-ID: <20190723085205.GG4466@GaryWorkstation> References: <20190722225859.24724-1-michael.d.kinney@intel.com> <20190722225859.24724-8-michael.d.kinney@intel.com> In-Reply-To: <20190722225859.24724-8-michael.d.kinney@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LNXP265CA0003.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::15) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3862518-1e83-41da-047a-08d70f4b10ba x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3147; x-ms-traffictypediagnostic: DM6PR18MB3147: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:935; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(7916004)(39860400002)(376002)(366004)(346002)(396003)(136003)(189003)(199004)(81156014)(486006)(8676002)(102836004)(76176011)(305945005)(386003)(19627235002)(6916009)(7736002)(6506007)(8936002)(14454004)(26005)(6116002)(14444005)(256004)(52116002)(3846002)(478600001)(446003)(11346002)(186003)(54906003)(68736007)(33656002)(80792005)(4326008)(476003)(5660300002)(6512007)(229853002)(53936002)(66066001)(71190400001)(71200400001)(66476007)(64756008)(1076003)(66946007)(66446008)(66556008)(6246003)(25786009)(6436002)(81166006)(86362001)(33716001)(6486002)(99286004)(316002)(2906002)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3147;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IIzYscpBkAA4uFE6v0Vr5nGBVsMyTCBVbr+P4lEDIhC6txJCA8Fzxb8eh2M90/NuoSl3xcCnNrguZOFgQRvF2L1Z8PBSQLR6rDUfXP7qWqRGu2EaRpNgebAEeZdem4FJkdFuti9OyUzrIBDA7BdN7lheqZFtRKiU3F093cZ/JQPy+9S2mwSIEqjhzHG7wZns8kAIYq6jdqgUkIP3yYRkEgpbAevaMCBY/U0Y8mP1RjIK1iVR72q/TA0o2k5VFkqm+TBmaDs+Vs9IX4EpXe7ccnWdwVrm11Z6jvBKt9j3tq9ChifGA0CTT6NJ+Jxz27ZU1sBFo7z30fgZBpe7F29iUNNJ+SQVOCH+fTkfGwnNqINabMcFFaR/wzIKCtCpNIGF1sZ297ehdtbJoXunNS1rEAAMuV961AZNTjBsas/NwmQ= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e3862518-1e83-41da-047a-08d70f4b10ba X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 08:52:17.5013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3147 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2019 at 03:58:54PM -0700, Michael D Kinney wrote: > Update calls to S3BootScriptxxx() services to use type > S3_BOOT_SCRIPT_LIB_WIDTH instead of EFI_BOOT_SCRIPT_WIDTH. > Fixes XCODE5 build failures. >=20 Reviewed-by: Gary Lin > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../Library/EfiRegTableLib/EfiRegTableLib.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiR= egTableLib.c b/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiR= egTableLib.c > index d698f3ada9..8b16585337 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTable= Lib.c > +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTable= Lib.c > @@ -55,7 +55,7 @@ PciWrite ( > =20 > if (OPCODE_FLAGS (Entry->OpCode) & OPCODE_FLAG_S3SAVE) { > Status =3D S3BootScriptSavePciCfgWrite ( > - (EFI_BOOT_SCRIPT_WIDTH) (OPCODE_EXTRA_DATA (Entry->OpCode)= ), > + (S3_BOOT_SCRIPT_LIB_WIDTH) (OPCODE_EXTRA_DATA (Entry->OpCo= de)), > (UINT64) Entry->PciAddress, > 1, > &Entry->Data > @@ -111,7 +111,7 @@ PciReadModifyWrite ( > =20 > if (OPCODE_FLAGS (Entry->OpCode) & OPCODE_FLAG_S3SAVE) { > Status =3D S3BootScriptSavePciCfgReadWrite ( > - (EFI_BOOT_SCRIPT_WIDTH) (OPCODE_EXTRA_DATA (Entry->OpCode)= ), > + (S3_BOOT_SCRIPT_LIB_WIDTH) (OPCODE_EXTRA_DATA (Entry->OpCo= de)), > (UINT64) Entry->PciAddress, > &Entry->OrMask, > &Entry->AndMask > @@ -167,7 +167,7 @@ MemReadModifyWrite ( > =20 > if (OPCODE_FLAGS (Entry->OpCode) & OPCODE_FLAG_S3SAVE) { > Status =3D S3BootScriptSaveMemReadWrite ( > - (EFI_BOOT_SCRIPT_WIDTH) (OPCODE_EXTRA_DATA (Entry->OpCode)= ), > + (S3_BOOT_SCRIPT_LIB_WIDTH) (OPCODE_EXTRA_DATA (Entry->OpCo= de)), > Entry->MemAddress, > &Entry->OrMask, > &Entry->AndMask > --=20 > 2.21.0.windows.1 >=20 >=20