From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.87, mailfrom: glin@suse.com) Received: from m4a0041g.houston.softwaregrp.com (m4a0041g.houston.softwaregrp.com [15.124.2.87]) by groups.io with SMTP; Tue, 23 Jul 2019 01:55:54 -0700 Received: FROM m4a0041g.houston.softwaregrp.com (15.120.17.146) BY m4a0041g.houston.softwaregrp.com WITH ESMTP; Tue, 23 Jul 2019 08:55:44 +0000 Received: from M4W0335.microfocus.com (2002:f78:1193::f78:1193) by M4W0334.microfocus.com (2002:f78:1192::f78:1192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 23 Jul 2019 08:54:40 +0000 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (15.124.8.12) by M4W0335.microfocus.com (15.120.17.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Tue, 23 Jul 2019 08:54:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=czRpculW3wadu8pxULVsxQfKQ7oEUVGde2h6ZHrmuOe2W5VLJ3cvOVZyrzcP+6hEowSRzN38AbDCx7dblULjJUxXrxFADhKSp/ocHZ8q7m6IrZsxl0Mqf/FA4SEjiqTP0nTP4agWrH9ZfOeYgECNT+5KfYIbAX5jJpq8yw1GEaG2EnV9+9EXZ7EX134Z5HYm88FSlfRqjQjdsrsGqib2Y/YLAu/V/ge9odn8Z+EcmGplX1BVion8jgG3N4JfZ2TG9tg0Op/lptgedVdarCNoyZTJDIGwWsQ7nEGXCS8G7wS6BsgXQiC0gAIYO5/ja8Xc2aRCNdFZ/Eg8KFXuXRigDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MB31d83D7cx9G97W4j3uaovGROZOmlmGCDgbU/VEeBg=; b=CURPnmiZpzrCLeVWbvV9j6do8ueuMIih21wtUaLM4lPkrdYjhdhOjiK7BK0EFWPk6HymNIAjy+viAMR9ptCDRGb0WtreVZH3vI4yF6UFLL6ZOhhjToYQO/K9/DVSCSvy3G/ahQalT/CpWOnILRRGAoDfmUWzKApo3q721dIF6IpXpeWJCg9xHBh9jGqUEIJdxG/LY6FrAFQWzDHwOwhXJTQPcS0ViEdue/tStHFzV3oQjVJqSPEAgqebVDxrSQiY4JTQyw0LwWnL7tnVHJqKUoQPw89HO8hkeAczfh27JK3E49ja7XlmEQWjmNPSfvTTJ1UTgoWDMQcAftJoMlrgpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3147.namprd18.prod.outlook.com (10.255.172.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 08:54:39 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 08:54:39 +0000 From: "Gary Lin" To: Michael D Kinney CC: "devel@edk2.groups.io" , Yi Qian , Zailiang Sun Subject: Re: [edk2-platforms Patch V3 12/12] Vlv2TbltDevicePkg/PlatformDxe: Use S3BootScriptWidth enums Thread-Topic: [edk2-platforms Patch V3 12/12] Vlv2TbltDevicePkg/PlatformDxe: Use S3BootScriptWidth enums Thread-Index: AQHVQOEjbwVOwaYq6kuK4mnRt480aqbX5rmA Date: Tue, 23 Jul 2019 08:54:39 +0000 Message-ID: <20190723085431.GH4466@GaryWorkstation> References: <20190722225859.24724-1-michael.d.kinney@intel.com> <20190722225859.24724-13-michael.d.kinney@intel.com> In-Reply-To: <20190722225859.24724-13-michael.d.kinney@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR03CA0113.apcprd03.prod.outlook.com (2603:1096:203:b0::29) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f8cbe51-56ad-4f65-c8c6-08d70f4b6539 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3147; x-ms-traffictypediagnostic: DM6PR18MB3147: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(189003)(199004)(66946007)(1076003)(66556008)(66446008)(64756008)(66476007)(71190400001)(66066001)(53936002)(229853002)(6512007)(71200400001)(6246003)(99286004)(86362001)(33716001)(6486002)(9686003)(316002)(2906002)(6436002)(25786009)(81166006)(7736002)(6916009)(6506007)(386003)(19627235002)(8936002)(8676002)(102836004)(81156014)(486006)(76176011)(14454004)(305945005)(33656002)(54906003)(186003)(11346002)(68736007)(5660300002)(476003)(4326008)(80792005)(6116002)(26005)(14444005)(446003)(52116002)(256004)(478600001)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3147;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JzBqi6I/zWvS5SYIi+E+jBMTOuBMjyFeqZg2vYAKFLUvKHfBF0hPtDxuuB0/bySKewc4b9uYeu4SANH5AJSrUFPoSWfvoLW/bZmy3sXUppBgAqbTWOg045ODb7Xh9bftC8XQ4LpfNSQD8HElxw7r0Q6rbrgbgvVLK6RW9y6ohkX1DyxnZg9a0RDm8N9wZiYkqCbsXMe5m4aQ0o3Uxlmi6SXi82tCvtWl2dx49NUPd59m6kVmsQ9jN+9jlDl4srPzVhU96fMV6rs0gTKVfG/OUc/NliMVQdakTvx4HXQ/1TjOLOrxlwq+C+VJ3jYf0rXZiO+iC6SEplYqbxgVnpWi8daSy/ySACobejZRT81QPD6ESPZusafCjhA+cbnjvww30065OJUAPs7ttpK2vJt85rPkFzt7ZDylYpcSGP6dIkY= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3f8cbe51-56ad-4f65-c8c6-08d70f4b6539 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 08:54:39.2753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3147 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <8D33431BDF402D46992EB07CB3AA45C6@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2019 at 03:58:59PM -0700, Michael D Kinney wrote: > Update to use S3BootScriptWidth enum values instead of > EfiBootScriptWidth enum values when calling S3BootScriptLib > services. This fixes an XCODE5 build failure. >=20 Reviewed-by: Gary Lin > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../Intel/Vlv2TbltDevicePkg/PlatformDxe/Platform.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/Platform.c b/Pl= atform/Intel/Vlv2TbltDevicePkg/PlatformDxe/Platform.c > index 0bc3f44c49..d9782aafba 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/Platform.c > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/Platform.c > @@ -968,25 +968,25 @@ PchInitBeforeBoot() > // Saved SPI Opcode menu to fix EFI variable unable to write after S3 = resume. > // > S3BootScriptSaveMemWrite ( > - EfiBootScriptWidthUint32, > + S3BootScriptWidthUint32, > (UINTN)(SPI_BASE_ADDRESS + (R_PCH_SPI_OPMENU0))= , > 1, > (VOID *)(UINTN)(SPI_BASE_ADDRESS + (R_PCH_SPI_O= PMENU0))); > =20 > S3BootScriptSaveMemWrite ( > - EfiBootScriptWidthUint32, > + S3BootScriptWidthUint32, > (UINTN)(SPI_BASE_ADDRESS + (R_PCH_SPI_OPMENU1))= , > 1, > (VOID *)(UINTN)(SPI_BASE_ADDRESS + (R_PCH_SPI_O= PMENU1))); > =20 > S3BootScriptSaveMemWrite ( > - EfiBootScriptWidthUint16, > + S3BootScriptWidthUint16, > (UINTN)(SPI_BASE_ADDRESS + R_PCH_SPI_OPTYPE), > 1, > (VOID *)(UINTN)(SPI_BASE_ADDRESS + R_PCH_SPI_OP= TYPE)); > =20 > S3BootScriptSaveMemWrite ( > - EfiBootScriptWidthUint16, > + S3BootScriptWidthUint16, > (UINTN)(SPI_BASE_ADDRESS + R_PCH_SPI_PREOP), > 1, > (VOID *)(UINTN)(SPI_BASE_ADDRESS + R_PCH_SPI_PR= EOP)); > @@ -995,7 +995,7 @@ PchInitBeforeBoot() > // Saved MTPMC_1 for S3 resume. > // > S3BootScriptSaveMemWrite ( > - EfiBootScriptWidthUint32, > + S3BootScriptWidthUint32, > (UINTN)(PMC_BASE_ADDRESS + R_PCH_PMC_MTPMC1), > 1, > (VOID *)(UINTN)(PMC_BASE_ADDRESS + R_PCH_PMC_MT= PMC1)); > --=20 > 2.21.0.windows.1 >=20 >=20