From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.87, mailfrom: glin@suse.com) Received: from m4a0041g.houston.softwaregrp.com (m4a0041g.houston.softwaregrp.com [15.124.2.87]) by groups.io with SMTP; Tue, 23 Jul 2019 01:58:47 -0700 Received: FROM m4a0041g.houston.softwaregrp.com (15.120.17.146) BY m4a0041g.houston.softwaregrp.com WITH ESMTP; Tue, 23 Jul 2019 08:58:37 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M4W0334.microfocus.com (2002:f78:1192::f78:1192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 23 Jul 2019 08:57:19 +0000 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (15.124.72.12) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Tue, 23 Jul 2019 08:57:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EPoZTFY2A17UV+DyCB4kI8wFA/vVXHRGoxQKtKWjDoQzOBWdU7VLHOzj/TYcXo6DCg5ezuvAQScHEYlOUtagnYCmmDu9Rwm/jm3CZKlLYSJ7VOkYlylkfo0GR/2LngfB8ZMXqRyeBQFmCyFpdxA7YJl2GXMEGJuxEMELidSsws6eYOxmxmuh3Ojsso6IX4cGQYJRRtjr6jglUU05WGrVWY+OeFolM6Mx8ldnLy3v38z/iVJnPTKgTjdXgb3zTBPYVanR5fYTy2vy2YKTHCVU2DJMz/ggcHo+Ap7UR/irnHLBXswkLgGXTCHp1pcNycJ6gliBytP+jmi8GAuBTCMj9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R7SV0Sv63jhqsxoOvWDe5ffkLqWYMZbnjddgp/DXeOk=; b=Z0Am+mvFv5ZGjoLXC/p9Uh03umcnMuxJjrRESNBAxf2NeXt3LcSAWd64AufHJk4IEtDGYV9kNUyJVFsHanrax9INrDx5I6WMbdMl5hbjVx3aSd8jiuMsJCFehbUSmwS7VSp4c9+uSkMdLtf/rpeOkMvpFnrl69l6utgNuA0EZX05U0g/HkxI8ojo+YUCg+rzuNPPSDVBIyyLtu05l2IkRFEont+v1gKtlEZ8byvXChYvaY0WsIC9V7sB56hkIYHW0ytJvpHaoXBJKb8gK5ZCOpSrEk0H3qxS7f/tcmMvBLQXN5jL/r9mgPn5qv1y9dbmE5zZ394HUs3sW2QW8R3yEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3147.namprd18.prod.outlook.com (10.255.172.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 08:57:18 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 08:57:18 +0000 From: "Gary Lin" To: Michael D Kinney CC: "devel@edk2.groups.io" , Yi Qian , Zailiang Sun Subject: Re: [edk2-platforms Patch V3 00/12] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Thread-Topic: [edk2-platforms Patch V3 00/12] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Thread-Index: AQHVQOEdu0XW0lIfb0eBwT4wZE0FnKbX53cA Date: Tue, 23 Jul 2019 08:57:18 +0000 Message-ID: <20190723085710.GI4466@GaryWorkstation> References: <20190722225859.24724-1-michael.d.kinney@intel.com> In-Reply-To: <20190722225859.24724-1-michael.d.kinney@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR04CA0052.apcprd04.prod.outlook.com (2603:1096:202:14::20) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63459fee-bbdc-475d-4e4a-08d70f4bc419 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3147; x-ms-traffictypediagnostic: DM6PR18MB3147: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(189003)(199004)(66946007)(1076003)(66556008)(66446008)(64756008)(66476007)(71190400001)(66066001)(53936002)(229853002)(6512007)(71200400001)(6246003)(99286004)(86362001)(33716001)(6486002)(9686003)(316002)(2906002)(6306002)(6436002)(25786009)(81166006)(7736002)(6916009)(6506007)(966005)(386003)(19627235002)(8936002)(8676002)(102836004)(81156014)(486006)(76176011)(14454004)(305945005)(33656002)(54906003)(186003)(11346002)(68736007)(5660300002)(476003)(4326008)(80792005)(6116002)(26005)(14444005)(446003)(52116002)(256004)(478600001)(3846002)(21314003)(460985005);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3147;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gr9fhO1K6YTTN26mbTzQeRlDjAs4NQantL2yw6Jwpvepijk76edqT6BstTRvCdeB7rpC4lA6X1Zc0eRBuoUsK/A7L5/dY59AYPJz7ciRq0uokerdk4OW7Jd/DRCHxoK49/diHHhunyTWBJySwNKBPAgothOl7plPCH0/a+xCcJxOwJALT3v3G5YliPiMmFUH52WIW1/uG9wuNC9VY1lRMneUabb57ZLw4J2F7lMj1xKaYfHDPJPXlKUKpAKYlJ1ze27UyY+KSVQ9xLotnaf4crEgvs8C7BBOwdpfw0lfKXpAxHbrq79JnGzUQB8M0UFmuckioHfo6eSORMJDkJqeC7qBGM+OLUEgoisDRim79BsZdk2jbUlXNW+Q973hyn9XTUs0hoBIxrEthLcO23/i44REuCyYnlV/YF/ZK4h1TAA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 63459fee-bbdc-475d-4e4a-08d70f4bc419 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 08:57:18.4510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3147 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <83DBA7145E6CFB4E90E8EE65F1CC2CE0@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2019 at 03:58:47PM -0700, Michael D Kinney wrote: > New in V3 > --------- > * Fix Readme.md for Linux in PACKAGES_PATH setting and edksetup.sh invoca= tion. > * Remove non-ASCII characters from source files that is preventing build = report > generation on Linux systems. > * Fix XCODE5 build break in Vlv2TbltDevicePkg/Library/EfiRegTableLib due > to use of EFI_BOOT_SCRIPT_WIDTH instead of S3_BOOT_SCRIPT_LIB_WIDTH. > * Add missing #ifdef around InitializeSensorInfoVariable() in PlatformDxe= . > * Add XCODE5 specific DLINK_FLAGS for 4KB aligned sections. > * Remove extra sets of parenthesis in if statements to resolve XCODE5 > build failures. > * Move a local variable declaration structure init to a module global > variable to avoid use of memcpy() by XCODE5. > * Remove use of #ifdefs on __GNUC__ to make builds the same for all > toolchains. This resolves an XCODE5 build failure due to an unsupporte= d > pragma. > * Replace the use of EfiBootScriptWidth enum values with S3BootScriptWidt= h > enum values when calling S3BootScriptLib services. This resolves an > XCODE5 build failure. >=20 > New in V2 > ---------- > * Remove MANUFACTURING defaults from DSC file. They are the same as STAN= DARD > defaults, so there is not need to add a MANUFACTURING default section u= nless > there are differences. > * Update PlatformSetupDxe to return EFI_UNSUPPORTED from the RouteConfig(= ) and > ExtractConfig() services of the HII_CONFIG_ACCESS_PROTOCOL. >=20 > Branch for review: >=20 > https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Remove_FCE_B= AT_sh_V3 >=20 > Remove all BAT/sh scripts and use OS independent python scripts for PREBU= LD and > POSTBUILD operations and use standard EDK II build command to build Minno= wMax FW > images and capsules. >=20 > The use of FCE has also been removed and replaced with a Structured PCD. = The > default values for Setup forms are now in the file PlatformSetupDefaults.= dsc. >=20 > A regression bug introduced by a recent commit that broke the detection o= f the > BOOT_ON_FLASH_UPDATE boot mode has also been fixed. Capsules are detecte= d and > processed correctly again. >=20 It's nice to see those build scripts are unified. I've tested the gcc build and it works as expected. For those patches without my Reviewed-by, Tested-by: Gary Lin > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Gary Lin > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (12): > Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection > Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD > Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF files > Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python > Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to Python > Vlv2TbltDevicePkg: Remove non ASCII characters from source files > Vlv2Tbl2DevicePkg/EfiRegTableLib: Use S3_BOOT_SCRIPT_LIB_WIDTH > Vlv2TbltDevicePkg/PlatformDxe: Add missing #if > Vlv2TbltDevicePkg: Add XCODE5 4K alignment DLINK_FLAGS > Vlv2TbltDevicePkg: Fix XCODE5 build errors > Vlv2TbltDevicePkg: Remove __GNUC__ specific #ifdefs > Vlv2TbltDevicePkg/PlatformDxe: Use S3BootScriptWidth enums >=20 > .../AcpiPlatform/AcpiPlatform.c | 15 +- > Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe | Bin 499712 -> 0 bytes > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat | 118 -- > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 100 -- > Platform/Intel/Vlv2TbltDevicePkg/FCE.exe | Bin 632832 -> 0 bytes > .../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 - > .../Capsule/GenerateCapsule/GenCapsuleAll.py | 397 +++++ > .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 33 - > .../GenerateCapsule/GenCapsuleMinnowMax.bat | 131 -- > .../GenerateCapsule/GenCapsuleMinnowMax.sh | 59 - > .../GenCapsuleMinnowMaxRelease.bat | 131 -- > .../GenCapsuleMinnowMaxRelease.sh | 64 - > .../GenerateCapsule/GenCapsuleSampleColor.bat | 137 -- > .../GenerateCapsule/GenCapsuleSampleColor.sh | 70 - > .../Feature/Capsule/GenerateCapsule/Lvfs.ddf | 14 - > .../LvfsGenCapsuleMinnowMax.bat | 139 -- > .../LvfsGenCapsuleMinnowMaxRelease.bat | 139 -- > .../LvfsGenCapsuleSampleColor.bat | 145 -- > .../GenerateCapsule/template.metainfo.xml | 27 - > .../SystemFirmwareDescriptor.aslc | 83 -- > .../SystemFirmwareDescriptor.inf | 40 - > .../SystemFirmwareDescriptorPei.c | 60 - > .../SystemFirmwareUpdateConfig.ini | 66 - > .../SystemFirmwareUpdateConfigGcc.ini | 66 - > .../Library/EfiRegTableLib/EfiRegTableLib.c | 6 +- > .../BoardClkGens/BoardClkGens.c | 8 - > .../PciPlatform/PciPlatform.c | 2 +- > .../Vlv2TbltDevicePkg/PlatformCapsule.dsc | 39 - > .../Vlv2TbltDevicePkg/PlatformCapsule.fdf | 52 - > .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc | 38 - > .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf | 52 - > .../Vlv2TbltDevicePkg/PlatformDxe/Platform.c | 10 +- > .../Vlv2TbltDevicePkg/PlatformDxe/SensorVar.c | 2 + > .../PlatformInitPei/CpuInitPeim.c | 12 - > .../PlatformInitPei/PchInitPeim.c | 4 +- > .../PlatformInitPei/PlatformEarlyInit.c | 86 +- > .../PlatformInitPei/PlatformEarlyInit.h | 6 - > .../PlatformInitPei/PlatformInitPei.inf | 2 + > .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 96 +- > .../Vlv2TbltDevicePkg/PlatformPei/Platform.c | 6 + > .../Vlv2TbltDevicePkg/PlatformPei/Platform.h | 17 + > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 12 + > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 52 +- > .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 914 ------------ > .../Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 1272 ---------------- > .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1289 ----------------- > .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 90 +- > .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 88 +- > .../PlatformSetupDefaults.dsc | 130 ++ > .../PlatformSetupDxe/PlatformSetupDxe.c | 145 +- > .../PlatformSetupDxe/Vfr.vfr | 17 +- > Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 348 +++++ > Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 64 +- > .../Stitch/Gcc/NvStorageFtwSpare.bin | Bin 262144 -> 0 bytes > .../Stitch/Gcc/NvStorageFtwWorking.bin | Bin 8192 -> 0 bytes > .../Stitch/Gcc/NvStorageVariable.bin | Bin 253952 -> 0 bytes > .../VlvPlatformInitDxe/IgdOpRegion.c | 2 +- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 322 ---- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 235 --- > 59 files changed, 1258 insertions(+), 6229 deletions(-) > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.bat > delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FCE.exe > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleAll.bat > create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleAll.py > delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleAll.sh > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleMinnowMax.bat > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleMinnowMax.sh > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleMinnowMaxRelease.bat > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleMinnowMaxRelease.sh > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleSampleColor.bat > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleSampleColor.sh > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/Lvfs.ddf > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/LvfsGenCapsuleMinnowMax.bat > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/LvfsGenCapsuleMinnowMaxRelease.bat > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/LvfsGenCapsuleSampleColor.bat > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/template.metainfo.xml > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Syst= emFirmwareDescriptor/SystemFirmwareDescriptor.aslc > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Syst= emFirmwareDescriptor/SystemFirmwareDescriptor.inf > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Syst= emFirmwareDescriptor/SystemFirmwareDescriptorPei.c > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Syst= emFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Syst= emFirmwareUpdateConfig/SystemFirmwareUpdateConfigGcc.ini > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.dsc > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.fdf > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.d= sc > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.f= df > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.d= sc > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.ds= c > create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDefault= s.dsc > create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorage= FtwSpare.bin > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorage= FtwWorking.bin > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorage= Variable.bin > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat > delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh >=20 > --=20 > 2.21.0.windows.1 >=20 >=20