From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, michael.d.kinney@intel.com,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Ye, Ting" <ting.ye@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]
Date: Tue, 23 Jul 2019 10:06:44 +0100 [thread overview]
Message-ID: <20190723090644.GD11541@bivouac.eciton.net> (raw)
In-Reply-To: <c714d190-fd29-63d8-bd59-0510c6fe2eda@redhat.com>
On Tue, Jul 23, 2019 at 12:56:23AM +0200, Laszlo Ersek wrote:
> Hi Mike,
>
> On 07/22/19 20:47, Michael D Kinney wrote:
> > We could consider checking for these type of issues in
> > the ECC tool instead of build and make it an error from
> > ECC instead of a warning.
>
> I'm sorry, my reply to Leif was ambiguous (or worse).
>
> I meant that the issues underlying the specific warnings (emitted by the
> feature from TianoCore#1804) were annoying -- the reports were valid,
> and what "annoyed" me was that the INF files had not been in order (i.e.
> that they had missed some internal header files).
Whereas I'm annoyed that we now have a manual process to match up with
the automatic dependency generation.
> I wasn't annoyed at the feature itself -- if it helps developers catch
> unlisted headers as soon as incomplete INF files are introduced, then
> it's not a bad feature IMO.
I agree that the optional nature of whether to list local .h files or
not in the .inf was suboptimal. I am just not pleased with the issue
bringing this to the fore is caused by the new caching feature using a
different mechanism for tracking header file dependencies than the
primary build process.
/
Leif
next prev parent reply other threads:[~2019-07-23 9:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 16:43 [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] Laszlo Ersek
2019-07-19 16:43 ` [PATCH 1/4] ArmPkg: list module-internal header files in INF [Sources] Laszlo Ersek
2019-07-19 16:43 ` [PATCH 2/4] ArmPlatformPkg: " Laszlo Ersek
2019-07-19 17:13 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-19 16:43 ` [PATCH 3/4] CryptoPkg/BaseCryptLib: " Laszlo Ersek
2019-07-19 17:09 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-22 5:48 ` Wang, Jian J
2019-07-19 16:43 ` [PATCH 4/4] EmbeddedPkg: " Laszlo Ersek
2019-07-19 17:08 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-22 10:37 ` [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] Leif Lindholm
2019-07-22 17:32 ` Laszlo Ersek
2019-07-22 18:47 ` [edk2-devel] " Michael D Kinney
2019-07-22 22:56 ` Laszlo Ersek
2019-07-23 9:06 ` Leif Lindholm [this message]
2019-07-23 11:54 ` Laszlo Ersek
2019-07-23 12:19 ` Leif Lindholm
2019-07-23 13:02 ` Liming Gao
2019-07-23 13:25 ` Leif Lindholm
2019-07-23 17:23 ` Laszlo Ersek
2019-07-24 15:17 ` Liming Gao
2019-07-24 17:00 ` Leif Lindholm
2019-07-25 19:27 ` Laszlo Ersek
2019-07-23 17:02 ` Laszlo Ersek
2019-07-22 22:30 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723090644.GD11541@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox