From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=RZ+WMYHE; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Tue, 23 Jul 2019 02:06:48 -0700 Received: by mail-wr1-f68.google.com with SMTP id r1so42286931wrl.7 for ; Tue, 23 Jul 2019 02:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Kc3qnkQvEALRLukvh4HFlYDjSk4b7pMJzcJqp8Xmw9w=; b=RZ+WMYHE04aQlNFyb0YWJJeekOU0DD80nqXZkaTz4S+BMajNw4QOS7EfvxYwpHl9Y4 tlbGHYvT/TMuDXZgkdEUunf2/8kFAs96w7vm8VyVRNK6V5aK6GQwp1CEB4LL9xNhjp4J BW3dyKhS68u9eclQeJScNGb3hcsKbjKUFGuqxYMDC9we+fsuleJPBk4h2pTH6MnEVkqv Q8BAWmmruIIDVuVHm5JdKJZP53wDde5NhqRvxSPX3SxfYRUzyvHNqrfoNuRSTdJGwfsY 8706CET6se64JpezIfD9+9XZXJk0jGZaJlHYTFa9oCGQYPisBBI8PcB2LffW9FMqvdpP MGDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Kc3qnkQvEALRLukvh4HFlYDjSk4b7pMJzcJqp8Xmw9w=; b=b8+LweNBdppzR+yWISOf0XTu354FSUD7SyvkMBFvXBF3/Yr9p23Tp7b1KX7BnI7JyM jnyPYt0eiOBmGGrh0BBNWnkiidIHOSlEAsp69TbG7Som+NKuqpZVT2AUH1P4HzViDdHy 6g1KV4oSqh9GnpS6qXTRIvIAVa7egfPSoeRxFYpv2lU0hfhbK+m65JSQXE7Grztiz7dS lQthclXij+JaGTvUcndgQ4MGsPFEyMzPhzuKadlv7kWeJBIfBsmeX87v2Ge0j9VvYG0C GNDPivncSlmlMCcaIltK18FTzl7kHRTapO+p5n8wSnCqrUQHOZEiYlIULiFrceBngbdu +D5g== X-Gm-Message-State: APjAAAX8pfkrSab4q2zHbUMbZUDZGc4jwjS3J7Yd8RntZktfITJX/Yla 0+Pp+Erml36F1jZO2icCgvP11A== X-Google-Smtp-Source: APXvYqx39ZgBTyOum5rANQCL4q+rofHmF/+1qzclRfMgRe8uSrR7gYDp1qaEo50cPVPLmLY1MMM57A== X-Received: by 2002:a5d:5012:: with SMTP id e18mr51954976wrt.166.1563872806570; Tue, 23 Jul 2019 02:06:46 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j189sm47314144wmb.48.2019.07.23.02.06.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 02:06:45 -0700 (PDT) Date: Tue, 23 Jul 2019 10:06:44 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, Ard Biesheuvel , "Wang, Jian J" , "Ye, Ting" Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] Message-ID: <20190723090644.GD11541@bivouac.eciton.net> References: <20190719164319.9070-1-lersek@redhat.com> <20190722103755.GA11541@bivouac.eciton.net> <591319a9-eceb-ab39-0ec0-ccd2530b0e58@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 23, 2019 at 12:56:23AM +0200, Laszlo Ersek wrote: > Hi Mike, > > On 07/22/19 20:47, Michael D Kinney wrote: > > We could consider checking for these type of issues in > > the ECC tool instead of build and make it an error from > > ECC instead of a warning. > > I'm sorry, my reply to Leif was ambiguous (or worse). > > I meant that the issues underlying the specific warnings (emitted by the > feature from TianoCore#1804) were annoying -- the reports were valid, > and what "annoyed" me was that the INF files had not been in order (i.e. > that they had missed some internal header files). Whereas I'm annoyed that we now have a manual process to match up with the automatic dependency generation. > I wasn't annoyed at the feature itself -- if it helps developers catch > unlisted headers as soon as incomplete INF files are introduced, then > it's not a bad feature IMO. I agree that the optional nature of whether to list local .h files or not in the .inf was suboptimal. I am just not pleased with the issue bringing this to the fore is caused by the new caching feature using a different mechanism for tracking header file dependencies than the primary build process. / Leif