public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>,
	Chandana Kumar <chandana.c.kumar@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: [Patch v3 0/6] UefiCpuPkg: Enable Edkii Mp Services2 Ppi
Date: Wed, 24 Jul 2019 15:07:21 +0800	[thread overview]
Message-ID: <20190724070727.14976-1-eric.dong@intel.com> (raw)

v3 changes:
1. Fix function header definition conflict issue.
2. Update copyright.

V2 changes:
1. Enable new API for MpInitLibUp.
2. Remove useless parameter FailedCpuList.
3. Rename StartupAllAPsWorker to StartupAllCpusWorker.

V1 Changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973

CpuFeatures solution introduces a policy which write msr bases on scope info. With this policy enabled, for the msr which is package scope, CpuFeature PEIM driver boots hang.
The reason for this failure is current CPU MP Ppi not supports start bsp and AP at the same time.

This patch serial introduce new API named StartupAllCPUs. And it add new ppi namded Edkii Mp Services2 Ppi, include EFI MP Serivces PPI and this new API.

With this new PPi, CPU features PEI solution can start all CPUs at the same time.

Because this patch only add one new API, i did belew tests:
1. Test StartupAllCpus with timeout == 0 pass.
2. Test StartupAllCpus with timeout != 0 pass.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Chandana Kumar <chandana.c.kumar@intel.com>
Cc: Star Zeng <star.zeng@intel.com>


Eric Dong (6):
  UefiCpuPkg/Include/MpInitLib.h: Add MpInitLibStartupAllCPUs API.
  UefiCpuPkg/MpInitLib: Add MpInitLibStartupAllCPUs API.
  UefiCpuPkg/MpInitLibUp: Add MpInitLibStartupAllCPUs API.
  UefiCpuPkg: Add new EDKII_PEI_MP_SERVICES2_PPI
  UefiCpuPkg/CpuMpPei: Produce EDKII_PEI_MP_SERVICES2_PPI.
  UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors
    simultaneously.

 UefiCpuPkg/CpuMpPei/CpuMpPei.c                |  21 +-
 UefiCpuPkg/CpuMpPei/CpuMpPei.h                |   3 +-
 UefiCpuPkg/CpuMpPei/CpuMpPei.inf              |   2 +
 UefiCpuPkg/CpuMpPei/Mp2Pei.c                  | 417 ++++++++++++++++++
 UefiCpuPkg/Include/Library/MpInitLib.h        |  36 +-
 UefiCpuPkg/Include/Ppi/MpServices2.h          | 279 ++++++++++++
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |   5 +-
 UefiCpuPkg/Library/MpInitLib/MpLib.c          |  61 ++-
 UefiCpuPkg/Library/MpInitLib/MpLib.h          |   6 +-
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |   5 +-
 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c  |  35 ++
 .../CpuFeaturesInitialize.c                   |   2 +-
 .../DxeRegisterCpuFeaturesLib.c               |   6 +-
 .../PeiRegisterCpuFeaturesLib.c               |  66 ++-
 .../PeiRegisterCpuFeaturesLib.inf             |   1 +
 .../RegisterCpuFeatures.h                     |   2 +-
 UefiCpuPkg/UefiCpuPkg.dec                     |   3 +
 17 files changed, 909 insertions(+), 41 deletions(-)
 create mode 100644 UefiCpuPkg/CpuMpPei/Mp2Pei.c
 create mode 100644 UefiCpuPkg/Include/Ppi/MpServices2.h

-- 
2.21.0.windows.1


             reply	other threads:[~2019-07-24  7:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  7:07 Dong, Eric [this message]
2019-07-24  7:07 ` [Patch v3 1/6] UefiCpuPkg/Include/MpInitLib.h: Add MpInitLibStartupAllCPUs API Dong, Eric
2019-07-26 10:36   ` [edk2-devel] " Laszlo Ersek
2019-07-24  7:07 ` [Patch v3 2/6] UefiCpuPkg/MpInitLib: " Dong, Eric
2019-07-26 10:36   ` [edk2-devel] " Laszlo Ersek
2019-07-24  7:07 ` [Patch v3 3/6] UefiCpuPkg/MpInitLibUp: " Dong, Eric
2019-07-25  8:53   ` [edk2-devel] " Ni, Ray
2019-07-26 10:37   ` Laszlo Ersek
2019-07-24  7:07 ` [Patch v3 4/6] UefiCpuPkg: Add new EDKII_PEI_MP_SERVICES2_PPI Dong, Eric
2019-07-25  8:53   ` Ni, Ray
2019-07-26 10:37   ` [edk2-devel] " Laszlo Ersek
2019-07-24  7:07 ` [Patch v3 5/6] UefiCpuPkg/CpuMpPei: Produce EDKII_PEI_MP_SERVICES2_PPI Dong, Eric
2019-07-25  8:55   ` Ni, Ray
2019-07-26 10:38   ` [edk2-devel] " Laszlo Ersek
2019-07-24  7:07 ` [Patch v3 6/6] UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors simultaneously Dong, Eric
2019-07-25  8:59   ` Ni, Ray
2019-07-26 10:38   ` [edk2-devel] " Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724070727.14976-1-eric.dong@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox