From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=HxsRQOsN; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Wed, 24 Jul 2019 09:49:36 -0700 Received: by mail-wm1-f68.google.com with SMTP id f17so42229217wme.2 for ; Wed, 24 Jul 2019 09:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zltDr5qMeP7lYMpu2qIQk063DgaP9gXWkNoYI9X+O0E=; b=HxsRQOsNmR1GtVKojh+uMlIMpeMCvJ/8r37GoKU8fY6OU5picZH4kj5SuBbqXDtGkP 0H2WcRWFIyG29oAoDQyWPB3j0vRp+dBEtYEKPVzKwce8Q7g7wKa6u7aeBUBSAlkzC2qv Yd6cKmzXnTG1SYxX3N5Pz8wVaWyJEbspYFK5PZ7EfsyVjThzLAKrchlIc7Yae0dJuAC6 Bq5UytyH1YWVZ2d6eJrO/YN3lnFvixMQ/JJuHkRFbWdie32Slfb6ow8qd3yuizsHM70j StWgGfa90YBV+1lg2irDGoCZG/r0UvoypyMC5xxAn/P+7ao4g9M/fhX5Sadlv65lNljj 0oNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zltDr5qMeP7lYMpu2qIQk063DgaP9gXWkNoYI9X+O0E=; b=ZIFn/AQbadW/9cvWDX6n13LxOkFw71TJYqKgw2B74LPuEwz4vt5ECfBxlf98Naef/z 74dMCy3wo3gNPQz835/GNHW21el4hDvbWs1z7OrvEL9IJj7f5IxiwPday50wGNnycqwO KsXd6VhcCIg7Sx9cF/duWvHoZiVMMRKlcN6gk8MI3yGhs3vcVhIviO13HqmV5GfwSKoh 0f/E7nf5nEZy8vNdpEcH670S5gyXC1bebDGbgtq59yJMCExfoF2JaslSO8XIBqJcWMYu G0tKfU3x3pCpB3mL+r896+YKCpH5oyEAT9MsdKsDTakeYgWhUru8gUngmsD2WO5SdW7H AENA== X-Gm-Message-State: APjAAAVLd2IRETJJZRTQYxAks3vCn+TiweE8SLiEfAkq6gHQAlFKbna5 ewS7bBzeb0ZPxES1bd+9FqFMsA== X-Google-Smtp-Source: APXvYqwvr8BZI72C2l8rF8R17DTRyPu+i1Xm5iaM934yM1Hs4/cgc5jtfigKmRieBLsJaWaQ3XTtWw== X-Received: by 2002:a1c:be05:: with SMTP id o5mr76323837wmf.52.1563986972706; Wed, 24 Jul 2019 09:49:32 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l2sm31484166wmj.4.2019.07.24.09.49.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 09:49:31 -0700 (PDT) Date: Wed, 24 Jul 2019 17:49:30 +0100 From: "Leif Lindholm" To: "Feng, Bob C" Cc: "devel@edk2.groups.io" , Laszlo Ersek , Andrew Fish , "Kinney, Michael D" , Philippe Mathieu-Daude , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) Message-ID: <20190724164930.GS11541@bivouac.eciton.net> References: <20190712170128.6495-1-leif.lindholm@linaro.org> <6799dc07-2d8c-0ad1-286e-23b2b68c413a@redhat.com> <20190719090027.GP2712@bivouac.eciton.net> <08650203BA1BD64D8AD9B6D5D74A85D160B46D94@SHSMSX105.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D160B46D94@SHSMSX105.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks Bob, Liming. GetMaintainer.py patch pushed as 7d0a56c4a125 On Wed, Jul 24, 2019 at 02:03:34AM +0000, Feng, Bob C wrote: > Patch looks fine for me. > > Reviewed-by: Bob Feng > > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm > Sent: Friday, July 19, 2019 5:00 PM > To: Laszlo Ersek > Cc: edk2-devel-groups-io ; Andrew Fish ; Kinney, Michael D ; Philippe Mathieu-Daude ; Feng, Bob C ; Gao, Liming ; Wu, Hao A ; Stefan Berger > Subject: Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) > > On Thu, Jul 18, 2019 at 11:17:30PM +0200, Laszlo Ersek wrote: > > On 07/18/19 18:27, Leif Lindholm wrote: > > > Laszlo, Hao - I have prepared a set for pushing as below. > > > > > > (Reviewed-by: Leif Lindholm for all of > > > your > > > patches.) > > > *But*, I need a review from Bob and/or Liming before I push the final one: > > > "BaseTools: add GetMaintainer.py script" - > > > https://edk2.groups.io/g/devel/message/43666 > > > > > > I have verified reviews/acks by all affected reviewers, except for > > > Stefan Berger for Ovmf TCG/TPM2. > > > > Stefan's R-b has arrived as well: > > > > http://mid.mail-archive.com/7201b3fb-d84b-30e0-61c8-bf9bb9defa7a@linux > > .ibm.com > > > > So, I agree, those four patches regarding OvmfPkg reviewership are now > > fully approved. > > > > Please pick up Phil's feedback as well. > > > > > While I would prefer to have that too, this is a file format shift - > > > not a change in responsibility areas. > > > Laszlo, do you agree? > > > If so, I can push 1-7/8 as is. > > > > See above -- then I'm OK. > > 1-7/8 pushed as: > 3dafa0382286..296c908c6968 > > Will push the GetMaintainer.py script once approved by BaseTools maintainers. > > Thanks! > > / > Leif > > > Thank you! > > Laszlo > > > > > > > > / > > > Leif > > > > > > Hao A Wu (1): > > > Maintainers.txt: Fine-grained review ownership for MdeModulePkg > > > > > > Laszlo Ersek (4): > > > Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" > > > Maintainers.txt: split out section "OvmfPkg: Xen-related modules" > > > Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related > > > modules" > > > Maintainers.txt: split out section "OvmfPkg: CSM modules" > > > > > > Leif Lindholm (3): > > > Maintainers.txt: update for filesystem area descriptions > > > Maintainers.txt: add wildcard path association for Arm/AArch64 > > > BaseTools: add GetMaintainer.py script > > > > > > > > > On Fri, 12 Jul 2019 at 18:01, Leif Lindholm > > > > > > wrote: > > > > > >> Changes are available directly from: > > >> > > >> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstrea > > >> ming/git-maintainer-v1 > > >> > > >> This series adds new tags to the Maintainers.txt format, making it > > >> possible to describe which filesystem paths are looked after by > > >> which people, and hence automating the extraction of a list over > > >> who should be cc:d on a patch submission. > > >> > > >> Remaining shorcomings in v1: > > >> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines > > >> interspersed with the tag lines. These lines will be removed as areas of > > >> responsibility is formally rewritten as tags. > > >> - * Wildcard support is not fully filesystem compliant except in first or > > >> last position in the file pattern (it translates as regex .* elsewhere). > > >> However, actual cases of mismatch are expected to be unlikely, and they > > >> will be false positives rather than false negatives - so I think this is > > >> good enough at least for a start. > > >> - Provides no information of why certain people or meiling lists were > > >> picked - it just bundles all recipients up, deduplicates them, and > > >> prints them out. > > >> > > >> Using the script requires the gitpython module to be installed. > > >> > > >> Worthwhile mentioning outside the ChangeLog is the added -l flag, > > >> which lets you look up what a given path would return in the way of matches. > > >> E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" > > >> would return: > > >> --- > > >> Non/Existing/Path > > >> "Non/Existing/Path": no maintainers found, looking for default > > >> Andrew Fish > > >> Laszlo Ersek > > >> Leif Lindholm > > >> Michael D Kinney > > >> devel@edk2.groups.io > > >> --- > > >> > > >> This series would still result in GetMaintainers.py missing some > > >> maintainers/reviewers due to descriptions in prose rather than > > >> filename patterns. My preferred way of handling this would be to > > >> merge 1-2/3 as soon as found acceptable, following up and merging > > >> patches to update ArmVirtPkg, MdeModulePkg, and OvmfPkg, and > > >> finally once the file is consistent, proceed to merge 3/3. > > >> > > >> Changelog: > > >> v1: > > >> - Rebase to current Maintainers.txt. > > >> - Fix typos and missed bits in Maintainers.txt. > > >> - Get rid of the magic '' filename, let the single-char '*' > > >> wildcard resolve this (_using_ the magic '' filename in the > > >> script, but treating it as if it was a file in the top-level directory). > > >> - Add -l flag to script to look up which maintainers would be returned for > > >> a given path (which need not exist). > > >> rfc: > > >> - Split patches up > > >> - one for new Maintainers.txt format (documentation and F: tags). > > >> - one for adding a new wilcards responsibility area for */Arm, */AArch64 > > >> - one for the GetMaintainer.py script > > >> - Reworked wildcard handling based on Laszlo's explanation > > >> - Trailing / covers everything under that directory > > >> - Trailing * does not cover subdirectories > > >> - Added support for X: tag > > >> - Added support for magic '' pathname > > >> - Also prints mailing list addresses for matching L: tags > > >> > > >> Cc: Andrew Fish > > >> Cc: Laszlo Ersek > > >> Cc: Michael D Kinney > > >> Cc: Bob Feng > > >> Cc: Liming Gao > > >> Cc: Philippe Mathieu-Daude > > >> Cc: "Wu, Hao A" > > >> > > >> Leif Lindholm (3): > > >> Maintainers.txt: update for filesystem area descriptions > > >> Maintainers.txt: add wildcard path association for Arm/AArch64 > > >> BaseTools: add GetMaintainer.py script > > >> > > >> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ > > >> Maintainers.txt | 54 ++++++++ > > >> 2 files changed, 244 insertions(+) create mode 100644 > > >> BaseTools/Scripts/GetMaintainer.py > > >> > > >> -- > > >> 2.20.1 > > >> > > >> > > > > > > > >