From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=bUbulwsR; spf=pass (domain: linaro.org, ip: 209.85.221.50, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by groups.io with SMTP; Wed, 24 Jul 2019 10:00:54 -0700 Received: by mail-wr1-f50.google.com with SMTP id g17so47782832wrr.5 for ; Wed, 24 Jul 2019 10:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2mksfBEKQTgfQ0vBjj/fmAOd8h36ehHs/WkaRw7h1y0=; b=bUbulwsRfA/qH4e0tiwe8vGgMdmshFQrWDVJ3vF0Ph+GqV06rRYTyeeOkAD0NL96aZ xb7a8EfiSqV6k/l6QciQkU1qButZbfTZPzL5xWaJ2oz047xTwuwxCiwucwmMi99yjjvf 6ZkKIiw6MPQQBbKuEqHhSamK/0zWEiDekk476eVbh5GCrBR7fURyoAwVjuxapIXfSCsL yfYLTUuTzbr69Y0Bw1H6R5JaIUjMzt93n3AlXZ4wbaEgCexp7QG05cibAxmqx4oUsbbV KfrePj9PN/LxwDETw8C+bhU8rmXoFrGz51U2GhWsjQRY43ujVFMf/etA1LlLF0heD1xK 7PpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2mksfBEKQTgfQ0vBjj/fmAOd8h36ehHs/WkaRw7h1y0=; b=R2oiH9lUus7nkmgfqmGGNaVr9RS5Qzx4v3bWbcU0udjN2i0J9njNTWJ0s9LxsmHd2e iMBS27xMih2W1dDzE49G32KBeT1ZBf0nIuJsq0NDI4FFXHUQ/DwELrNkGuU37xoqV0d1 stNuALiQmNpLyCMO8rDm3ETTymT8Wbb+lLUh8XDw8joCFSA/vAGloUxCNmkMcPCbNk/x FrXWHTonBtEuVUDJLrVUDs43ZxU1q3Yjo6vEmqRotrjwdqWb9RanbK71zVSzkY+vdEYF KFrWJA7vr6eaqtu3KBqz+yhPsWbINgUX+deI7e8jlHabUTjrfrNz1c5JgLXpzXnJ7+Pn 3zqQ== X-Gm-Message-State: APjAAAWZoEmH/GjW5SYbcjEA/wg/DN9pw9G7hSSNrgxlkJn2YntwjtMA xUQKRtEYuBL4ajeRPu4jxrAP3A== X-Google-Smtp-Source: APXvYqwCth9loaKmaDnWXIQRRb7BfsH0eJKsU+DBGwY6NJ3MUU7lRmT2KWzoOIeB7c/F4isaTKmwPg== X-Received: by 2002:adf:e444:: with SMTP id t4mr84216619wrm.262.1563987652871; Wed, 24 Jul 2019 10:00:52 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g12sm65717921wrv.9.2019.07.24.10.00.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 10:00:52 -0700 (PDT) Date: Wed, 24 Jul 2019 18:00:50 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: "devel@edk2.groups.io" , Laszlo Ersek , "Kinney, Michael D" , Ard Biesheuvel , "Wang, Jian J" , "Ye, Ting" Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] Message-ID: <20190724170050.GU11541@bivouac.eciton.net> References: <20190722103755.GA11541@bivouac.eciton.net> <591319a9-eceb-ab39-0ec0-ccd2530b0e58@redhat.com> <20190723090644.GD11541@bivouac.eciton.net> <20190723121940.GH11541@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B11C4@SHSMSX104.ccr.corp.intel.com> <20190723132543.GI11541@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B2125@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B2125@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 24, 2019 at 03:17:56PM +0000, Gao, Liming wrote: > > Would it be feasible to update the --hash functionality to make use of > > the include dependencies extracted from the source files? (Clearly, we > > know when the source files change, so we would also know when we would > > need to re-run the dependency search.) > > The design is to save the step to extract the dependencies from the source files. > I can further collect the build performance to be taken on the dependencies extraction > from the source files, and decide whether take this way. Another simple way is > to calculate all source files in module directory and make sure there is no file missing for --hash option. > > > > > If not, I think we should make the explicit listing of .h files > > in .inf mandatory, triggering a build failure when not the case. > > > > If it is, then I think we should make it explicitly banned to list .h > > files in .inf. (If there is no other dependency, such as doxygen, also > > making use of .inf listings of .h files.) > > I know edk2 also has PI Packaging UPT. PI packaging requires all source > files are listed in module INF file. Otherwise, some source files will be missed > in the packaging, and can't be rollback. OK, this means we should update the documentation to be crystal clear that .h files need to be listed too. I am OK to keep the warning enabled for now. But I would also wish that we start planning for making it an error at some point in the future. Best Regards, Leif