From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Michael Brown <mbrown@fensystems.co.uk>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, pete@akeo.ie
Subject: Re: [edk2-devel] [edk2-platforms: PATCHv2 1/1] Platform/RPi3: Provide "ethernet[0]" aliases in device tree
Date: Wed, 24 Jul 2019 22:43:42 +0100 [thread overview]
Message-ID: <20190724214342.GZ11541@bivouac.eciton.net> (raw)
In-Reply-To: <2165bfd9-d097-cd1d-0302-7c541f7f63cb@fensystems.co.uk>
On Wed, Jul 24, 2019 at 09:53:00PM +0100, Michael Brown wrote:
> On 24/07/2019 19:53, Leif Lindholm wrote:
> > > SanitizePSCI ();
> > > CleanMemoryNodes ();
> > > CleanSimpleFramebuffer ();
> > > + FixEthernetAliases ();
> >
> > ...would it be worth having a return value here and Print()ing a
> > message visible regardless of build profile if this function fails?
>
> Yes, I think that would be very sensible, but it would also be inconsistent
> with the rest of the code: all of the other device-tree-modifying functions
> in FdtDxe.c are declared as VOID and use only DEBUG to report errors.
>
> Changing this pattern throughout FdtDxe.c should, I think, be a completely
> separate patch. Would it be possible to merge the current patch, and I can
> then follow up with a second patch to improve the error visibility in
> non-debug builds?
Yeah, that works for me.
I'll push it tomorrow when I'm more awake, but for now:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
/
Leif
next prev parent reply other threads:[~2019-07-24 21:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 17:29 [edk2-platforms: PATCH 0/1] Handle RPi device trees using "ethernet0" Michael Brown
2019-07-19 17:29 ` [edk2-platforms: PATCH 1/1] Platform/RPi3: Accept "ethernet" or "ethernet0" aliases in device tree Michael Brown
2019-07-23 10:34 ` Leif Lindholm
2019-07-23 11:00 ` Michael Brown
2019-07-23 11:17 ` Leif Lindholm
2019-07-24 14:31 ` [edk2-platforms: PATCHv2 0/1] Platform/RPi3: Provide "ethernet[0]" " Michael Brown
2019-07-24 14:31 ` [edk2-platforms: PATCHv2 1/1] " Michael Brown
2019-07-24 18:53 ` Leif Lindholm
2019-07-24 20:53 ` [edk2-devel] " Michael Brown
2019-07-24 21:43 ` Leif Lindholm [this message]
2019-07-25 10:27 ` [edk2-platforms: PATCH 0/1] Report device tree modification errors using Print() Michael Brown
2019-07-25 10:27 ` [edk2-platforms: PATCH 1/1] Platform/RPi3: " Michael Brown
2019-08-06 17:07 ` Leif Lindholm
2019-08-08 23:16 ` [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Report device tree Michael Brown
2019-08-09 10:07 ` Leif Lindholm
2019-08-08 23:16 ` [edk2-platforms: PATCH v2 1/1] Platform/RPi3: Report device tree modification errors using Print() Michael Brown
2019-07-25 12:51 ` [edk2-devel] [edk2-platforms: PATCHv2 1/1] Platform/RPi3: Provide "ethernet[0]" aliases in device tree Leif Lindholm
2019-07-23 11:19 ` [edk2-platforms: PATCH 1/1] Platform/RPi3: Accept "ethernet" or "ethernet0" " Pete Batard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724214342.GZ11541@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox