From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=W8FdhY9b; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 24 Jul 2019 14:43:46 -0700 Received: by mail-wr1-f66.google.com with SMTP id x1so33514501wrr.9 for ; Wed, 24 Jul 2019 14:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eW4zPK+Ynv436y0NJd3Uqxu+3tRlW0Ztll0gkPZCbQA=; b=W8FdhY9bS7qYXEOJYJog5Hne5jbsvl9z7/sBxynPli9tTVV8cOvM+1QftrYhMny39D fcUa8wPeuYAtfWDQrWTImZCv2RaAR3Zf2iXAURgr50Ga5uuOIetalOJi2Pl2fTQwADAh GPIQQPwbJJzg9oPR13p8NiWC6GJrEmrHmEioEZ64Z8xli6GoKN6hZwkyYbZYEftHOTvy Mcx754JO4ximHH/pD47pxH9FysNfPdPYkWvcP1yRjB7unPFQbx208UFD/3cTEdBorFir x5c5jdW0h2m49ElAKmFacTq1T0MmYV6F10oX8u4JE2BW0ODpXPKGMdjU56eckIGyI53R T9mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eW4zPK+Ynv436y0NJd3Uqxu+3tRlW0Ztll0gkPZCbQA=; b=oRODKq/3NlmnRlFFjqwqT5YYGdbYzOeXxgjUWYzG5j5ezo8ZFhtWs4VjA67N265AiK 0c/Fy/e8+cJhnWwTX8apy30hZ1xiCeBOhA1+YjKYtqD5fK13XHpme+ZRDZ4NUu3Jtsho cY7w3chiz8MuLICNljBlKWYYr5LQQocGJdzuz9a5u6bUPP+uRvYxypOzcsMNjbckAHtu AaCrFewMm6rqMzFjNvEC8wmAfuVx50Tx1HF41NFuCFKn+PUNBKI3jpNkCPW5ROofAU6I BqLKmdRi8O301zl7dlOBZlx5OmrcQXh7ZDa9VJkdZMqLosGY05dS3EYFywWNz3xV7Ggr loig== X-Gm-Message-State: APjAAAXRxG70YeZw4DM/kSLeWC/ZN0E5r3BEG4ryShcLKiW2s5v22b2x boEmXTMCfu9dkpZK8rJzz9grsQ== X-Google-Smtp-Source: APXvYqze7TSLH/v9gTiMA5ohuYXxoY+4TpBfjJTyHOSFsUCxM+QYakTkERNQlVprYG885+iMRt3GGA== X-Received: by 2002:adf:aac8:: with SMTP id i8mr15634693wrc.56.1564004624815; Wed, 24 Jul 2019 14:43:44 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g11sm47890751wru.24.2019.07.24.14.43.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 14:43:43 -0700 (PDT) Date: Wed, 24 Jul 2019 22:43:42 +0100 From: "Leif Lindholm" To: Michael Brown Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, pete@akeo.ie Subject: Re: [edk2-devel] [edk2-platforms: PATCHv2 1/1] Platform/RPi3: Provide "ethernet[0]" aliases in device tree Message-ID: <20190724214342.GZ11541@bivouac.eciton.net> References: <20190723111727.GG11541@bivouac.eciton.net> <20190724143114.468304-2-mbrown@fensystems.co.uk> <20190724185343.GX11541@bivouac.eciton.net> <2165bfd9-d097-cd1d-0302-7c541f7f63cb@fensystems.co.uk> MIME-Version: 1.0 In-Reply-To: <2165bfd9-d097-cd1d-0302-7c541f7f63cb@fensystems.co.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 24, 2019 at 09:53:00PM +0100, Michael Brown wrote: > On 24/07/2019 19:53, Leif Lindholm wrote: > > > SanitizePSCI (); > > > CleanMemoryNodes (); > > > CleanSimpleFramebuffer (); > > > + FixEthernetAliases (); > > > > ...would it be worth having a return value here and Print()ing a > > message visible regardless of build profile if this function fails? > > Yes, I think that would be very sensible, but it would also be inconsistent > with the rest of the code: all of the other device-tree-modifying functions > in FdtDxe.c are declared as VOID and use only DEBUG to report errors. > > Changing this pattern throughout FdtDxe.c should, I think, be a completely > separate patch. Would it be possible to merge the current patch, and I can > then follow up with a second patch to improve the error visibility in > non-debug builds? Yeah, that works for me. I'll push it tomorrow when I'm more awake, but for now: Reviewed-by: Leif Lindholm / Leif