From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=EscP6wZZ; spf=pass (domain: linaro.org, ip: 209.85.167.65, mailfrom: haojian.zhuang@linaro.org) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by groups.io with SMTP; Wed, 24 Jul 2019 22:09:30 -0700 Received: by mail-lf1-f65.google.com with SMTP id b17so33542833lff.7 for ; Wed, 24 Jul 2019 22:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q8XTIk0Yr72w/ZzVtF82iFpyuuIZMrpV8DTVQxto1iE=; b=EscP6wZZ5+4pWksahYrIdyj1mVuplAtocQeaNcfHawaBOsJfFYyjKsa4CAH/YZ4jk9 vMSs36zAagvV7I7p8Dhjw93+mFKn95Sj7WAdvalZoD10j9OPSxsRugicxAVwAFYitb7r CtgXmH+V1Af20QY10Bc2k3nHiENys24dRJWrQG5h4j/sWaGCL2KLrIupDu6NFt2f2iR0 6ZksCpSsqdzJQ3SHcY2ETy+oSRrOKCl5ca9XEtok7F5TyqF0CgBZOAjtaBkqGNBWM40G BGanFtvODHQz03B+0Q+P0SEgAa8lPHoLVU+LvlgI8BVORpFt1LW2s3sxok/0Leo+HmCs tPug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q8XTIk0Yr72w/ZzVtF82iFpyuuIZMrpV8DTVQxto1iE=; b=b9ZaLhtX2KGMqmm0P7OoyuYDGmMf4Ofa6gihnhuOL/lZg4wTvzeH2NxFDWEwYOvrLR pOocg9brr6OnXACO5Jv2aYuPvrggsGSTaNm6hUvzeg1ahfiyEOQEZUUSKkNME+OdgCkq RCAQWHauP/nIDn/YLYNQQRgyMOqoLEl3bwCyG//y2Br1HkQXk7jQVMp2MN3PQJvq20DP cHD07yWE2kBY4i9Wu9EeGk4agxb+ndkjrKvZPOUB9KthehLAKzZbkxj7yD66kxDZcC3j uLv3FCO3Y5ICeeB0V37/muVdQuI664WV3UO4Dm0RyrIFTiuktpCwZlVR1KquBrhGAWAF x6SA== X-Gm-Message-State: APjAAAWzmJ7M69BeQdkFBblKRgx4h6IxOKd7drxb9t4J+CwCiHZKAMSZ koZ6ensRrwRdaRAgTuAzoZl4EQ== X-Google-Smtp-Source: APXvYqxdKM4TyOqplyUd3LXv3SOT0xCTnBQIbL8UjOgs81SGtEV40v64hn5f2prvE1K9aLkN7ezG3A== X-Received: by 2002:a19:4aca:: with SMTP id x193mr35777365lfa.146.1564031368008; Wed, 24 Jul 2019 22:09:28 -0700 (PDT) Return-Path: Received: from gmail.com ([58.32.33.92]) by smtp.gmail.com with ESMTPSA id n24sm8974512ljc.25.2019.07.24.22.09.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2019 22:09:27 -0700 (PDT) Date: Thu, 25 Jul 2019 13:09:19 +0800 From: haojian.zhuang@linaro.org To: tien.hock.loh@intel.com Cc: devel@edk2.groups.io, thloh85@gmail.com Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver Message-ID: <20190725050916.GE6058@gmail.com> References: <20190724092606.185319-1-tien.hock.loh@intel.com> MIME-Version: 1.0 In-Reply-To: <20190724092606.185319-1-tien.hock.loh@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock.loh@intel.com wrote: > From: "Tien Hock, Loh" > > Changelog: > v3: > * Fix an issue in NonDiscoverableDeviceDxe driver where it did not invalidate > cache before copying the memory. > v2: > *Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc protocol, > and the other is for DwMmcHcDxe driver. > v1: > *Add NonDiscoverableDeviceDxe for embedded platform. Make DwMmcHcDxe driver > to support both eMMC and SD controller. > > Haojian Zhuang (3): > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > EmbeddedPkg: add PlatformDwMmc protocol > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 +++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 ++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 +++++++++++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 +++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 ++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > EmbeddedPkg/EmbeddedPkg.dec | 1 + > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > .../NonDiscoverableDeviceDxe.c | 243 ++ > .../NonDiscoverableDeviceDxe.inf | 52 + > .../NonDiscoverableDeviceIo.c | 976 +++++++ > .../NonDiscoverableDeviceIo.h | 92 + > 16 files changed, 9495 insertions(+) > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.inf > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.h > > -- > 2.19.0 > Tested on HiKey platform. Best Regards Haojian