From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=SPF record not found (domain: fensystems.co.uk, ip: 212.13.204.60, mailfrom: mbrown@fensystems.co.uk) Received: from duck.fensystems.co.uk (duck.fensystems.co.uk [212.13.204.60]) by groups.io with SMTP; Thu, 25 Jul 2019 03:27:22 -0700 Received: from pudding.home (pudding.qs.unipart.io [IPv6:2001:470:1dbe:1:ffff::c5f1]) by duck.fensystems.co.uk (Postfix) with ESMTPSA id 3495215B5A; Thu, 25 Jul 2019 11:27:19 +0100 (BST) From: Michael Brown To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, pete@akeo.ie, Michael Brown Subject: [edk2-platforms: PATCH 0/1] Report device tree modification errors using Print() Date: Thu, 25 Jul 2019 11:27:14 +0100 Message-Id: <20190725102715.572560-1-mbrown@fensystems.co.uk> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190724214342.GZ11541@bivouac.eciton.net> References: <20190724214342.GZ11541@bivouac.eciton.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable >>> ...would it be worth having a return value here and Print()ing a >>> message visible regardless of build profile if this function fails? >> >> Yes, I think that would be very sensible, but it would also be inconsi= stent >> with the rest of the code: all of the other device-tree-modifying func= tions >> in FdtDxe.c are declared as VOID and use only DEBUG to report errors. >> >> Changing this pattern throughout FdtDxe.c should, I think, be a comple= tely >> separate patch. Would it be possible to merge the current patch, and = I can >> then follow up with a second patch to improve the error visibility in >> non-debug builds? >=20 > Yeah, that works for me. As promised, here is the subsequent patch to improve error visibility throughout FdtDxe. Michael Brown (1): Platform/RPi3: Report device tree modification errors using Print() .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 102 ++++++++++++------ 1 file changed, 70 insertions(+), 32 deletions(-) --=20 2.21.0