Re: [edk2-devel] [edk2-platforms: PATCHv2 1/1] Platform/RPi3: Provide "ethernet[0]" aliases in device tree

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Wed, Jul 24, 2019 at 10:43:42PM +0100, Leif Lindholm wrote:
> On Wed, Jul 24, 2019 at 09:53:00PM +0100, Michael Brown wrote:
> > On 24/07/2019 19:53, Leif Lindholm wrote:
> > > >     SanitizePSCI ();
> > > >     CleanMemoryNodes ();
> > > >     CleanSimpleFramebuffer ();
> > > > +  FixEthernetAliases ();
> > > 
> > > ...would it be worth having a return value here and Print()ing a
> > > message visible regardless of build profile if this function fails?
> > 
> > Yes, I think that would be very sensible, but it would also be inconsistent
> > with the rest of the code: all of the other device-tree-modifying functions
> > in FdtDxe.c are declared as VOID and use only DEBUG to report errors.
> > 
> > Changing this pattern throughout FdtDxe.c should, I think, be a completely
> > separate patch.  Would it be possible to merge the current patch, and I can
> > then follow up with a second patch to improve the error visibility in
> > non-debug builds?
> 
> Yeah, that works for me.
> I'll push it tomorrow when I'm more awake, but for now:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 9181684081bf.

Thanks!

/
    Leif