From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=cX/SQrnK;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by groups.io with SMTP; Thu, 25 Jul 2019 05:51:55 -0700
Received: by mail-wm1-f68.google.com with SMTP id x15so44901095wmj.3
        for <devel@edk2.groups.io>; Thu, 25 Jul 2019 05:51:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=sQT69CDwVoaPQlhPV+QUAdUAEgKmt0k8PFeGYNdBP94=;
        b=cX/SQrnKeUVMr5DrmHp3pBKAHs/VuYYPp9Tb8VV1Fm8/B8x+wDdlOTPIIY74j1c7fx
         91ZMd9DefcnnEy5Pr0ocLsQ4uDdBLmucMj4REy9Yx8fB3V2G5VMGXCHrbrwb/LMPTe/q
         zHOttJIxMkg+kJ4UoAwape/BlN/L4zmCWK/eAJtN5snnEX/9ec2sA2p80920r0dgImoV
         vC4e5ZZ1IEnWAr1zU8P2ju/mwMW4T7uBZeAXudYSZuRb0riYQ8qDbdycKv2T/Y39ye1Q
         1Zgk9oherpZt7KY+PjHNYO2wa7Q0yIlgyQ/f2eUKdtqbBFd7QDn7khR8HJ48Fv/5NLWc
         y9mg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=sQT69CDwVoaPQlhPV+QUAdUAEgKmt0k8PFeGYNdBP94=;
        b=guQUc13njtcOc5o0zESOLdFH2w0tSNZpDyZJ8vDRPE8m6eFqqxo4j5A+DBwIdrghkf
         P8Q/h/6G9064BlmRFgKEkH3utK97XhevOrqV5MQ87IqZXN9gkGFVqoB7M6Kdwaoy29e8
         TTISxTID674m2BuAtqUH29RHflHctPsp5voQPmgRQ4GEj48jnEjlLAwNXwKcrhGMDWG8
         ONJEIYIXB5kGMVFUdw5f41og5difyqvM+MW2P+PhKxMgo1k4aMCin3zMf+eqYESPDHqE
         H2D2pVsA/NCdU2Q35A67+KsPSQWnC4Z69fSGTb8Qd7GlLGpgleoXntGZk20MAJ96fFXi
         bTog==
X-Gm-Message-State: APjAAAVtH0V1WzNo/aU0YvCvoJ4mfwLxARfJ9xeUOePSdHaLrAmS3B4s
	LPDqy2yeKS/iCsPIwsXc9fs42w==
X-Google-Smtp-Source: APXvYqzRsiS/e5W2dJBsUdiZEycRJ6TvnR6HbzEARDaih4ZsKDd6z731q7qy8KrTkObV7N1fvHH6MA==
X-Received: by 2002:a05:600c:21d4:: with SMTP id x20mr73209200wmj.61.1564059113967;
        Thu, 25 Jul 2019 05:51:53 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id x18sm43878716wmi.12.2019.07.25.05.51.52
        (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
        Thu, 25 Jul 2019 05:51:52 -0700 (PDT)
Date: Thu, 25 Jul 2019 13:51:51 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Michael Brown <mbrown@fensystems.co.uk>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, pete@akeo.ie
Subject: Re: [edk2-devel] [edk2-platforms: PATCHv2 1/1] Platform/RPi3: Provide "ethernet[0]" aliases in device tree
Message-ID: <20190725125151.GD11541@bivouac.eciton.net>
References: <20190723111727.GG11541@bivouac.eciton.net>
 <20190724143114.468304-2-mbrown@fensystems.co.uk>
 <20190724185343.GX11541@bivouac.eciton.net>
 <2165bfd9-d097-cd1d-0302-7c541f7f63cb@fensystems.co.uk>
 <20190724214342.GZ11541@bivouac.eciton.net>
MIME-Version: 1.0
In-Reply-To: <20190724214342.GZ11541@bivouac.eciton.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 24, 2019 at 10:43:42PM +0100, Leif Lindholm wrote:
> On Wed, Jul 24, 2019 at 09:53:00PM +0100, Michael Brown wrote:
> > On 24/07/2019 19:53, Leif Lindholm wrote:
> > > >     SanitizePSCI ();
> > > >     CleanMemoryNodes ();
> > > >     CleanSimpleFramebuffer ();
> > > > +  FixEthernetAliases ();
> > > 
> > > ...would it be worth having a return value here and Print()ing a
> > > message visible regardless of build profile if this function fails?
> > 
> > Yes, I think that would be very sensible, but it would also be inconsistent
> > with the rest of the code: all of the other device-tree-modifying functions
> > in FdtDxe.c are declared as VOID and use only DEBUG to report errors.
> > 
> > Changing this pattern throughout FdtDxe.c should, I think, be a completely
> > separate patch.  Would it be possible to merge the current patch, and I can
> > then follow up with a second patch to improve the error visibility in
> > non-debug builds?
> 
> Yeah, that works for me.
> I'll push it tomorrow when I'm more awake, but for now:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 9181684081bf.

Thanks!

/
    Leif