From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.67, mailfrom: glin@suse.com) Received: from m9a0002g.houston.softwaregrp.com (m9a0002g.houston.softwaregrp.com [15.124.64.67]) by groups.io with SMTP; Fri, 26 Jul 2019 00:39:04 -0700 Received: FROM m9a0002g.houston.softwaregrp.com (15.121.0.190) BY m9a0002g.houston.softwaregrp.com WITH ESMTP; Fri, 26 Jul 2019 07:39:01 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M9W0067.microfocus.com (2002:f79:be::f79:be) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 26 Jul 2019 07:35:36 +0000 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (15.124.72.14) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Fri, 26 Jul 2019 07:35:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nH3b8Bmu5aDf6PaqJzRdvV8ezVAw77RtNgZkswGNdfVulnrWrj8zjEfBiKLhyvlMcuZ7wBirYJ7/DDPp/D3lFlwRHcw2n0N+OtKod2z+9nTs26F7W4cujr+C1MRBA6oWJHnN+JsGA2QdV5zcUxJM93z6TxxW7YvFdjg82l1iZbYB2c+HFHRKmhO/lSwPl++cChEKDHgOF3nJn1tpEKrITh2E2l7RubYAugB8snYZ4zIH5yw2VDm7Kn481cinPMXd3ZqFSlZLlZKnQCQ7jnjOYqu9CJ6ieXnSre/slZztZVuC04pXWaP4xwRqTjhcdOIx9+FtVBjTnaZDkVQJY6ldIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9sDHuDznPnZiY0YNy/n66ZoGxdmJMh2pGClljRWZ/k=; b=Pj4KS7MFox9PN7BJV6Djy+udC9xhNAc4RTwiVfJbwvp7D5i5fUGdelA78xVMdmzgSptzM9Yfy7xwwgENGVlyCepDwCWnwwq3MxlABLuZMSLTpzi2UvEhJDENmCpicmtXhim5Erctbxw1u2I+t9rWBbbD/hAH7xpogsvk7C1R4F7ICL1N3j9YS7CUbxS8cS/F6Nvr6AiqGsjGi/etsPRYfvNn8FAvu5ibx0Pdc+VrtJ2UQ2EFpLU2WiAgv7QyyIbzuVlbwUxdSowvWJbaeDukdm6pLsExwJAhR4bpC+/9MsPopcqzJDfE73z58bfFnyKPvH76siSjcsd7WPA92CnJlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB2844.namprd18.prod.outlook.com (20.179.51.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Fri, 26 Jul 2019 07:35:35 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2115.005; Fri, 26 Jul 2019 07:35:35 +0000 From: "Gary Lin" To: "devel@edk2.groups.io" CC: Michael D Kinney , Yi Qian , Zailiang Sun Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/4] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp Thread-Topic: [edk2-devel] [PATCH edk2-platforms 2/4] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp Thread-Index: AQHVQ4EVlFcbHtXe1k+ca8yjv764Xabcgl0A Date: Fri, 26 Jul 2019 07:35:35 +0000 Message-ID: <20190726073524.GB27677@GaryWorkstation> References: <20190726070612.3649-1-glin@suse.com> <15B4E359C7942CB9.8182@groups.io> In-Reply-To: <15B4E359C7942CB9.8182@groups.io> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6PR07CA0024.eurprd07.prod.outlook.com (2603:10a6:6:2d::34) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b4dfde6-f2d5-4c96-87dd-08d7119bd8ff x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB2844; x-ms-traffictypediagnostic: DM6PR18MB2844: x-ms-exchange-purlcount: 3 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 01106E96F6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(189003)(199004)(53936002)(478600001)(3846002)(11346002)(19627235002)(14444005)(1076003)(186003)(256004)(81166006)(1730700003)(476003)(316002)(305945005)(446003)(33716001)(6916009)(6116002)(71200400001)(99286004)(8676002)(5660300002)(81156014)(229853002)(66066001)(5640700003)(7736002)(68736007)(54906003)(2906002)(6512007)(6306002)(52116002)(80792005)(486006)(66446008)(66476007)(66556008)(64756008)(66946007)(2501003)(6486002)(2351001)(6246003)(9686003)(86362001)(14454004)(966005)(6436002)(26005)(4326008)(102836004)(33656002)(6506007)(386003)(25786009)(71190400001)(76176011)(8936002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB2844;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9MET2hsAh6rRGmXX4nLTIygFJIjdU4e24q3AOLyc8wd1t1wOXTtqawRW3TKUP4AT6r+J8ZELgYzCkU5XmBU6+68YCZXrvcRcjUMzQxEZkSqoEYGFO3DUg9slK9teVtKpVhpAo9bUgkqUWbzfm1j23n/NxqYxP+x8adLOV6X8+4b91m9e/YjlKS3+k6kdTn3kXNjYJ/h3WtxwryhMZCf5vMIRCBeHhl9fO3btz1axdyKVabYa9+sT2fb+bKX2rG2/w/j24pzuehx0Q3vzqCLjErAkvTkY0AgOGv9Ct9/JT4RZNsbX4c9poZ78nuwFS5ohs7S0Q5NkVqO7+c+1z6xfGrmJJHj/2qmGyDaMxVxoYZ9SkWVZ52isiunA2kWb7ZAWqELE4Qjsws9vsT1FHvodMvPTXV4HYx8hmFyHzFPBXrI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4dfde6-f2d5-4c96-87dd-08d7119bd8ff X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 07:35:35.5482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2844 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On Fri, Jul 26, 2019 at 07:06:39AM +0000, Gary Lin wrote: > BootManagerMenuApp wasn't imported so the Boot Device Menu never showed > correctly. >=20 I should add more details for the fix below. > Also fix the description of UiApp. In the "Rule.Common.UEFI_APPLICATION.UI" section, it intends to change the description of UiApp to "Enter Setup" to make the boot option self-explaining in the Boot Menu. But this didn't happen since the rule wasn't assigned to UiApp correctly, so the Boot Menu only showed "UiApp" which is not understandable to users. This patch adds "RuleOverride =3D UI= " to UiApp.inf to change the description. I'll add the above paragraph in case there is a v2 for this series. Gary Lin > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael D Kinney > Signed-off-by: Gary Lin > --- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 3 ++- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 3 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Platform= /Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > index 48058b663a..55a309444f 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > @@ -417,7 +417,8 @@ INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf > INF MdeModulePkg/Universal/Metronome/Metronome.inf > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Logo/LogoDxe.inf > -INF MdeModulePkg/Application/UiApp/UiApp.inf > +INF RuleOverride =3D UI MdeModulePkg/Application/UiApp/UiApp.inf > +INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.= inf > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Plat= form/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 30b47d8f32..463b952e65 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -924,6 +924,7 @@ > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMainten= anceManagerUiLib.inf > } > + MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf > > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platf= orm/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 57316d487b..ee18b45c97 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -939,6 +939,7 @@ > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMainten= anceManagerUiLib.inf > } > + MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf > > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > --=20 > 2.22.0 >=20 >=20 >=20 >=20 >=20