From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 29 Jul 2019 11:03:29 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B825316290C; Mon, 29 Jul 2019 18:03:29 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B254F5C205; Mon, 29 Jul 2019 18:03:27 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Leif Lindholm , Laszlo Ersek , Ard Biesheuvel , Philippe Mathieu-Daude , Andrew Jones Subject: [PATCH 1/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Date: Mon, 29 Jul 2019 20:03:20 +0200 Message-Id: <20190729180321.1715-2-philmd@redhat.com> In-Reply-To: <20190729180321.1715-1-philmd@redhat.com> References: <20190729180321.1715-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 29 Jul 2019 18:03:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In commit 1fce963d89f3e we reduced the level of information printed by PeCoffLoaderRelocateImageExtraAction() but we did not update the similar PeCoffLoaderUnloadImageExtraAction() function. PeCoffLoaderUnloadImageExtraAction() prints helpful debugger commands for source level debugging. These messages should not be printed on the EFI_D_ERROR level; they don't report errors. Change the debug level (bitmask, actually) to DEBUG_LOAD | DEBUG_INFO, because the messages are printed in relation to image loading, and they are informative. Cc: Leif Lindholm Cc: Ard Biesheuvel Reported-by: Andrew Jones Suggested-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daude --- .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraAct= ionLib.c b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActio= nLib.c index a1cb99677fe6..3379744aa185 100644 --- a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.= c +++ b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.= c @@ -122,14 +122,14 @@ PeCoffLoaderUnloadImageExtraAction ( if (ImageContext->PdbPointer) { #ifdef __CC_ARM // Print out the command for the RVD debugger to load symbols for th= is image - DEBUG ((EFI_D_ERROR, "unload symbols_only %a\n", DeCygwinPathIfNeede= d (ImageContext->PdbPointer, Temp, sizeof (Temp)))); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "unload symbols_only %a\n", DeCygwi= nPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)))); #elif __GNUC__ // This may not work correctly if you generate PE/COFF directlyas th= en the Offset would not be required - DEBUG ((EFI_D_ERROR, "remove-symbol-file %a 0x%08x\n", DeCygwinPathI= fNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(ImageCon= text->ImageAddress + ImageContext->SizeOfHeaders))); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "remove-symbol-file %a 0x%08x\n", D= eCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UIN= TN)(ImageContext->ImageAddress + ImageContext->SizeOfHeaders))); #else - DEBUG ((EFI_D_ERROR, "Unloading %a\n", ImageContext->PdbPointer)); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading %a\n", ImageContext->Pdb= Pointer)); #endif } else { - DEBUG ((EFI_D_ERROR, "Unloading driver at 0x%11p\n", (VOID *)(UINTN)= ImageContext->ImageAddress)); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading driver at 0x%11p\n", (VO= ID *)(UINTN) ImageContext->ImageAddress)); } } --=20 2.20.1