* [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code
@ 2019-07-30 6:40 Zhang, Shenglei
2019-07-30 14:05 ` Laszlo Ersek
2019-07-31 2:28 ` Dong, Eric
0 siblings, 2 replies; 3+ messages in thread
From: Zhang, Shenglei @ 2019-07-30 6:40 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Ray Ni, Laszlo Ersek, Shenglei Zhang
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index ef16997547..990dfe6826 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -1398,7 +1398,7 @@ InternalSmmStartupAllAPs (
Wrapper for Procedures.
- @param[in] Buffer Pointer to PROCEDURE_WRAPPER buffer.
+ @param[in,out] Buffer Pointer to PROCEDURE_WRAPPER buffer.
**/
EFI_STATUS
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
index 186809f431..c73f13e3c8 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
@@ -1295,7 +1295,7 @@ RestoreCr2 (
@param[in] Procedure The address of the procedure to run
@param[in] CpuIndex Target CPU Index
@param[in,out] ProcArguments The parameter to pass to the procedure
- @param[in,out] Token This is an optional parameter that allows the caller to execute the
+ @param[in] Token This is an optional parameter that allows the caller to execute the
procedure in a blocking or non-blocking fashion. If it is NULL the
call is blocking, and the call will not return until the AP has
completed the procedure. If the token is not NULL, the call will
@@ -1387,7 +1387,7 @@ IsPresentAp (
@param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
- @param[in,out] ProcedureArgument The parameter passed into Procedure for
+ @param[in,out] ProcedureArguments The parameter passed into Procedure for
all APs.
@param[in,out] Token This is an optional parameter that allows the caller to execute the
procedure in a blocking or non-blocking fashion. If it is NULL the
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code
2019-07-30 6:40 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code Zhang, Shenglei
@ 2019-07-30 14:05 ` Laszlo Ersek
2019-07-31 2:28 ` Dong, Eric
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2019-07-30 14:05 UTC (permalink / raw)
To: shenglei, devel; +Cc: Eric Dong, Ray Ni
On 07/30/19 08:40, shenglei wrote:
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index ef16997547..990dfe6826 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1398,7 +1398,7 @@ InternalSmmStartupAllAPs (
>
> Wrapper for Procedures.
>
> - @param[in] Buffer Pointer to PROCEDURE_WRAPPER buffer.
> + @param[in,out] Buffer Pointer to PROCEDURE_WRAPPER buffer.
>
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index 186809f431..c73f13e3c8 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1295,7 +1295,7 @@ RestoreCr2 (
> @param[in] Procedure The address of the procedure to run
> @param[in] CpuIndex Target CPU Index
> @param[in,out] ProcArguments The parameter to pass to the procedure
> - @param[in,out] Token This is an optional parameter that allows the caller to execute the
> + @param[in] Token This is an optional parameter that allows the caller to execute the
> procedure in a blocking or non-blocking fashion. If it is NULL the
> call is blocking, and the call will not return until the AP has
> completed the procedure. If the token is not NULL, the call will
> @@ -1387,7 +1387,7 @@ IsPresentAp (
> @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
> APs to return from Procedure, either for
> blocking or non-blocking mode.
> - @param[in,out] ProcedureArgument The parameter passed into Procedure for
> + @param[in,out] ProcedureArguments The parameter passed into Procedure for
> all APs.
> @param[in,out] Token This is an optional parameter that allows the caller to execute the
> procedure in a blocking or non-blocking fashion. If it is NULL the
>
I'll let Eric and Ray check this, as the patch only modifies comments.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code
2019-07-30 6:40 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code Zhang, Shenglei
2019-07-30 14:05 ` Laszlo Ersek
@ 2019-07-31 2:28 ` Dong, Eric
1 sibling, 0 replies; 3+ messages in thread
From: Dong, Eric @ 2019-07-31 2:28 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Ni, Ray, Laszlo Ersek
Hi Shenglei,
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Tuesday, July 30, 2019 2:40 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>; Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments
> consistent with code
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index ef16997547..990dfe6826 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1398,7 +1398,7 @@ InternalSmmStartupAllAPs (
>
> Wrapper for Procedures.
>
> - @param[in] Buffer Pointer to PROCEDURE_WRAPPER buffer.
> + @param[in,out] Buffer Pointer to PROCEDURE_WRAPPER buffer.
1. Please remove "out" attribute for " Buffer" parameter in function header.
>
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index 186809f431..c73f13e3c8 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1295,7 +1295,7 @@ RestoreCr2 (
> @param[in] Procedure The address of the procedure to run
> @param[in] CpuIndex Target CPU Index
> @param[in,out] ProcArguments The parameter to pass to the
> procedure
> - @param[in,out] Token This is an optional parameter that allows
> the caller to execute the
> + @param[in] Token This is an optional parameter that allows
2. Please add "out" attribute for " Token" parameter in function header.
Thanks,
Eric
> the caller to execute the
> procedure in a blocking or non-blocking fashion. If it is
> NULL the
> call is blocking, and the call will not return until the AP
> has
> completed the procedure. If the token is not NULL, the
> call will @@ -1387,7 +1387,7 @@ IsPresentAp (
> @param[in] TimeoutInMicroseconds Indicates the time limit in
> microseconds for
> APs to return from Procedure, either for
> blocking or non-blocking mode.
> - @param[in,out] ProcedureArgument The parameter passed into
> Procedure for
> + @param[in,out] ProcedureArguments The parameter passed into
> Procedure for
> all APs.
> @param[in,out] Token This is an optional parameter that allows
> the caller to execute the
> procedure in a blocking or non-blocking fashion. If it is
> NULL the
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-31 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-30 6:40 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code Zhang, Shenglei
2019-07-30 14:05 ` Laszlo Ersek
2019-07-31 2:28 ` Dong, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox