From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=DY3th/C9; spf=pass (domain: linaro.org, ip: 209.85.167.66, mailfrom: haojian.zhuang@linaro.org) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by groups.io with SMTP; Tue, 30 Jul 2019 00:33:11 -0700 Received: by mail-lf1-f66.google.com with SMTP id q26so44002164lfc.3 for ; Tue, 30 Jul 2019 00:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EjmhXD4b2wxx6mgGLki5yvA7gP3jyxgyNwjLiYwczuA=; b=DY3th/C991E/CGT3pXFl2wvoHzmrXKSAwOqwR82sigVV+UGK1G/M+cE3k1zEzUMrdT iZ4dA9Amp5mEQfkf9vMUxk9v2/1FknSIHhWY4o/QGtnrnDBk6q2f3HNdZy7tNYjQEc7S v6nMcTbb2Q5/6sfe88iRAE3UM/Ia1G/cE4LTYl/6IzUVK6UL+6/aQdoap14E/jiWoiZH A8cj5zg98rBY38xr7uK80aGVHSnV7qXf36DPabMgHepB35Z7jebRt9lr/MA7/8LykyHI 2Fpjef/MDiEHtbcpBmPS1XUve+Pjw3F9NHNSfn3Aokqyn6yPbk5EJeBr1qQQWN4boUeM o49g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EjmhXD4b2wxx6mgGLki5yvA7gP3jyxgyNwjLiYwczuA=; b=FvYnZ6dZAwUfyBliHDZkJQAZMpF6ZDOodCI0L7wsEUv77c2KLDMTxNSSXifrbHsniy pGAwH4ge620xM0gwUTeFIPvu3P+NinNKHxao/Tj/v7ZzKtXp6H2AO9a4LWV13GlgkEIP J0m+DupNTRICxXrOIv5uqNHXuabGa+SuuLuZ29S14M1DDqM7h4/oZBQ1tvO48jiEB65J dR7eXWIAVWh7wzRAzjpbHoxBqoN7HVC6Pek3L/8el68NO6g9Uf0K8dJRlxxwB4HBEORN JhkONxY+YYaUtUIPOtqIasLlHZy/I/nNMzJeU7dHtbRNx9fi2wRoOWUDAf77ASklHqCt IWvQ== X-Gm-Message-State: APjAAAWzmmJZ9bXKGTxWduVmCishBaXfWU/LjzqOR1UvDp0BjWChe2tf 7pAZuEIfq++zUmSlgsJ27nSXrw== X-Google-Smtp-Source: APXvYqz6ZqVY4EbznKGl70ROPkzCA2QLYFrH89J1vHjLKdl44vTpcR1DlLVvlQ8u/XbUWgFrf4mTHg== X-Received: by 2002:ac2:50cd:: with SMTP id h13mr30951331lfm.36.1564471988894; Tue, 30 Jul 2019 00:33:08 -0700 (PDT) Return-Path: Received: from gmail.com ([58.32.33.92]) by smtp.gmail.com with ESMTPSA id 189sm12324005lfa.0.2019.07.30.00.33.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2019 00:33:08 -0700 (PDT) Date: Tue, 30 Jul 2019 15:33:02 +0800 From: "Haojian Zhuang" To: tien.hock.loh@intel.com, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, christopher.Co@microsoft.com Cc: devel@edk2.groups.io, thloh85@gmail.com Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver Message-ID: <20190730073300.GH6058@gmail.com> References: <20190724092606.185319-1-tien.hock.loh@intel.com> MIME-Version: 1.0 In-Reply-To: <20190724092606.185319-1-tien.hock.loh@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock.loh@intel.com wrote: > From: "Tien Hock, Loh" > > Changelog: > v3: > * Fix an issue in NonDiscoverableDeviceDxe driver where it did not invalidate > cache before copying the memory. > v2: > *Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc protocol, > and the other is for DwMmcHcDxe driver. > v1: > *Add NonDiscoverableDeviceDxe for embedded platform. Make DwMmcHcDxe driver > to support both eMMC and SD controller. > > Haojian Zhuang (3): > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > EmbeddedPkg: add PlatformDwMmc protocol > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 +++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 ++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 +++++++++++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 +++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 ++++++++ > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > EmbeddedPkg/EmbeddedPkg.dec | 1 + > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > .../NonDiscoverableDeviceDxe.c | 243 ++ > .../NonDiscoverableDeviceDxe.inf | 52 + > .../NonDiscoverableDeviceIo.c | 976 +++++++ > .../NonDiscoverableDeviceIo.h | 92 + > 16 files changed, 9495 insertions(+) > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceDxe.inf > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.c > create mode 100644 EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDeviceIo.h > > -- > 2.19.0 > Hi Leif, Ard & Chris, Could you help to share your comments on this patch set? Best Regards Haojian