* [edk2-platforms] [PATCH v2 1/6] Vlv2TbltDevicePkg: Adjust the device priority
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
@ 2019-07-30 8:16 ` Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 2/6] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp Gary Lin
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Gary Lin @ 2019-07-30 8:16 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Zailiang Sun, Yi Qian, Michael D Kinney
In BootOptionPriority(), the higher number implies the lower boot
priority. This commit lowers the priority of network booting and raises
the priority of the local devices. Besides, SD and EMMC are also added
to BootOptionPriority() since Minnowboard comes with a SD card slot.
v2:
Also match MSG_URI_DP to sort HTTP Boot options
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c | 29 ++++++++++----------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
index 84aa097d58..195b3f3097 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
@@ -499,11 +499,10 @@ BootOptionType (
Returns the priority number.
OptionType EFI
------------------------------------
- PXE 2
- DVD 4
- USB 6
- NVME 7
- HDD 8
+ HDD 2
+ USB 4
+ SATA/NVME/SD 6
+ PXE/HTTP 8
EFI Shell 9
Others 100
@@ -518,21 +517,23 @@ BootOptionPriority (
// EFI boot options
//
switch (BootOptionType (BootOption->FilePath)) {
- case MSG_MAC_ADDR_DP:
- case MSG_VLAN_DP:
- case MSG_IPv4_DP:
- case MSG_IPv6_DP:
- return 2;
+ case MSG_USB_DP:
+ return 4;
case MSG_SATA_DP:
case MSG_ATAPI_DP:
case MSG_UFS_DP:
case MSG_NVME_NAMESPACE_DP:
- return 4;
-
- case MSG_USB_DP:
+ case MSG_SD_DP:
+ case MSG_EMMC_DP:
return 6;
+ case MSG_MAC_ADDR_DP:
+ case MSG_VLAN_DP:
+ case MSG_IPv4_DP:
+ case MSG_IPv6_DP:
+ case MSG_URI_DP:
+ return 8;
}
if (StrCmp (BootOption->Description, INTERNAL_UEFI_SHELL_NAME) == 0) {
if (PcdGetBool (PcdBootToShellOnly)) {
@@ -541,7 +542,7 @@ BootOptionPriority (
return 9;
}
if (StrCmp (BootOption->Description, UEFI_HARD_DRIVE_NAME) == 0) {
- return 8;
+ return 2;
}
return 100;
}
--
2.22.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [edk2-platforms] [PATCH v2 2/6] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 1/6] Vlv2TbltDevicePkg: Adjust the device priority Gary Lin
@ 2019-07-30 8:16 ` Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 3/6] Vlv2TbltDevicePkg: Only sort boot options when necessary Gary Lin
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Gary Lin @ 2019-07-30 8:16 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Zailiang Sun, Yi Qian, Michael D Kinney
* BootManagerMenuApp wasn't imported so the Boot Device Menu never showed
correctly.
* Also fix the description of UiApp.
In the "Rule.Common.UEFI_APPLICATION.UI" section, it intends to change
the description of UiApp to "Enter Setup" to make the boot option
self-explaining in the Boot Menu. But this didn't happen since the rule
wasn't assigned to UiApp correctly, so the Boot Menu only showed "UiApp"
which is not understandable to users. This patch adds "RuleOverride = UI"
to UiApp.inf to change the description.
v2:
Update the description
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 3 ++-
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
index 48058b663a..55a309444f 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
@@ -417,7 +417,8 @@ INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
INF MdeModulePkg/Universal/Metronome/Metronome.inf
INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
INF MdeModulePkg/Logo/LogoDxe.inf
-INF MdeModulePkg/Application/UiApp/UiApp.inf
+INF RuleOverride = UI MdeModulePkg/Application/UiApp/UiApp.inf
+INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 30b47d8f32..463b952e65 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -924,6 +924,7 @@
NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
}
+ MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 57316d487b..ee18b45c97 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -939,6 +939,7 @@
NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
}
+ MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
--
2.22.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [edk2-platforms] [PATCH v2 3/6] Vlv2TbltDevicePkg: Only sort boot options when necessary
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 1/6] Vlv2TbltDevicePkg: Adjust the device priority Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 2/6] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp Gary Lin
@ 2019-07-30 8:16 ` Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 4/6] Vlv2TbltDevicePkg: Clean up the unused variables and function Gary Lin
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Gary Lin @ 2019-07-30 8:16 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Zailiang Sun, Yi Qian, Michael D Kinney
* PlatformBootManagerAfterConsole() always sorted the boot options at
the end, and this would invalidate the BootOrder created by the user.
Besides, the current implementation would sort the boot options twice,
and this is not efficient. We should just sort the boot options once
at the end of the function only for the very first boot.
* Update the string in IsNeedSortBootOption() to match the description
of BootManagerMenuApp.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c
index 7fbbf281c6..a5423013a5 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c
@@ -1299,7 +1299,7 @@ IsNeedSortBootOption (
//
if ((BootOptionCount > 1) &&
(((StrnCmp (BootOptions->Description, L"Enter Setup", StrLen (L"Enter Setup"))) == 0) ||
- ((StrnCmp (BootOptions->Description, L"BootManagerMenuApp", StrLen (L"BootManagerMenuApp"))) == 0))) {
+ ((StrnCmp (BootOptions->Description, L"Boot Device List", StrLen (L"Boot Device List"))) == 0))) {
return TRUE;
}
@@ -1374,9 +1374,6 @@ PlatformBootManagerAfterConsole (
//
EfiBootManagerRefreshAllBootOption ();
- if (IsNeedSortBootOption()) {
- EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot, CompareBootOption);
- }
//
// PXE boot option may appear after boot option enumeration
//
@@ -1400,7 +1397,9 @@ PlatformBootManagerAfterConsole (
Print (L"Press F7 for BootMenu!\n");
EfiBootManagerRefreshAllBootOption ();
- EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot, CompareBootOption);
+ if (IsNeedSortBootOption()) {
+ EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot, CompareBootOption);
+ }
}
/**
--
2.22.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [edk2-platforms] [PATCH v2 4/6] Vlv2TbltDevicePkg: Clean up the unused variables and function
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
` (2 preceding siblings ...)
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 3/6] Vlv2TbltDevicePkg: Only sort boot options when necessary Gary Lin
@ 2019-07-30 8:16 ` Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits Gary Lin
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Gary Lin @ 2019-07-30 8:16 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Zailiang Sun, Yi Qian, Michael D Kinney
In PlatformBootOption.c:
* mContinueBoot and mBootMenuBoot were assigned as "!EnterSetup" before
being used. However, EnterSetup is always "FALSE", so it's meaningless
to keep those variables.
* mPxeBoot is defined but never used.
* DetectKeypressCallback() is never used. So we can remove it altogether
with mHotKeypressed and HotKeyEvent.
* RegisterBootOptionHotkey() only uses EFI_INPUT_KEY from EFI_KEY_DATA,
so we don't need to use EFI_KEY_DATA for F2 and F7 in
RegisterStaticHotkey().
v2:
Update the description for the removal of EFI_KEY_DATA
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c | 57 ++++----------------
1 file changed, 11 insertions(+), 46 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
index 195b3f3097..7b0c2ea336 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
@@ -10,12 +10,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/PcdLib.h>
-BOOLEAN mContinueBoot = FALSE;
-BOOLEAN mBootMenuBoot = FALSE;
-BOOLEAN mPxeBoot = FALSE;
-BOOLEAN mHotKeypressed = FALSE;
-EFI_EVENT HotKeyEvent = NULL;
-
UINTN mBootMenuOptionNumber;
EFI_DEVICE_PATH_PROTOCOL *
@@ -396,21 +390,6 @@ RegisterBootOptionHotkey (
}
}
-EFI_STATUS
-EFIAPI
-DetectKeypressCallback (
- IN EFI_KEY_DATA *KeyData
-)
-{
- mHotKeypressed = TRUE;
-
- if (HotKeyEvent != NULL) {
- gBS->SignalEvent(HotKeyEvent);
- }
-
- return EFI_SUCCESS;
-}
-
/**
This function is called after all the boot options are enumerated and ordered properly.
**/
@@ -419,46 +398,32 @@ RegisterStaticHotkey (
VOID
)
{
-
EFI_INPUT_KEY Enter;
- EFI_KEY_DATA F2;
- EFI_KEY_DATA F7;
- BOOLEAN EnterSetup;
+ EFI_INPUT_KEY F2;
+ EFI_INPUT_KEY F7;
EFI_STATUS Status;
EFI_BOOT_MANAGER_LOAD_OPTION BootOption;
- EnterSetup = FALSE;
-
//
// [Enter]
//
- mContinueBoot = !EnterSetup;
- if (mContinueBoot) {
- Enter.ScanCode = SCAN_NULL;
- Enter.UnicodeChar = CHAR_CARRIAGE_RETURN;
- EfiBootManagerRegisterContinueKeyOption (0, &Enter, NULL);
- }
-
+ Enter.ScanCode = SCAN_NULL;
+ Enter.UnicodeChar = CHAR_CARRIAGE_RETURN;
+ EfiBootManagerRegisterContinueKeyOption (0, &Enter, NULL);
//
// [F2]/[F7]
//
- F2.Key.ScanCode = SCAN_F2;
- F2.Key.UnicodeChar = CHAR_NULL;
- F2.KeyState.KeyShiftState = EFI_SHIFT_STATE_VALID;
- F2.KeyState.KeyToggleState = 0;
+ F2.ScanCode = SCAN_F2;
+ F2.UnicodeChar = CHAR_NULL;
Status = EfiBootManagerGetBootManagerMenu (&BootOption);
ASSERT_EFI_ERROR (Status);
- RegisterBootOptionHotkey ((UINT16) BootOption.OptionNumber, &F2.Key, TRUE);
+ RegisterBootOptionHotkey ((UINT16) BootOption.OptionNumber, &F2, TRUE);
EfiBootManagerFreeLoadOption (&BootOption);
- F7.Key.ScanCode = SCAN_F7;
- F7.Key.UnicodeChar = CHAR_NULL;
- F7.KeyState.KeyShiftState = EFI_SHIFT_STATE_VALID;
- F7.KeyState.KeyToggleState = 0;
- mBootMenuBoot = !EnterSetup;
- RegisterBootOptionHotkey ((UINT16) mBootMenuOptionNumber, &F7.Key, mBootMenuBoot);
-
+ F7.ScanCode = SCAN_F7;
+ F7.UnicodeChar = CHAR_NULL;
+ RegisterBootOptionHotkey ((UINT16) mBootMenuOptionNumber, &F7, TRUE);
}
UINT8
--
2.22.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
` (3 preceding siblings ...)
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 4/6] Vlv2TbltDevicePkg: Clean up the unused variables and function Gary Lin
@ 2019-07-30 8:16 ` Gary Lin
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 6/6] Vlv2TbltDevicePkg: Convert the device GUIDs of capsules to lowercase Gary Lin
2019-08-08 7:26 ` [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Michael D Kinney
6 siblings, 0 replies; 11+ messages in thread
From: Gary Lin @ 2019-07-30 8:16 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Zailiang Sun, Yi Qian, Michael D Kinney
fwupd 1.2.10 checks the bit 3 of BIOS Characteristics Extension Byte 2,
i.e. UefiSpecificationSupported, to determine if the system supports
UEFI or not. Since the bit was missing, fwupd failed to load uefi
plugin.
This commit adds 3 bits of BIOS Characteristics Extension Byte 2:
TargetContentDistributionEnabled, UefiSpecificationSupported, and
VirtualMachineSupported to complete the table.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h | 5 ++++-
Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
index f57a5a8c0f..83749709ff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
@@ -1742,7 +1742,10 @@ typedef struct {
UINT64 SmartBatteryIsSupported :1;
UINT64 BiosBootSpecIsSupported :1;
UINT64 FunctionKeyNetworkBootIsSupported :1;
- UINT64 Reserved :22;
+ UINT64 TargetContentDistributionEnabled :1;
+ UINT64 UefiSpecificationSupported :1;
+ UINT64 VirtualMachineSupported :1;
+ UINT64 Reserved :19;
} EFI_MISC_BIOS_CHARACTERISTICS;
typedef struct {
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
index 91e8efc228..f564e64d04 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
@@ -87,7 +87,10 @@ MISC_SMBIOS_TABLE_DATA(EFI_MISC_BIOS_VENDOR_DATA, MiscBiosVendor)
//
1, // BiosBootSpecIsSupported :1
1, // FunctionKeyNetworkBootIsSupported :1
- 0x1 // Reserved :19 Bit 2 is SMBiosIsTargContDistEnabled
+ 1, // TargetContentDistributionEnabled :1
+ 1, // UefiSpecificationSupported :1
+ 0, // VirtualMachineSupported :1
+ 0 // Reserved :19
},
{ // BiosCharacteristics2
0x0001,// BiosReserved :16 Bit 0 is BIOS Splash Screen
--
2.22.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [edk2-platforms] [PATCH v2 6/6] Vlv2TbltDevicePkg: Convert the device GUIDs of capsules to lowercase
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
` (4 preceding siblings ...)
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits Gary Lin
@ 2019-07-30 8:16 ` Gary Lin
2019-08-08 7:26 ` [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Michael D Kinney
6 siblings, 0 replies; 11+ messages in thread
From: Gary Lin @ 2019-07-30 8:16 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Zailiang Sun, Yi Qian, Michael D Kinney
LVFS assumes the GUIDs in the metainfo.xml are lowercase, so fwupdmgr
may fail to match the devices. Convert the GUIDs to lowercase to be
compatible with LVFS.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py | 24 ++++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
index b2fd65a6c6..a37648ac96 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
@@ -370,28 +370,28 @@ if __name__ == '__main__':
#
# Generate capsules for the Red Sample Device
#
- GenCapsuleSampleDevice('Red','72E2945A-00DA-448E-9AA7-075AD840F9D4',0x00000010,0x00000000, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Red','72E2945A-00DA-448E-9AA7-075AD840F9D4',0x00000011,0x00000000, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Red','72E2945A-00DA-448E-9AA7-075AD840F9D4',0x00000012,0x00000000, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Red','72e2945a-00da-448e-9aa7-075ad840f9d4',0x00000010,0x00000000, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Red','72e2945a-00da-448e-9aa7-075ad840f9d4',0x00000011,0x00000000, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Red','72e2945a-00da-448e-9aa7-075ad840f9d4',0x00000012,0x00000000, CapsulesPath, CapsulesSubDir)
#
# Generate capsules for the Green Sample Device
#
- GenCapsuleSampleDevice('Green','79179BFD-704D-4C90-9E02-0AB8D968C18A',0x00000020,0x00000020, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Green','79179BFD-704D-4C90-9E02-0AB8D968C18A',0x00000021,0x00000020, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Green','79179BFD-704D-4C90-9E02-0AB8D968C18A',0x00000022,0x00000020, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Green','79179bfd-704d-4c90-9e02-0ab8d968c18a',0x00000020,0x00000020, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Green','79179bfd-704d-4c90-9e02-0ab8d968c18a',0x00000021,0x00000020, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Green','79179bfd-704d-4c90-9e02-0ab8d968c18a',0x00000022,0x00000020, CapsulesPath, CapsulesSubDir)
#
# Generate capsules for the Blue Sample Device
#
- GenCapsuleSampleDevice('Blue','149DA854-7D19-4FAA-A91E-862EA1324BE6',0x00000010,0x00000000, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Blue','149DA854-7D19-4FAA-A91E-862EA1324BE6',0x00000011,0x00000000, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Blue','149DA854-7D19-4FAA-A91E-862EA1324BE6',0x00000012,0x00000012, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Blue','149DA854-7D19-4FAA-A91E-862EA1324BE6',0x00000013,0x00000012, CapsulesPath, CapsulesSubDir)
- GenCapsuleSampleDevice('Blue','149DA854-7D19-4FAA-A91E-862EA1324BE6',0x00000014,0x00000012, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Blue','149da854-7d19-4faa-a91e-862ea1324be6',0x00000010,0x00000000, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Blue','149da854-7d19-4faa-a91e-862ea1324be6',0x00000011,0x00000000, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Blue','149da854-7d19-4faa-a91e-862ea1324be6',0x00000012,0x00000012, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Blue','149da854-7d19-4faa-a91e-862ea1324be6',0x00000013,0x00000012, CapsulesPath, CapsulesSubDir)
+ GenCapsuleSampleDevice('Blue','149da854-7d19-4faa-a91e-862ea1324be6',0x00000014,0x00000012, CapsulesPath, CapsulesSubDir)
#
# Generate capsules for Minnow Max Firmware Updates
#
RomFileName = os.path.join (EdkiiBuildOutput, 'FV', 'VLV.fd')
- GenCapsuleDevice('MinnowMax', RomFileName,'4096267B-DA0A-42EB-B5EB-FEF31D207CB4',0x0000000C,0x00000000, CapsulesPath, CapsulesSubDir)
+ GenCapsuleDevice('MinnowMax', RomFileName,'4096267b-da0a-42eb-b5eb-fef31d207cb4',0x0000000C,0x00000000, CapsulesPath, CapsulesSubDir)
--
2.22.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard
2019-07-30 8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
` (5 preceding siblings ...)
2019-07-30 8:16 ` [edk2-platforms] [PATCH v2 6/6] Vlv2TbltDevicePkg: Convert the device GUIDs of capsules to lowercase Gary Lin
@ 2019-08-08 7:26 ` Michael D Kinney
2019-08-08 8:08 ` [edk2-devel] " Gary Lin
6 siblings, 1 reply; 11+ messages in thread
From: Michael D Kinney @ 2019-08-08 7:26 UTC (permalink / raw)
To: Gary Lin, devel@edk2.groups.io, Kinney, Michael D; +Cc: Sun, Zailiang, Qian, Yi
Hi Gary,
Thank you for these patches.
I am seeing one behavior change in the setup forms.
The following 2 forms are missing information that
used to be filled in. I will help look into this
tomorrow.
1) Device Manager -> System Setup -> Main
2) Device Manager -> System Setup -> Main -> Platform Information
Best regards,
Mike
> -----Original Message-----
> From: Gary Lin [mailto:GLin@suse.com]
> Sent: Tuesday, July 30, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> <yi.qian@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-platforms] [PATCH v2 0/6] Fix the boot
> order, SMBIOS, and capsule GUIDs of Minnowboard
>
> After switching to MdeModulePkg BdsDxe, the boot option
> created by OS was always put at the end of BootOrder
> after reboot. Besides, the PXE boot options were always
> the first boot options.
>
> The 1st to 3rd patches fix the priority of boot options
> and stop sorting the boot options after the first boot.
> The missing BootManagerMenuApp is also added back.
>
> The 4th patch cleans up PlatformBootOption.c to remove
> the unused variables and function.
>
> The 5th patch adds some missing bits of BIOS
> Characteristics Extension in SMBIOS, so that fwupd can
> detect the system correctly.
>
> The 6th patch converts the device GUIDs in metainfo.xml
> to lowercase to be compatible with LVFS/fwupd.
>
> The patches are also available in my github branch:
> https://github.com/lcp/edk2-platforms/tree/fix-
> minnowboard-bds-v2
>
> v2:
> * Add the missing MSG_URI_DP to BootOptionPriority()
> * Update the descriptioins of 2nd and 4th patches
> * Add the 5th and 6th patches
>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Gary Lin (6):
> Vlv2TbltDevicePkg: Adjust the device priority
> Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp
> Vlv2TbltDevicePkg: Only sort boot options when
> necessary
> Vlv2TbltDevicePkg: Clean up the unused variables and
> function
> Vlv2TbltDevicePkg: Add the missing SMBIOS bits
> Vlv2TbltDevicePkg: Convert the device GUIDs of
> capsules to lowercase
>
>
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera
> teCapsule/GenCapsuleAll.py | 24 +++---
>
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> tManagerLib/BdsPlatform.c | 9 +-
>
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> tManagerLib/PlatformBootOption.c | 86 ++++++-----------
> ---
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> | 3 +-
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> | 1 +
>
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR
> ecords.h | 5 +-
>
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios
> VendorData.c | 5 +-
> 8 files changed, 54 insertions(+), 80 deletions(-)
>
> --
> 2.22.0
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard
2019-08-08 7:26 ` [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Michael D Kinney
@ 2019-08-08 8:08 ` Gary Lin
2019-08-08 15:03 ` Michael D Kinney
0 siblings, 1 reply; 11+ messages in thread
From: Gary Lin @ 2019-08-08 8:08 UTC (permalink / raw)
To: devel@edk2.groups.io, michael.d.kinney@intel.com; +Cc: Yi Qian, Zailiang Sun
On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D Kinney wrote:
> Hi Gary,
>
Hi Michael,
> Thank you for these patches.
>
> I am seeing one behavior change in the setup forms.
> The following 2 forms are missing information that
> used to be filled in. I will help look into this
> tomorrow.
>
> 1) Device Manager -> System Setup -> Main
>
> 2) Device Manager -> System Setup -> Main -> Platform Information
>
I built another firmware without my patches and those information were
still missing, so the bug is probably introduced by other patch.
Thanks,
Gary Lin
> Best regards,
>
> Mike
>
> > -----Original Message-----
> > From: Gary Lin [mailto:GLin@suse.com]
> > Sent: Tuesday, July 30, 2019 1:16 AM
> > To: devel@edk2.groups.io
> > Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> > <yi.qian@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the boot
> > order, SMBIOS, and capsule GUIDs of Minnowboard
> >
> > After switching to MdeModulePkg BdsDxe, the boot option
> > created by OS was always put at the end of BootOrder
> > after reboot. Besides, the PXE boot options were always
> > the first boot options.
> >
> > The 1st to 3rd patches fix the priority of boot options
> > and stop sorting the boot options after the first boot.
> > The missing BootManagerMenuApp is also added back.
> >
> > The 4th patch cleans up PlatformBootOption.c to remove
> > the unused variables and function.
> >
> > The 5th patch adds some missing bits of BIOS
> > Characteristics Extension in SMBIOS, so that fwupd can
> > detect the system correctly.
> >
> > The 6th patch converts the device GUIDs in metainfo.xml
> > to lowercase to be compatible with LVFS/fwupd.
> >
> > The patches are also available in my github branch:
> > https://github.com/lcp/edk2-platforms/tree/fix-
> > minnowboard-bds-v2
> >
> > v2:
> > * Add the missing MSG_URI_DP to BootOptionPriority()
> > * Update the descriptioins of 2nd and 4th patches
> > * Add the 5th and 6th patches
> >
> > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > Cc: Yi Qian <yi.qian@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Gary Lin (6):
> > Vlv2TbltDevicePkg: Adjust the device priority
> > Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp
> > Vlv2TbltDevicePkg: Only sort boot options when
> > necessary
> > Vlv2TbltDevicePkg: Clean up the unused variables and
> > function
> > Vlv2TbltDevicePkg: Add the missing SMBIOS bits
> > Vlv2TbltDevicePkg: Convert the device GUIDs of
> > capsules to lowercase
> >
> >
> > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera
> > teCapsule/GenCapsuleAll.py | 24 +++---
> >
> > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> > tManagerLib/BdsPlatform.c | 9 +-
> >
> > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> > tManagerLib/PlatformBootOption.c | 86 ++++++-----------
> > ---
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> > | 3 +-
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > | 1 +
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > | 1 +
> >
> > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR
> > ecords.h | 5 +-
> >
> > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios
> > VendorData.c | 5 +-
> > 8 files changed, 54 insertions(+), 80 deletions(-)
> >
> > --
> > 2.22.0
>
>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard
2019-08-08 8:08 ` [edk2-devel] " Gary Lin
@ 2019-08-08 15:03 ` Michael D Kinney
2019-08-09 19:15 ` Michael D Kinney
0 siblings, 1 reply; 11+ messages in thread
From: Michael D Kinney @ 2019-08-08 15:03 UTC (permalink / raw)
To: devel@edk2.groups.io, glin@suse.com, Kinney, Michael D
Cc: Qian, Yi, Sun, Zailiang
Hi Gary,
Thanks for the additional information.
I will investigate when it was introduced.
The patch series looks good.
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin
> Sent: Thursday, August 8, 2019 1:08 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2
> 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of
> Minnowboard
>
> On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D
> Kinney wrote:
> > Hi Gary,
> >
> Hi Michael,
>
> > Thank you for these patches.
> >
> > I am seeing one behavior change in the setup forms.
> > The following 2 forms are missing information that
> used to be filled
> > in. I will help look into this tomorrow.
> >
> > 1) Device Manager -> System Setup -> Main
> >
> > 2) Device Manager -> System Setup -> Main -> Platform
> Information
> >
> I built another firmware without my patches and those
> information were still missing, so the bug is probably
> introduced by other patch.
>
> Thanks,
>
> Gary Lin
>
> > Best regards,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Gary Lin [mailto:GLin@suse.com]
> > > Sent: Tuesday, July 30, 2019 1:16 AM
> > > To: devel@edk2.groups.io
> > > Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian,
> Yi
> > > <yi.qian@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the
> boot order, SMBIOS,
> > > and capsule GUIDs of Minnowboard
> > >
> > > After switching to MdeModulePkg BdsDxe, the boot
> option created by
> > > OS was always put at the end of BootOrder after
> reboot. Besides, the
> > > PXE boot options were always the first boot
> options.
> > >
> > > The 1st to 3rd patches fix the priority of boot
> options and stop
> > > sorting the boot options after the first boot.
> > > The missing BootManagerMenuApp is also added back.
> > >
> > > The 4th patch cleans up PlatformBootOption.c to
> remove the unused
> > > variables and function.
> > >
> > > The 5th patch adds some missing bits of BIOS
> Characteristics
> > > Extension in SMBIOS, so that fwupd can detect the
> system correctly.
> > >
> > > The 6th patch converts the device GUIDs in
> metainfo.xml to lowercase
> > > to be compatible with LVFS/fwupd.
> > >
> > > The patches are also available in my github branch:
> > > https://github.com/lcp/edk2-platforms/tree/fix-
> > > minnowboard-bds-v2
> > >
> > > v2:
> > > * Add the missing MSG_URI_DP to
> BootOptionPriority()
> > > * Update the descriptioins of 2nd and 4th patches
> > > * Add the 5th and 6th patches
> > >
> > > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > > Cc: Yi Qian <yi.qian@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > Gary Lin (6):
> > > Vlv2TbltDevicePkg: Adjust the device priority
> > > Vlv2TbltDevicePkg: Add the missing
> BootManagerMenuApp
> > > Vlv2TbltDevicePkg: Only sort boot options when
> necessary
> > > Vlv2TbltDevicePkg: Clean up the unused variables
> and function
> > > Vlv2TbltDevicePkg: Add the missing SMBIOS bits
> > > Vlv2TbltDevicePkg: Convert the device GUIDs of
> capsules to
> > > lowercase
> > >
> > >
> > >
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera
> > > teCapsule/GenCapsuleAll.py | 24 +++---
> > >
> > >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> > > tManagerLib/BdsPlatform.c | 9 +-
> > >
> > >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> > > tManagerLib/PlatformBootOption.c | 86 ++++++-------
> ----
> > > ---
> > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> > > | 3 +-
> > >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > > | 1 +
> > >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > > | 1 +
> > >
> > >
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR
> > > ecords.h | 5 +-
> > >
> > >
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios
> > > VendorData.c | 5 +-
> > > 8 files changed, 54 insertions(+), 80 deletions(-)
> > >
> > > --
> > > 2.22.0
> >
> >
> >
> >
> >
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard
2019-08-08 15:03 ` Michael D Kinney
@ 2019-08-09 19:15 ` Michael D Kinney
0 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2019-08-09 19:15 UTC (permalink / raw)
To: devel@edk2.groups.io, glin@suse.com, Kinney, Michael D
Cc: Qian, Yi, Sun, Zailiang
Hi Gary,
I found that the regression was introduced at commit
https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
The issue is in Vlv2Tbl2DevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
The call to SetupInfo() was inadvertently removed from
SystemConfigExtractConfig() when that function was simplified
due to the varstore type change to efivarstore.
I have verified that adding back the call to SetupInfo()
restores the missing values in those setup forms.
I have pushed your series as:
812b291c55..603ec40dbb
I will send patch review for the regression later today.
Mike
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, August 8, 2019 8:04 AM
> To: devel@edk2.groups.io; glin@suse.com; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: RE: [edk2-devel] [edk2-platforms] [PATCH v2
> 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of
> Minnowboard
>
> Hi Gary,
>
> Thanks for the additional information.
> I will investigate when it was introduced.
>
> The patch series looks good.
>
> Reviewed-by: Michael D Kinney
> <michael.d.kinney@intel.com>
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io
> > [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin
> > Sent: Thursday, August 8, 2019 1:08 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > <zailiang.sun@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2
> 0/6] Fix the boot
> > order, SMBIOS, and capsule GUIDs of Minnowboard
> >
> > On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D
> Kinney wrote:
> > > Hi Gary,
> > >
> > Hi Michael,
> >
> > > Thank you for these patches.
> > >
> > > I am seeing one behavior change in the setup forms.
> > > The following 2 forms are missing information that
> > used to be filled
> > > in. I will help look into this tomorrow.
> > >
> > > 1) Device Manager -> System Setup -> Main
> > >
> > > 2) Device Manager -> System Setup -> Main ->
> Platform
> > Information
> > >
> > I built another firmware without my patches and those
> information were
> > still missing, so the bug is probably introduced by
> other patch.
> >
> > Thanks,
> >
> > Gary Lin
> >
> > > Best regards,
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > Sent: Tuesday, July 30, 2019 1:16 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian,
> > Yi
> > > > <yi.qian@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the
> > boot order, SMBIOS,
> > > > and capsule GUIDs of Minnowboard
> > > >
> > > > After switching to MdeModulePkg BdsDxe, the boot
> > option created by
> > > > OS was always put at the end of BootOrder after
> > reboot. Besides, the
> > > > PXE boot options were always the first boot
> > options.
> > > >
> > > > The 1st to 3rd patches fix the priority of boot
> > options and stop
> > > > sorting the boot options after the first boot.
> > > > The missing BootManagerMenuApp is also added
> back.
> > > >
> > > > The 4th patch cleans up PlatformBootOption.c to
> > remove the unused
> > > > variables and function.
> > > >
> > > > The 5th patch adds some missing bits of BIOS
> > Characteristics
> > > > Extension in SMBIOS, so that fwupd can detect the
> > system correctly.
> > > >
> > > > The 6th patch converts the device GUIDs in
> > metainfo.xml to lowercase
> > > > to be compatible with LVFS/fwupd.
> > > >
> > > > The patches are also available in my github
> branch:
> > > > https://github.com/lcp/edk2-platforms/tree/fix-
> > > > minnowboard-bds-v2
> > > >
> > > > v2:
> > > > * Add the missing MSG_URI_DP to
> > BootOptionPriority()
> > > > * Update the descriptioins of 2nd and 4th
> patches
> > > > * Add the 5th and 6th patches
> > > >
> > > > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > > > Cc: Yi Qian <yi.qian@intel.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > >
> > > > Gary Lin (6):
> > > > Vlv2TbltDevicePkg: Adjust the device priority
> > > > Vlv2TbltDevicePkg: Add the missing
> > BootManagerMenuApp
> > > > Vlv2TbltDevicePkg: Only sort boot options when
> > necessary
> > > > Vlv2TbltDevicePkg: Clean up the unused
> variables
> > and function
> > > > Vlv2TbltDevicePkg: Add the missing SMBIOS bits
> > > > Vlv2TbltDevicePkg: Convert the device GUIDs of
> > capsules to
> > > > lowercase
> > > >
> > > >
> > > >
> >
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera
> > > > teCapsule/GenCapsuleAll.py | 24 +++---
> > > >
> > > >
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> > > > tManagerLib/BdsPlatform.c | 9 +-
> > > >
> > > >
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo
> > > > tManagerLib/PlatformBootOption.c | 86 ++++++-----
> --
> > ----
> > > > ---
> > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> > > > | 3 +-
> > > >
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > > > | 1 +
> > > >
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > > > | 1 +
> > > >
> > > >
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR
> > > > ecords.h | 5 +-
> > > >
> > > >
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios
> > > > VendorData.c | 5 +-
> > > > 8 files changed, 54 insertions(+), 80
> deletions(-)
> > > >
> > > > --
> > > > 2.22.0
> > >
> > >
> > >
> > >
> > >
> >
> >
^ permalink raw reply [flat|nested] 11+ messages in thread