public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gary Lin" <glin@suse.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Zailiang Sun <zailiang.sun@intel.com>,
	Yi Qian <yi.qian@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits
Date: Tue, 30 Jul 2019 08:16:20 +0000	[thread overview]
Message-ID: <20190730081518.16349-6-glin@suse.com> (raw)
In-Reply-To: <20190730081518.16349-1-glin@suse.com>

fwupd 1.2.10 checks the bit 3 of BIOS Characteristics Extension Byte 2,
i.e. UefiSpecificationSupported, to determine if the system supports
UEFI or not. Since the bit was missing, fwupd failed to load uefi
plugin.

This commit adds 3 bits of BIOS Characteristics Extension Byte 2:
TargetContentDistributionEnabled, UefiSpecificationSupported, and
VirtualMachineSupported to complete the table.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h     | 5 ++++-
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
index f57a5a8c0f..83749709ff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
@@ -1742,7 +1742,10 @@ typedef struct {
   UINT64                            SmartBatteryIsSupported           :1;
   UINT64                            BiosBootSpecIsSupported           :1;
   UINT64                            FunctionKeyNetworkBootIsSupported :1;
-  UINT64                            Reserved                          :22;
+  UINT64                            TargetContentDistributionEnabled  :1;
+  UINT64                            UefiSpecificationSupported        :1;
+  UINT64                            VirtualMachineSupported           :1;
+  UINT64                            Reserved                          :19;
 } EFI_MISC_BIOS_CHARACTERISTICS;
 
 typedef struct {
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
index 91e8efc228..f564e64d04 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
@@ -87,7 +87,10 @@ MISC_SMBIOS_TABLE_DATA(EFI_MISC_BIOS_VENDOR_DATA, MiscBiosVendor)
 //
     1,    // BiosBootSpecIsSupported           :1
     1,    // FunctionKeyNetworkBootIsSupported :1
-    0x1     // Reserved                          :19  Bit 2 is SMBiosIsTargContDistEnabled
+    1,    // TargetContentDistributionEnabled  :1
+    1,    // UefiSpecificationSupported        :1
+    0,    // VirtualMachineSupported           :1
+    0     // Reserved                          :19
   },
   {       // BiosCharacteristics2
     0x0001,// BiosReserved                      :16  Bit 0 is BIOS Splash Screen
-- 
2.22.0


  parent reply	other threads:[~2019-07-30  8:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  8:16 [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Gary Lin
2019-07-30  8:16 ` [edk2-platforms] [PATCH v2 1/6] Vlv2TbltDevicePkg: Adjust the device priority Gary Lin
2019-07-30  8:16 ` [edk2-platforms] [PATCH v2 2/6] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp Gary Lin
2019-07-30  8:16 ` [edk2-platforms] [PATCH v2 3/6] Vlv2TbltDevicePkg: Only sort boot options when necessary Gary Lin
2019-07-30  8:16 ` [edk2-platforms] [PATCH v2 4/6] Vlv2TbltDevicePkg: Clean up the unused variables and function Gary Lin
2019-07-30  8:16 ` Gary Lin [this message]
2019-07-30  8:16 ` [edk2-platforms] [PATCH v2 6/6] Vlv2TbltDevicePkg: Convert the device GUIDs of capsules to lowercase Gary Lin
2019-08-08  7:26 ` [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Michael D Kinney
2019-08-08  8:08   ` [edk2-devel] " Gary Lin
2019-08-08 15:03     ` Michael D Kinney
2019-08-09 19:15       ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730081518.16349-6-glin@suse.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox