From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.68, mailfrom: glin@suse.com) Received: from m9a0003g.houston.softwaregrp.com (m9a0003g.houston.softwaregrp.com [15.124.64.68]) by groups.io with SMTP; Tue, 30 Jul 2019 01:19:17 -0700 Received: FROM m9a0003g.houston.softwaregrp.com (15.121.0.191) BY m9a0003g.houston.softwaregrp.com WITH ESMTP; Tue, 30 Jul 2019 08:19:14 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 30 Jul 2019 08:16:21 +0000 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (15.124.72.12) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Tue, 30 Jul 2019 08:16:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YYjGFPjzL7pQbVvpiRxVsMcHeSzrjIAaKt0KNFXxSMlRyCVo0HUyo3s484PiC38wRoZ4+cEmoGDsDWzpb5moqUZ1or3jqgYUzlsyP3yaOBSgdhj/B6WNPILe7UC83fna7gYWtPrIFevjj+GGKxhLClQKb2ImEsW1NyKx/cotPr8quy5gBu6Ud8QH/B8TZSgFkuIRrQEQfC4UD+RLIoS+exmY7dJEJYppEIJuSNXbzgE+HmqGRYHGsD8SwHFAh/XrBUoI4ZA4SSVUj9HOU5nOvqNyE7b1G4sOCB+n83wzjnK7mWuS04Jq5+LAaXoBdVVJG/Nxcw8lXEoquZtNgtkv/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=foFlRcI8/aXJZGN4lRPY+hR5cHuqxQoriiyb7C16lNk=; b=ONLESk5YUkvZvA5wDWe4KqRUMj95c4/kTbj9AvWFfSguC+s+hwVlpmiyrYN/+CKZpQNXNyps4TDBxKY5Wkdc5XyT1vdDwyDvIcirMp8RUgELHB3ZOsg1xUw0nO9+rLErlaCxdZGVhyRGYWJWPLWvEmrO+kq9O+oEK/MF2F+ytzc3Cto5P+GIifQP2JXC69BHKlTWKnsGNXglMpKxjrBQi9wEphWSgHEYQKk4UWZscmfZxehpW5ONFoPFmhjQqZHbecUSth2zkElc8uAWozaPrcDbcoEq5ygGaLcC8j5i6o2UDPG/NTnyUIm3LWLyTpeQa1iuzDQZVYCCR9kze0/whA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3068.namprd18.prod.outlook.com (20.179.48.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Tue, 30 Jul 2019 08:16:20 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 08:16:20 +0000 From: "Gary Lin" To: "devel@edk2.groups.io" CC: Zailiang Sun , Yi Qian , Michael D Kinney Subject: [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits Thread-Topic: [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits Thread-Index: AQHVRq8RXp+ydil64E+q91miWn8GjA== Date: Tue, 30 Jul 2019 08:16:20 +0000 Message-ID: <20190730081518.16349-6-glin@suse.com> References: <20190730081518.16349-1-glin@suse.com> In-Reply-To: <20190730081518.16349-1-glin@suse.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6PR1001CA0031.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::17) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.22.0 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57b8c537-ea00-4c34-831c-08d714c63400 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3068; x-ms-traffictypediagnostic: DM6PR18MB3068: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:248; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(376002)(136003)(346002)(39860400002)(396003)(366004)(189003)(199004)(5660300002)(6436002)(76176011)(52116002)(25786009)(2351001)(3846002)(53936002)(71200400001)(26005)(6916009)(486006)(476003)(71190400001)(446003)(11346002)(4326008)(6486002)(68736007)(8676002)(5640700003)(186003)(2616005)(2501003)(316002)(86362001)(66446008)(66066001)(478600001)(50226002)(81156014)(14454004)(1730700003)(256004)(6116002)(64756008)(36756003)(66556008)(81166006)(54906003)(102836004)(6512007)(66946007)(2906002)(80792005)(7736002)(99286004)(6506007)(386003)(305945005)(1076003)(8936002)(66476007);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3068;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uC2eA5aGzwajBL6OkCxgQsg67FaxQRkIQQZaygEl3Rwl72xMyka0nW+9kz7q99XiFMRpEzQXKS6hO3OurEvtnzngcayo0dYrH0+G4HkGPBfRVI0ujqpsAOZb8FmIuzsMG/lMMMNRPhDCERlf+yziUeTRdQ/eTwcqfbSeX6UtJsYAFIv8uBfEB0tpDgG+oDuvQIfRJRzYt1SvEFXE8XIkB50jjIiSB6/iVFrx6jzyZymSmab3gTYis0MSn5+S06OHjzJyV1+1CH2hV180G2JD1+MXbtqFieFJ1wuZDQblSCua7mP+AIEmFSVaQBB8mTOISt2X5QNJVsHMJHdBwx5kMiqukKhRPcK2ARze8Xtk7TeNwNFOdYEHFgp8dk4HrcufisnX/XyRWKtS2j/rx3kMj60HOQj6YTjUr1qG950AI24= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 57b8c537-ea00-4c34-831c-08d714c63400 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 08:16:20.5982 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3068 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable fwupd 1.2.10 checks the bit 3 of BIOS Characteristics Extension Byte 2, i.e. UefiSpecificationSupported, to determine if the system supports UEFI or not. Since the bit was missing, fwupd failed to load uefi plugin. This commit adds 3 bits of BIOS Characteristics Extension Byte 2: TargetContentDistributionEnabled, UefiSpecificationSupported, and VirtualMachineSupported to complete the table. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h | 5 ++= ++- Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c | 5 ++= ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.= h b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h index f57a5a8c0f..83749709ff 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h @@ -1742,7 +1742,10 @@ typedef struct { UINT64 SmartBatteryIsSupported :1; UINT64 BiosBootSpecIsSupported :1; UINT64 FunctionKeyNetworkBootIsSupported :1; - UINT64 Reserved :22; + UINT64 TargetContentDistributionEnabled :1; + UINT64 UefiSpecificationSupported :1; + UINT64 VirtualMachineSupported :1; + UINT64 Reserved :19; } EFI_MISC_BIOS_CHARACTERISTICS; =20 typedef struct { diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorD= ata.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c index 91e8efc228..f564e64d04 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c @@ -87,7 +87,10 @@ MISC_SMBIOS_TABLE_DATA(EFI_MISC_BIOS_VENDOR_DATA, MiscBi= osVendor) // 1, // BiosBootSpecIsSupported :1 1, // FunctionKeyNetworkBootIsSupported :1 - 0x1 // Reserved :19 Bit 2 is SMBiosIsTar= gContDistEnabled + 1, // TargetContentDistributionEnabled :1 + 1, // UefiSpecificationSupported :1 + 0, // VirtualMachineSupported :1 + 0 // Reserved :19 }, { // BiosCharacteristics2 0x0001,// BiosReserved :16 Bit 0 is BIOS Splash = Screen --=20 2.22.0