public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Philippe Mathieu-Daude <philmd@redhat.com>
Cc: devel@edk2.groups.io, Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors
Date: Tue, 30 Jul 2019 15:01:10 +0100	[thread overview]
Message-ID: <20190730140110.GH22656@bivouac.eciton.net> (raw)
In-Reply-To: <20190729180321.1715-1-philmd@redhat.com>

On Mon, Jul 29, 2019 at 08:03:19PM +0200, Philippe Mathieu-Daude wrote:
> Hi,
> 
> This series completes the cleanup from commit 1fce963d89f3 ("ArmPkg:
> DebugPeCoffExtraActionLib: debugger commands are not errors", from
> 2015-03-02), on PeCoffLoaderUnloadImageExtraAction().
> 
> This solves an issue when building in silent mode with
> -D DEBUG_PRINT_ERROR_LEVEL=0x80000000. With the QemuRamFbDxe platform
> DXE driver, when we get a driver dispatch failure it is reported as
> an error level:
> 
> qemu-system-aarch64 -machine virt,gic-version=3,accel=kvm -cpu host \
>   -display none -serial stdio -bios /usr/share/AAVMF/AAVMF_CODE.fd
> remove-symbol-file /builddir/build/BUILD/edk2-89910a39dcfd/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/OvmfPkg/QemuRamfbDxe/QemuRamfbDxe/DEBUG/QemuRamfbDxe.dll 0x3F5F6000
> 
> The second patch is an obvious typo fix.

I added the word "comment" in subject/message of 2/2, to make
it explicit that the typo does not affect functionality.

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 8fed4e47d9a6..3d34b5f32692.

Thanks!

> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (2):
>   ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors
>   ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos
> 
>  .../DebugPeCoffExtraActionLib.c                      | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> -- 
> 2.20.1
> 

  parent reply	other threads:[~2019-07-30 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 18:03 [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Philippe Mathieu-Daudé
2019-07-29 18:03 ` [PATCH 1/2] " Philippe Mathieu-Daudé
2019-07-30 13:25   ` Laszlo Ersek
2019-07-29 18:03 ` [PATCH 2/2] ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos Philippe Mathieu-Daudé
2019-07-30 13:26   ` Laszlo Ersek
2019-07-30 14:01 ` Leif Lindholm [this message]
2019-07-30 14:07   ` [edk2-devel] [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730140110.GH22656@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox