From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=zABXuflp; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Tue, 30 Jul 2019 07:01:14 -0700 Received: by mail-wm1-f68.google.com with SMTP id p74so57250864wme.4 for ; Tue, 30 Jul 2019 07:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=w7rCHVVpkzPR60v8FIJv1LiggWysKYabYXNXheW5GDU=; b=zABXuflp80x/C2OAltZR+eFFwrw1jOO2Vrfpl8O6vo7No8Y5V0PjHDxB+8aNnaciI3 pzQpBwWZG9WRnGhTWGt3g3e5mNSFX36rGMUvUBr1wd/W6+GRqATSDDBTYm+YCmeStfKZ fM0SXlrkiGL8g3wqkiBTeb10DloIGC9niEAAzEVzMD8AYwnK/tRwYY5eQs11iWLeWFAM b+Vh7Rk6pAUYY24XX9ifbw+OlhfCnMjs6ROEAgpDNjlZI7ZyQauBC9YVCWTkKbcGZsRx wPOnw0mv8H69byGwFG6fquwA2vZwboeVV+OgiDTky4tR3crXA1LCqYx4yPjkOlHqzQf7 xvbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=w7rCHVVpkzPR60v8FIJv1LiggWysKYabYXNXheW5GDU=; b=Cw1XD68C9KIl1Z4idO5GDlTS4ZGGJopUvsJ5XsRdvuTjrBq6FmbUxdU0VSCHSh1LVK 1bhaNVyUn87x2MqCqxcIDkWog5LNMs90pGvG1aJIYnyVFkl5YaFzcmRcwmK97Q73imLh kD0nfA5XbELPE4GD8klrAlWy2NTem/w6RGVNmzSu1TeRqhiwg6bd/RxHNKWysGkjOMKz PnM1kVAFzNh3vbEjMisqfVHpZswfUvNetooFcAPxLe8ehrTuMPMNe5kKDI34EiFyEQFV HkhXzzJpsVbzPor0cHAfb44RFsOfm9WTsSYbg9TyKX6DDswJYU9O/IrtA6j/IOv9UeI6 4pUA== X-Gm-Message-State: APjAAAWkJmdtxecD0NzewOSSpwBHzxseFpXJ/BTSFrDHIbNVnl+ozA2i wzpAT9jeDZ+tIuN83iwqsSv1Ng== X-Google-Smtp-Source: APXvYqxUH791vXb6sA33asALvlH4PmAs6i8XzaFjchhLqGDYdYYDQ7dZ1f+lLMCBOxacell1Ql0byQ== X-Received: by 2002:a1c:99c6:: with SMTP id b189mr96544407wme.57.1564495272356; Tue, 30 Jul 2019 07:01:12 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n12sm67792204wmc.24.2019.07.30.07.01.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 07:01:11 -0700 (PDT) Date: Tue, 30 Jul 2019 15:01:10 +0100 From: "Leif Lindholm" To: Philippe Mathieu-Daude Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel Subject: Re: [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Message-ID: <20190730140110.GH22656@bivouac.eciton.net> References: <20190729180321.1715-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20190729180321.1715-1-philmd@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jul 29, 2019 at 08:03:19PM +0200, Philippe Mathieu-Daude wrote: > Hi, > > This series completes the cleanup from commit 1fce963d89f3 ("ArmPkg: > DebugPeCoffExtraActionLib: debugger commands are not errors", from > 2015-03-02), on PeCoffLoaderUnloadImageExtraAction(). > > This solves an issue when building in silent mode with > -D DEBUG_PRINT_ERROR_LEVEL=0x80000000. With the QemuRamFbDxe platform > DXE driver, when we get a driver dispatch failure it is reported as > an error level: > > qemu-system-aarch64 -machine virt,gic-version=3,accel=kvm -cpu host \ > -display none -serial stdio -bios /usr/share/AAVMF/AAVMF_CODE.fd > remove-symbol-file /builddir/build/BUILD/edk2-89910a39dcfd/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/OvmfPkg/QemuRamfbDxe/QemuRamfbDxe/DEBUG/QemuRamfbDxe.dll 0x3F5F6000 > > The second patch is an obvious typo fix. I added the word "comment" in subject/message of 2/2, to make it explicit that the typo does not affect functionality. Reviewed-by: Leif Lindholm Pushed as 8fed4e47d9a6..3d34b5f32692. Thanks! > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): > ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors > ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos > > .../DebugPeCoffExtraActionLib.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > -- > 2.20.1 >