From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: shenglei.zhang@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Tue, 30 Jul 2019 20:38:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 20:38:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,328,1559545200"; d="scan'208";a="255988697" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga001.jf.intel.com with ESMTP; 30 Jul 2019 20:38:13 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: shenglei , Eric Dong , Ray Ni , Laszlo Ersek Subject: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments Date: Wed, 31 Jul 2019 11:38:12 +0800 Message-Id: <20190731033812.12188-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 From: shenglei 1.Remove "out" attribute for " Buffer" parameter in function header. 2.Add "out" attribute for " Token" parameter in function header. 3.Update ProcedureArgument to ProcedureArguments. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- v2:In v1 update comments consistent with code In v2 update code consistent with comments UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c index ef16997547b8..328d7ae53a49 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -1404,7 +1404,7 @@ InternalSmmStartupAllAPs ( EFI_STATUS EFIAPI ProcedureWrapper ( - IN OUT VOID *Buffer + IN VOID *Buffer ) { PROCEDURE_WRAPPER *Wrapper; diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index 186809f43119..a0e59f20886b 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1329,7 +1329,7 @@ InternalSmmStartupThisAp ( IN EFI_AP_PROCEDURE2 Procedure, IN UINTN CpuIndex, IN OUT VOID *ProcArguments OPTIONAL, - IN MM_COMPLETION *Token, + IN OUT MM_COMPLETION *Token, IN UINTN TimeoutInMicroseconds, IN OUT EFI_STATUS *CpuStatus ); @@ -1387,7 +1387,7 @@ IsPresentAp ( @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for APs to return from Procedure, either for blocking or non-blocking mode. - @param[in,out] ProcedureArgument The parameter passed into Procedure for + @param[in,out] ProcedureArguments The parameter passed into Procedure for all APs. @param[in,out] Token This is an optional parameter that allows the caller to execute the procedure in a blocking or non-blocking fashion. If it is NULL the -- 2.18.0.windows.1